Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(indexer): Update git ignroe to ignore binaries #5945

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

roninjin10
Copy link
Contributor

  • add binaries to git ignore

@roninjin10 roninjin10 requested a review from a team as a code owner June 9, 2023 05:37
@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2023

⚠️ No Changeset found

Latest commit: 684bd2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@semgrep-app
Copy link
Contributor

semgrep-app bot commented Jun 9, 2023

Semgrep found 1 use-tls finding:

  • indexer/api/api.go: L104

Found an HTTP server without TLS. Use 'http.ListenAndServeTLS' instead. See https://golang.org/pkg/net/http/#ListenAndServeTLS for more information.

Ignore this finding from use-tls.

@semgrep-app
Copy link
Contributor

semgrep-app bot commented Jun 9, 2023

Semgrep found 12 todos_require_linear findings:

  • packages/data-transport-layer/src/services/l1-ingestion/service.ts: L167
  • packages/data-transport-layer/src/utils/contracts.ts: L75
  • packages/data-transport-layer/src/db/simple-db.ts: L10, L37
  • packages/data-transport-layer/src/services/main/service.ts: L121
  • packages/data-transport-layer/src/services/server/service.ts: L138, L226, L227, L228
  • packages/data-transport-layer/src/services/l1-ingestion/handlers/sequencer-batch-appended.ts: L34, L88
  • packages/data-transport-layer/src/utils/validation.ts: L41

Please create a Linear ticket for this TODO.

Ignore this finding from todos_require_linear.

@roninjin10 roninjin10 changed the base branch from willc/dotenv to develop June 10, 2023 01:31
@roninjin10 roninjin10 force-pushed the willc/ignorebinariesgitignore branch from f1dadd4 to 684bd2d Compare June 10, 2023 01:31
@netlify
Copy link

netlify bot commented Jun 10, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 684bd2d
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6483d27f77bdf600082aa07b

@OptimismBot OptimismBot deleted the willc/ignorebinariesgitignore branch June 10, 2023 01:37
@mergify
Copy link
Contributor

mergify bot commented Jun 10, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 10, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-indexer Area: indexer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants