-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add design principles vignette #38
Conversation
8d70caa
to
2329fa3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 8 8
Lines 574 574
=======================================
Hits 567 567
Misses 7 7 ☔ View full report in Codecov by Sentry. |
f552303
to
47f6b39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Only some small suggestions.
As a general point for text-based files such as this one or .tex
files I'm a big fan of the "one line per sentence" (rather than 80 character cutoff) format as it makes changes easier to apply/visualise in a diff-based interface such as the one used by github. But everyone has different preferences/editors etc. so I don't think there's a hard and fast rule.
Thanks. It's a good point. I'll do that in the future and make sure R Studio wraps it (for me) to make it easier to work with. |
e815d49
to
1657537
Compare
1657537
to
fa2d8db
Compare
Merging this as it has already been reviewed. |
This PR closes #34 by adding a design vignette to the package website.