Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-security

.buildkite/scripts/pipelines/pull_request/pipeline.ts

@@ -42,7 +42,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
     pipeline.push(getAgentImageConfig({ returnYaml: true }));
     pipeline.push(getPipeline('.buildkite/pipelines/pull_request/base.yml', false));
 
-    if (await doAnyChangesMatch([/^packages\/kbn-handlebars/])) {
+    if (await doAnyChangesMatch([/^src\/platform\/packages\/private\/kbn-handlebars/])) {
       pipeline.push(getPipeline('.buildkite/pipelines/pull_request/kbn_handlebars.yml'));
     }
 
@@ -224,7 +224,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
     if (
       (await doAnyChangesMatch([
         /^packages\/kbn-securitysolution-.*/,
-        /^x-pack\/plugins\/security_solution/,
+        /^x-pack\/platform\/plugins\/shared\/security_solution/,
         /^x-pack\/test\/defend_workflows_cypress/,
         /^x-pack\/test\/security_solution_cypress/,
         /^fleet_packages\.json/,
@@ -244,9 +244,9 @@ const getPipeline = (filename: string, removeSteps = true) => {
         /^x-pack\/plugins\/data_views\/common/,
         /^x-pack\/plugins\/lists/,
         /^x-pack\/plugins\/rule_registry\/common/,
-        /^x-pack\/plugins\/security_solution/,
-        /^x-pack\/plugins\/security_solution_ess/,
-        /^x-pack\/plugins\/security_solution_serverless/,
+        /^x-pack\/platform\/plugins\/shared\/security_solution/,
+        /^x-pack\/platform\/plugins\/shared\/security_solution_ess/,
+        /^x-pack\/platform\/plugins\/shared\/security_solution_serverless/,
         /^x-pack\/plugins\/task_manager/,
         /^x-pack\/plugins\/timelines/,
         /^x-pack\/plugins\/triggers_actions_ui\/public\/application\/sections\/action_connector_form/,
@@ -295,7 +295,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
         /^packages\/kbn-resizable-layout/,
         /^packages\/kbn-rison/,
         /^packages\/kbn-rule-data-utils/,
-        /^packages\/kbn-safer-lodash-set/,
+        /^src\/platform\/packages\/shared\/kbn-safer-lodash-set/,
         /^packages\/kbn-search-types/,
         /^packages\/kbn-securitysolution-.*/,
         /^packages\/kbn-securitysolution-ecs/,
@@ -330,9 +330,9 @@ const getPipeline = (filename: string, removeSteps = true) => {
         /^x-pack\/plugins\/elastic_assistant/,
         /^x-pack\/plugins\/lists/,
         /^x-pack\/plugins\/rule_registry\/common/,
-        /^x-pack\/plugins\/security_solution/,
-        /^x-pack\/plugins\/security_solution_ess/,
-        /^x-pack\/plugins\/security_solution_serverless/,
+        /^x-pack\/platform\/plugins\/shared\/security_solution/,
+        /^x-pack\/platform\/plugins\/shared\/security_solution_ess/,
+        /^x-pack\/platform\/plugins\/shared\/security_solution_serverless/,
         /^x-pack\/plugins\/task_manager/,
         /^x-pack\/plugins\/threat_intelligence/,
         /^x-pack\/plugins\/timelines/,
@@ -352,7 +352,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
       ((await doAnyChangesMatch([
         /^x-pack\/plugins\/osquery/,
         /^x-pack\/test\/osquery_cypress/,
-        /^x-pack\/plugins\/security_solution/,
+        /^x-pack\/platform\/plugins\/shared\/security_solution/,
       ])) ||
         GITHUB_PR_LABELS.includes('ci:all-cypress-suites')) &&
       !GITHUB_PR_LABELS.includes('ci:skip-cypress-osquery')
@@ -366,7 +366,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
       (await doAnyChangesMatch([
         /^x-pack\/packages\/kbn-cloud-security-posture/,
         /^x-pack\/plugins\/cloud_security_posture/,
-        /^x-pack\/plugins\/security_solution/,
+        /^x-pack\/platform\/plugins\/shared\/security_solution/,
         /^x-pack\/test\/security_solution_cypress/,
       ])) ||
       GITHUB_PR_LABELS.includes('ci:all-cypress-suites')

.buildkite/scripts/steps/test/kbn_handlebars.sh

@@ -5,4 +5,4 @@ set -euo pipefail
 source .buildkite/scripts/common/util.sh
 
 echo '--- Checking for @kbn/handlebars upstream updates'
-packages/kbn-handlebars/scripts/check_for_upstream_updates.sh
+src/platform/packages/private/kbn-handlebars/scripts/check_for_upstream_updates.sh

.eslintrc.js

@@ -84,7 +84,7 @@ const ELV2_LICENSE_HEADER = `
 const SAFER_LODASH_SET_HEADER = `
 /*
  * Elasticsearch B.V licenses this file to you under the MIT License.
- * See \`packages/kbn-safer-lodash-set/LICENSE\` for more information.
+ * See \`src/platform/packages/shared/kbn-safer-lodash-set/LICENSE\` for more information.
  */
 `;
 
@@ -93,7 +93,7 @@ const SAFER_LODASH_SET_LODASH_HEADER = `
  * This file is forked from the lodash project (https://lodash.com/),
  * and may include modifications made by Elasticsearch B.V.
  * Elasticsearch B.V. licenses this file to you under the MIT License.
- * See \`packages/kbn-safer-lodash-set/LICENSE\` for more information.
+ * See \`src/platform/packages/shared/kbn-safer-lodash-set/LICENSE\` for more information.
  */
 `;
 
@@ -102,14 +102,14 @@ const SAFER_LODASH_SET_DEFINITELYTYPED_HEADER = `
  * This file is forked from the DefinitelyTyped project (https://github.com/DefinitelyTyped/DefinitelyTyped),
  * and may include modifications made by Elasticsearch B.V.
  * Elasticsearch B.V. licenses this file to you under the MIT License.
- * See \`packages/kbn-safer-lodash-set/LICENSE\` for more information.
+ * See \`src/platform/packages/shared/kbn-safer-lodash-set/LICENSE\` for more information.
  */
 `;
 
 const KBN_HANDLEBARS_HEADER = `
 /*
  * Elasticsearch B.V licenses this file to you under the MIT License.
- * See \`packages/kbn-handlebars/LICENSE\` for more information.
+ * See \`src/platform/packages/private/kbn-handlebars/LICENSE\` for more information.
  */
 `;
 
@@ -118,7 +118,7 @@ const KBN_HANDLEBARS_HANDLEBARS_HEADER = `
   * This file is forked from the handlebars project (https://github.com/handlebars-lang/handlebars.js),
   * and may include modifications made by Elasticsearch B.V.
   * Elasticsearch B.V. licenses this file to you under the MIT License.
-  * See \`packages/kbn-handlebars/LICENSE\` for more information.
+  * See \`src/platform/packages/private/kbn-handlebars/LICENSE\` for more information.
   */
 `;
 
@@ -441,7 +441,7 @@ module.exports = {
      * safer-lodash-set package requires special license headers
      */
     {
-      files: ['packages/kbn-safer-lodash-set/**/*.{js,mjs,ts,tsx}'],
+      files: ['src/platform/packages/shared/kbn-safer-lodash-set/**/*.{js,mjs,ts,tsx}'],
       rules: {
         '@kbn/eslint/require-license-header': [
           'error',
@@ -471,7 +471,7 @@ module.exports = {
     },
 
     {
-      files: ['packages/kbn-safer-lodash-set/test/*.{js,mjs,ts,tsx}'],
+      files: ['src/platform/packages/shared/kbn-safer-lodash-set/test/*.{js,mjs,ts,tsx}'],
       rules: {
         '@kbn/eslint/require-license-header': [
           'error',
@@ -500,7 +500,7 @@ module.exports = {
       },
     },
     {
-      files: ['packages/kbn-safer-lodash-set/**/*.d.ts'],
+      files: ['src/platform/packages/shared/kbn-safer-lodash-set/**/*.d.ts'],
       rules: {
         '@kbn/eslint/require-license-header': [
           'error',
@@ -533,7 +533,7 @@ module.exports = {
      * @kbn/handlebars package requires special license headers
      */
     {
-      files: ['packages/kbn-handlebars/**/*.{js,mjs,ts,tsx}'],
+      files: ['src/platform/packages/private/kbn-handlebars/**/*.{js,mjs,ts,tsx}'],
       rules: {
         '@kbn/eslint/require-license-header': [
           'error',
@@ -562,7 +562,7 @@ module.exports = {
       },
     },
     {
-      files: ['packages/kbn-handlebars/src/spec/**/*.{js,mjs,ts,tsx}'],
+      files: ['src/platform/packages/private/kbn-handlebars/src/spec/**/*.{js,mjs,ts,tsx}'],
       rules: {
         '@kbn/eslint/require-license-header': [
           'error',
@@ -779,7 +779,7 @@ module.exports = {
      * Harden specific rules
      */
     {
-      files: ['test/harden/*.js', 'packages/kbn-safer-lodash-set/test/*.js'],
+      files: ['test/harden/*.js', 'src/platform/packages/shared/kbn-safer-lodash-set/test/*.js'],
       rules: {
         'mocha/handle-done-callback': 'off',
       },
@@ -1824,24 +1824,24 @@ module.exports = {
      */
     {
       files: [
-        'src/plugins/interactive_setup/**/*.{js,mjs,ts,tsx}',
+        'src/platform/plugins/private/interactive_setup/**/*.{js,mjs,ts,tsx}',
         'test/interactive_setup_api_integration/**/*.{js,mjs,ts,tsx}',
         'test/interactive_setup_functional/**/*.{js,mjs,ts,tsx}',
 
         'packages/kbn-mock-idp-plugin/**/*.{js,mjs,ts,tsx}',
         'packages/kbn-mock-idp-utils/**/*.{js,mjs,ts,tsx}',
-        'packages/kbn-security-hardening/**/*.{js,mjs,ts,tsx}',
-        'packages/kbn-user-profile-components/**/*.{js,mjs,ts,tsx}',
+        'src/platform/packages/shared/kbn-security-hardening/**/*.{js,mjs,ts,tsx}',
+        'src/platform/packages/shared/kbn-user-profile-components/**/*.{js,mjs,ts,tsx}',
 
-        'x-pack/plugins/encrypted_saved_objects/**/*.{js,mjs,ts,tsx}',
+        'x-pack/platform/plugins/shared/encrypted_saved_objects/**/*.{js,mjs,ts,tsx}',
         'x-pack/test/encrypted_saved_objects_api_integration/**/*.{js,mjs,ts,tsx}',
 
-        'x-pack/plugins/security/**/*.{js,mjs,ts,tsx}',
+        'x-pack/platform/plugins/shared/security/**/*.{js,mjs,ts,tsx}',
         'x-pack/packages/security/**/*.{js,mjs,ts,tsx}',
         'x-pack/test/security_api_integration/**/*.{js,mjs,ts,tsx}',
         'x-pack/test/security_functional/**/*.{js,mjs,ts,tsx}',
 
-        'x-pack/plugins/spaces/**/*.{js,mjs,ts,tsx}',
+        'x-pack/platform/plugins/shared/spaces/**/*.{js,mjs,ts,tsx}',
         'x-pack/test/spaces_api_integration/**/*.{js,mjs,ts,tsx}',
       ],
       rules: {

.github/CODEOWNERS

@@ -320,7 +320,6 @@ packages/kbn-config @elastic/kibana-core
 packages/kbn-config-mocks @elastic/kibana-core
 packages/kbn-config-schema @elastic/kibana-core
 packages/kbn-content-management-utils @elastic/kibana-data-discovery
-packages/kbn-crypto @elastic/kibana-security
 packages/kbn-crypto-browser @elastic/kibana-core
 packages/kbn-custom-icons @elastic/obs-ux-logs-team
 packages/kbn-custom-integrations @elastic/obs-ux-logs-team
@@ -377,7 +376,6 @@ packages/kbn-get-repo-files @elastic/kibana-operations
 packages/kbn-grid-layout @elastic/kibana-presentation
 packages/kbn-grouping @elastic/response-ops
 packages/kbn-guided-onboarding @elastic/appex-sharedux
-packages/kbn-handlebars @elastic/kibana-security
 packages/kbn-hapi-mocks @elastic/kibana-core
 packages/kbn-health-gateway-server @elastic/kibana-core
 packages/kbn-i18n @elastic/kibana-core
@@ -465,7 +463,6 @@ packages/kbn-router-to-openapispec @elastic/kibana-core
 packages/kbn-router-utils @elastic/obs-ux-logs-team
 packages/kbn-rrule @elastic/response-ops
 packages/kbn-rule-data-utils @elastic/security-detections-response @elastic/response-ops @elastic/obs-ux-management-team
-packages/kbn-safer-lodash-set @elastic/kibana-security
 packages/kbn-saved-objects-settings @elastic/appex-sharedux
 packages/kbn-saved-search-component @elastic/obs-ux-logs-team
 packages/kbn-scout @elastic/appex-qa
@@ -478,7 +475,6 @@ packages/kbn-search-errors @elastic/kibana-data-discovery
 packages/kbn-search-index-documents @elastic/search-kibana
 packages/kbn-search-response-warnings @elastic/kibana-data-discovery
 packages/kbn-search-types @elastic/kibana-data-discovery
-packages/kbn-security-hardening @elastic/kibana-security
 packages/kbn-securitysolution-autocomplete @elastic/security-detection-engine
 packages/kbn-securitysolution-ecs @elastic/security-threat-hunting-explore
 packages/kbn-securitysolution-endpoint-exceptions-common @elastic/security-detection-engine
@@ -539,7 +535,6 @@ packages/kbn-unified-field-list @elastic/kibana-data-discovery
 packages/kbn-unsaved-changes-badge @elastic/kibana-data-discovery
 packages/kbn-unsaved-changes-prompt @elastic/kibana-management
 packages/kbn-use-tracked-promise @elastic/obs-ux-logs-team
-packages/kbn-user-profile-components @elastic/kibana-security
 packages/kbn-utility-types @elastic/kibana-core
 packages/kbn-utility-types-jest @elastic/kibana-operations
 packages/kbn-utils @elastic/kibana-operations
@@ -622,7 +617,13 @@ packages/shared-ux/storybook/config @elastic/appex-sharedux
 packages/shared-ux/storybook/mock @elastic/appex-sharedux
 packages/shared-ux/table_persist @elastic/appex-sharedux
 src/core @elastic/kibana-core
+src/platform/packages/private/kbn-handlebars @elastic/kibana-security
+src/platform/packages/shared/kbn-crypto @elastic/kibana-security
 src/platform/packages/shared/kbn-doc-links @elastic/docs
+src/platform/packages/shared/kbn-safer-lodash-set @elastic/kibana-security
+src/platform/packages/shared/kbn-security-hardening @elastic/kibana-security
+src/platform/packages/shared/kbn-user-profile-components @elastic/kibana-security
+src/platform/plugins/private/interactive_setup @elastic/kibana-security
 src/plugins/advanced_settings @elastic/appex-sharedux @elastic/kibana-management
 src/plugins/ai_assistant_management/selection @elastic/obs-ai-assistant
 src/plugins/bfetch @elastic/appex-sharedux
@@ -670,7 +671,6 @@ src/plugins/home @elastic/appex-sharedux
 src/plugins/image_embeddable @elastic/appex-sharedux
 src/plugins/input_control_vis @elastic/kibana-presentation
 src/plugins/inspector @elastic/kibana-presentation
-src/plugins/interactive_setup @elastic/kibana-security
 src/plugins/kibana_overview @elastic/appex-sharedux
 src/plugins/kibana_react @elastic/appex-sharedux
 src/plugins/kibana_usage_collection @elastic/kibana-core
@@ -853,18 +853,21 @@ x-pack/packages/security-solution/navigation @elastic/security-threat-hunting-ex
 x-pack/packages/security-solution/side_nav @elastic/security-threat-hunting-explore
 x-pack/packages/security-solution/storybook/config @elastic/security-threat-hunting-explore
 x-pack/packages/security-solution/upselling @elastic/security-threat-hunting-explore
-x-pack/packages/security/api_key_management @elastic/kibana-security
-x-pack/packages/security/authorization_core @elastic/kibana-security
-x-pack/packages/security/authorization_core_common @elastic/kibana-security
-x-pack/packages/security/form_components @elastic/kibana-security
-x-pack/packages/security/plugin_types_common @elastic/kibana-security
-x-pack/packages/security/plugin_types_public @elastic/kibana-security
-x-pack/packages/security/plugin_types_server @elastic/kibana-security
-x-pack/packages/security/role_management_model @elastic/kibana-security
-x-pack/packages/security/ui_components @elastic/kibana-security
 x-pack/performance @elastic/appex-qa
+x-pack/platform/packages/private/security/authorization_core @elastic/kibana-security
+x-pack/platform/packages/private/security/authorization_core_common @elastic/kibana-security
+x-pack/platform/packages/private/security/role_management_model @elastic/kibana-security
+x-pack/platform/packages/private/security/ui_components @elastic/kibana-security
 x-pack/platform/packages/shared/kbn-entities-schema @elastic/obs-entities
+x-pack/platform/packages/shared/security/api_key_management @elastic/kibana-security
+x-pack/platform/packages/shared/security/form_components @elastic/kibana-security
+x-pack/platform/packages/shared/security/plugin_types_common @elastic/kibana-security
+x-pack/platform/packages/shared/security/plugin_types_public @elastic/kibana-security
+x-pack/platform/packages/shared/security/plugin_types_server @elastic/kibana-security
+x-pack/platform/plugins/shared/encrypted_saved_objects @elastic/kibana-security
 x-pack/platform/plugins/shared/entity_manager @elastic/obs-entities
+x-pack/platform/plugins/shared/security @elastic/kibana-security
+x-pack/platform/plugins/shared/spaces @elastic/kibana-security
 x-pack/plugins/actions @elastic/response-ops
 x-pack/plugins/ai_infra/llm_tasks @elastic/appex-ai-infra
 x-pack/plugins/ai_infra/product_doc_base @elastic/appex-ai-infra
@@ -893,7 +896,6 @@ x-pack/plugins/drilldowns/url_drilldown @elastic/appex-sharedux
 x-pack/plugins/ecs_data_quality_dashboard @elastic/security-threat-hunting-explore
 x-pack/plugins/elastic_assistant @elastic/security-generative-ai
 x-pack/plugins/embeddable_enhanced @elastic/kibana-presentation
-x-pack/plugins/encrypted_saved_objects @elastic/kibana-security
 x-pack/plugins/enterprise_search @elastic/search-kibana
 x-pack/plugins/event_log @elastic/response-ops
 x-pack/plugins/features @elastic/kibana-core
@@ -969,7 +971,6 @@ x-pack/plugins/search_notebooks @elastic/search-kibana
 x-pack/plugins/search_playground @elastic/search-kibana
 x-pack/plugins/search_solution/search_navigation @elastic/search-kibana
 x-pack/plugins/searchprofiler @elastic/kibana-management
-x-pack/plugins/security @elastic/kibana-security
 x-pack/plugins/security_solution @elastic/security-solution
 x-pack/plugins/security_solution_ess @elastic/security-solution
 x-pack/plugins/security_solution_serverless @elastic/security-solution
@@ -978,7 +979,6 @@ x-pack/plugins/serverless_observability @elastic/obs-ux-management-team
 x-pack/plugins/serverless_search @elastic/search-kibana
 x-pack/plugins/session_view @elastic/kibana-cloud-security-posture
 x-pack/plugins/snapshot_restore @elastic/kibana-management
-x-pack/plugins/spaces @elastic/kibana-security
 x-pack/plugins/stack_alerts @elastic/response-ops
 x-pack/plugins/stack_connectors @elastic/response-ops
 x-pack/plugins/streams @elastic/streams-program-team
@@ -1048,9 +1048,7 @@ x-pack/test_serverless/api_integration/test_suites/common/platform_security @ela
 
 # Observability Entities Team (@elastic/obs-entities)
 /x-pack/plugins/observability_solution/entities_data_access @elastic/obs-entities
-/x-pack/packages/kbn-entities-schema @elastic/obs-entities
 /x-pack/test/api_integration/apis/entity_manager/fixture_plugin @elastic/obs-entities
-/x-pack/plugins/entity_manager @elastic/obs-entities
 /x-pack/test/api_integration/apis/entity_manager @elastic/obs-entities
 
 

.i18nrc.json

@@ -72,7 +72,7 @@
     "inputControl": "src/plugins/input_control_vis",
     "inspector": "src/plugins/inspector",
     "inspectorViews": "src/legacy/core_plugins/inspector_views",
-    "interactiveSetup": "src/plugins/interactive_setup",
+    "interactiveSetup": "src/platform/plugins/private/interactive_setup",
     "interpreter": "src/legacy/core_plugins/interpreter",
     "imageEmbeddable": "src/plugins/image_embeddable",
     "kbn": "src/legacy/core_plugins/kibana",
@@ -130,7 +130,7 @@
     "uiActionsEnhanced": "src/plugins/ui_actions_enhanced",
     "uiActionsExamples": "examples/ui_action_examples",
     "usageCollection": "src/plugins/usage_collection",
-    "userProfileComponents": "packages/kbn-user-profile-components",
+    "userProfileComponents": "src/platform/packages/shared/kbn-user-profile-components",
     "utils": "packages/kbn-securitysolution-utils/src",
     "visDefaultEditor": "src/plugins/vis_default_editor",
     "visTypeGauge": "src/plugins/vis_types/gauge",

docs/developer/advanced/sharing-saved-objects.asciidoc

@@ -407,7 +407,7 @@ this in two ways, and many consumers will want to implement both:
    the spaces plugin, and you can use them in your own application.
 +
 First, make sure your page contents are wrapped in a
-https://github.com/elastic/kibana/blob/{branch}/x-pack/plugins/spaces/public/spaces_context/types.ts[spaces context provider]:
+https://github.com/elastic/kibana/blob/{branch}/x-pack/platform/plugins/shared/spaces/public/spaces_context/types.ts[spaces context provider]:
 +
 ```tsx
 const ContextWrapper = useMemo(
@@ -425,9 +425,9 @@ return (
 );
 ```
 +
-Second, display a https://github.com/elastic/kibana/blob/{branch}/x-pack/plugins/spaces/public/space_list/types.ts[list of spaces] for an
+Second, display a https://github.com/elastic/kibana/blob/{branch}/x-pack/platform/plugins/shared/spaces/public/space_list/types.ts[list of spaces] for an
 object, and third, show a
-https://github.com/elastic/kibana/blob/{branch}/x-pack/plugins/spaces/public/share_saved_objects_to_space/types.ts[flyout] for the user to
+https://github.com/elastic/kibana/blob/{branch}/x-pack/platform/plugins/shared/spaces/public/share_saved_objects_to_space/types.ts[flyout] for the user to
 edit the object's assigned spaces. You may want to follow the example of the <<data-views,Data Views page>> and
 https://github.com/elastic/kibana/blob/{branch}/src/plugins/data_view_management/public/components/index_pattern_table/spaces_list.tsx[combine
 these into a single component] so that the space list can be clicked to show the flyout: