Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-security #202748

Merged
merged 28 commits into from
Jan 5, 2025
Merged

Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-security #202748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
0f3fba7
Relocating module `@kbn/crypto`
dokmic Jan 4, 2025
52eee48
Relocating module `@kbn/encrypted-saved-objects-plugin`
dokmic Jan 4, 2025
ae7caba
Relocating module `@kbn/handlebars`
dokmic Jan 4, 2025
19f72d2
Relocating module `@kbn/interactive-setup-plugin`
dokmic Jan 4, 2025
4b28a69
Relocating module `@kbn/safer-lodash-set`
dokmic Jan 4, 2025
b1efb50
Relocating module `@kbn/security-api-key-management`
dokmic Jan 4, 2025
628f7f4
Relocating module `@kbn/security-authorization-core`
dokmic Jan 4, 2025
2bb2b65
Relocating module `@kbn/security-authorization-core-common`
dokmic Jan 4, 2025
e92b371
Relocating module `@kbn/security-form-components`
dokmic Jan 4, 2025
d12a5c3
Relocating module `@kbn/security-hardening`
dokmic Jan 4, 2025
741d908
Relocating module `@kbn/security-plugin`
dokmic Jan 4, 2025
af68b3c
Relocating module `@kbn/security-plugin-types-common`
dokmic Jan 4, 2025
53154f6
Relocating module `@kbn/security-plugin-types-public`
dokmic Jan 4, 2025
4303d91
Relocating module `@kbn/security-plugin-types-server`
dokmic Jan 4, 2025
4a43cf8
Relocating module `@kbn/security-role-management-model`
dokmic Jan 4, 2025
6f934bb
Relocating module `@kbn/security-ui-components`
dokmic Jan 4, 2025
ec3d551
Relocating module `@kbn/spaces-plugin`
dokmic Jan 4, 2025
21b0db1
Relocating module `@kbn/user-profile-components`
dokmic Jan 4, 2025
3b4bf1e
Fixes i18n paths
jeramysoucy Dec 6, 2024
a81874d
Fixes path in kbn safer lodash set package file
jeramysoucy Dec 6, 2024
3248f23
Fix references to kbn-handlebars
gsoldevila Dec 7, 2024
d115704
Fixes commit-specific links, removes old comment
jeramysoucy Dec 16, 2024
dd288a3
Removes unknown team from codeowners file, removes duplicate
jeramysoucy Dec 31, 2024
cb6b861
Removes more duplicates from codeownwers
jeramysoucy Dec 31, 2024
6f32332
Remove duplicates in `CODEOWNERS`
dokmic Jan 3, 2025
8bb9163
[CI] Auto-commit changed files from 'node scripts/telemetry_check'
kibanamachine Jan 4, 2025
0bf1825
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Jan 4, 2025
d7fbf67
Revert unnecessary comment change blocking merge
dokmic Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
22 changes: 11 additions & 11 deletions .buildkite/scripts/pipelines/pull_request/pipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const getPipeline = (filename: string, removeSteps = true) => {

pipeline.push(getPipeline('.buildkite/pipelines/pull_request/base.yml', false));

if (await doAnyChangesMatch([/^packages\/kbn-handlebars/])) {
if (await doAnyChangesMatch([/^src\/platform\/packages\/private\/kbn-handlebars/])) {
pipeline.push(getPipeline('.buildkite/pipelines/pull_request/kbn_handlebars.yml'));
}

Expand Down Expand Up @@ -236,7 +236,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
if (
(await doAnyChangesMatch([
/^packages\/kbn-securitysolution-.*/,
/^x-pack\/solutions\/security\/plugins\/security_solution/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/security_solution/,
/^x-pack\/test\/defend_workflows_cypress/,
/^x-pack\/test\/security_solution_cypress/,
/^fleet_packages\.json/,
Expand All @@ -256,9 +256,9 @@ const getPipeline = (filename: string, removeSteps = true) => {
/^x-pack\/platform\/plugins\/shared\/data_views\/common/,
/^x-pack\/solutions\/security\/plugins\/lists/,
/^x-pack\/platform\/plugins\/shared\/rule_registry\/common/,
/^x-pack\/solutions\/security\/plugins\/security_solution/,
/^x-pack\/solutions\/security\/plugins\/security_solution_ess/,
/^x-pack\/solutions\/security\/plugins\/security_solution_serverless/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/security_solution/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/security_solution_ess/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/security_solution_serverless/,
/^x-pack\/platform\/plugins\/shared\/task_manager/,
/^x-pack\/solutions\/security\/plugins\/timelines/,
/^x-pack\/platform\/plugins\/shared\/triggers_actions_ui\/public\/application\/sections\/action_connector_form/,
Expand Down Expand Up @@ -306,7 +306,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
/^src\/platform\/packages\/shared\/kbn-resizable-layout/,
/^src\/platform\/packages\/shared\/kbn-rison/,
/^src\/platform\/packages\/shared\/kbn-rule-data-utils/,
/^packages\/kbn-safer-lodash-set/,
/^src\/platform\/packages\/shared\/kbn-safer-lodash-set/,
/^src\/platform\/packages\/shared\/kbn-search-types/,
/^packages\/kbn-securitysolution-.*/,
/^src\/platform\/packages\/shared\/kbn-securitysolution-ecs/,
Expand Down Expand Up @@ -341,9 +341,9 @@ const getPipeline = (filename: string, removeSteps = true) => {
/^x-pack\/solutions\/security\/plugins\/elastic_assistant/,
/^x-pack\/solutions\/security\/plugins\/lists/,
/^x-pack\/platform\/plugins\/shared\/rule_registry\/common/,
/^x-pack\/solutions\/security\/plugins\/security_solution/,
/^x-pack\/solutions\/security\/plugins\/security_solution_ess/,
/^x-pack\/solutions\/security\/plugins\/security_solution_serverless/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/security_solution/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/security_solution_ess/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/security_solution_serverless/,
/^x-pack\/platform\/plugins\/shared\/task_manager/,
/^x-pack\/solutions\/security\/plugins\/threat_intelligence/,
/^x-pack\/solutions\/security\/plugins\/timelines/,
Expand All @@ -363,7 +363,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
((await doAnyChangesMatch([
/^x-pack\/platform\/plugins\/shared\/osquery/,
/^x-pack\/test\/osquery_cypress/,
/^x-pack\/solutions\/security\/plugins\/security_solution/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/security_solution/,
])) ||
GITHUB_PR_LABELS.includes('ci:all-cypress-suites')) &&
!GITHUB_PR_LABELS.includes('ci:skip-cypress-osquery')
Expand All @@ -377,7 +377,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
(await doAnyChangesMatch([
/^x-pack\/packages\/kbn-cloud-security-posture/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/cloud_security_posture/,
/^x-pack\/solutions\/security\/plugins\/security_solution/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/security_solution/,
/^x-pack\/test\/security_solution_cypress/,
])) ||
GITHUB_PR_LABELS.includes('ci:all-cypress-suites')
Expand Down
2 changes: 1 addition & 1 deletion .buildkite/scripts/steps/test/kbn_handlebars.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ set -euo pipefail
source .buildkite/scripts/common/util.sh

echo '--- Checking for @kbn/handlebars upstream updates'
packages/kbn-handlebars/scripts/check_for_upstream_updates.sh
src/platform/packages/private/kbn-handlebars/scripts/check_for_upstream_updates.sh
34 changes: 17 additions & 17 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ const ELV2_LICENSE_HEADER = `
const SAFER_LODASH_SET_HEADER = `
/*
* Elasticsearch B.V licenses this file to you under the MIT License.
* See \`packages/kbn-safer-lodash-set/LICENSE\` for more information.
* See \`src/platform/packages/shared/kbn-safer-lodash-set/LICENSE\` for more information.
*/
`;

Expand All @@ -93,7 +93,7 @@ const SAFER_LODASH_SET_LODASH_HEADER = `
* This file is forked from the lodash project (https://lodash.com/),
* and may include modifications made by Elasticsearch B.V.
* Elasticsearch B.V. licenses this file to you under the MIT License.
* See \`packages/kbn-safer-lodash-set/LICENSE\` for more information.
* See \`src/platform/packages/shared/kbn-safer-lodash-set/LICENSE\` for more information.
*/
`;

Expand All @@ -102,14 +102,14 @@ const SAFER_LODASH_SET_DEFINITELYTYPED_HEADER = `
* This file is forked from the DefinitelyTyped project (https://github.com/DefinitelyTyped/DefinitelyTyped),
* and may include modifications made by Elasticsearch B.V.
* Elasticsearch B.V. licenses this file to you under the MIT License.
* See \`packages/kbn-safer-lodash-set/LICENSE\` for more information.
* See \`src/platform/packages/shared/kbn-safer-lodash-set/LICENSE\` for more information.
*/
`;

const KBN_HANDLEBARS_HEADER = `
/*
* Elasticsearch B.V licenses this file to you under the MIT License.
* See \`packages/kbn-handlebars/LICENSE\` for more information.
* See \`src/platform/packages/private/kbn-handlebars/LICENSE\` for more information.
*/
`;

Expand All @@ -118,7 +118,7 @@ const KBN_HANDLEBARS_HANDLEBARS_HEADER = `
* This file is forked from the handlebars project (https://github.com/handlebars-lang/handlebars.js),
* and may include modifications made by Elasticsearch B.V.
* Elasticsearch B.V. licenses this file to you under the MIT License.
* See \`packages/kbn-handlebars/LICENSE\` for more information.
* See \`src/platform/packages/private/kbn-handlebars/LICENSE\` for more information.
*/
`;

Expand Down Expand Up @@ -441,7 +441,7 @@ module.exports = {
* safer-lodash-set package requires special license headers
*/
{
files: ['packages/kbn-safer-lodash-set/**/*.{js,mjs,ts,tsx}'],
files: ['src/platform/packages/shared/kbn-safer-lodash-set/**/*.{js,mjs,ts,tsx}'],
rules: {
'@kbn/eslint/require-license-header': [
'error',
Expand Down Expand Up @@ -471,7 +471,7 @@ module.exports = {
},

{
files: ['packages/kbn-safer-lodash-set/test/*.{js,mjs,ts,tsx}'],
files: ['src/platform/packages/shared/kbn-safer-lodash-set/test/*.{js,mjs,ts,tsx}'],
rules: {
'@kbn/eslint/require-license-header': [
'error',
Expand Down Expand Up @@ -500,7 +500,7 @@ module.exports = {
},
},
{
files: ['packages/kbn-safer-lodash-set/**/*.d.ts'],
files: ['src/platform/packages/shared/kbn-safer-lodash-set/**/*.d.ts'],
rules: {
'@kbn/eslint/require-license-header': [
'error',
Expand Down Expand Up @@ -533,7 +533,7 @@ module.exports = {
* @kbn/handlebars package requires special license headers
*/
{
files: ['packages/kbn-handlebars/**/*.{js,mjs,ts,tsx}'],
files: ['src/platform/packages/private/kbn-handlebars/**/*.{js,mjs,ts,tsx}'],
rules: {
'@kbn/eslint/require-license-header': [
'error',
Expand Down Expand Up @@ -562,7 +562,7 @@ module.exports = {
},
},
{
files: ['packages/kbn-handlebars/src/spec/**/*.{js,mjs,ts,tsx}'],
files: ['src/platform/packages/private/kbn-handlebars/src/spec/**/*.{js,mjs,ts,tsx}'],
rules: {
'@kbn/eslint/require-license-header': [
'error',
Expand Down Expand Up @@ -778,7 +778,7 @@ module.exports = {
* Harden specific rules
*/
{
files: ['test/harden/*.js', 'packages/kbn-safer-lodash-set/test/*.js'],
files: ['test/harden/*.js', 'src/platform/packages/shared/kbn-safer-lodash-set/test/*.js'],
rules: {
'mocha/handle-done-callback': 'off',
},
Expand Down Expand Up @@ -1854,24 +1854,24 @@ module.exports = {
*/
{
files: [
'src/plugins/interactive_setup/**/*.{js,mjs,ts,tsx}',
'src/platform/plugins/private/interactive_setup/**/*.{js,mjs,ts,tsx}',
'test/interactive_setup_api_integration/**/*.{js,mjs,ts,tsx}',
'test/interactive_setup_functional/**/*.{js,mjs,ts,tsx}',

'packages/kbn-mock-idp-plugin/**/*.{js,mjs,ts,tsx}',
'packages/kbn-mock-idp-utils/**/*.{js,mjs,ts,tsx}',
'packages/kbn-security-hardening/**/*.{js,mjs,ts,tsx}',
'packages/kbn-user-profile-components/**/*.{js,mjs,ts,tsx}',
'src/platform/packages/shared/kbn-security-hardening/**/*.{js,mjs,ts,tsx}',
'src/platform/packages/shared/kbn-user-profile-components/**/*.{js,mjs,ts,tsx}',

'x-pack/plugins/encrypted_saved_objects/**/*.{js,mjs,ts,tsx}',
'x-pack/platform/plugins/shared/encrypted_saved_objects/**/*.{js,mjs,ts,tsx}',
'x-pack/test/encrypted_saved_objects_api_integration/**/*.{js,mjs,ts,tsx}',

'x-pack/plugins/security/**/*.{js,mjs,ts,tsx}',
'x-pack/platform/plugins/shared/security/**/*.{js,mjs,ts,tsx}',
'x-pack/packages/security/**/*.{js,mjs,ts,tsx}',
'x-pack/test/security_api_integration/**/*.{js,mjs,ts,tsx}',
'x-pack/test/security_functional/**/*.{js,mjs,ts,tsx}',

'x-pack/plugins/spaces/**/*.{js,mjs,ts,tsx}',
'x-pack/platform/plugins/shared/spaces/**/*.{js,mjs,ts,tsx}',
'x-pack/test/spaces_api_integration/**/*.{js,mjs,ts,tsx}',
],
rules: {
Expand Down
Loading
Loading