Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-security` #202748

gsoldevila · 2024-12-03T14:45:47Z

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

We kindly ask you to:
- Manually fix the errors in the error section below (if there are any).
- Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
- Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
- Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
- Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
  - customised eslint rules
  - docs pointing to source code

Note

This PR has been auto-generated.
Do not attempt to push any changes unless you know what you are doing.
Please use #sustainable_kibana_architecture Slack channel for feedback.

4 plugin(s) are going to be relocated:

Id	Target folder
`@kbn/encrypted-saved-objects-plugin`	`x-pack/platform/plugins/shared/encrypted_saved_objects`
`@kbn/interactive-setup-plugin`	`src/platform/plugins/private/interactive_setup`
`@kbn/security-plugin`	`x-pack/platform/plugins/shared/security`
`@kbn/spaces-plugin`	`x-pack/platform/plugins/shared/spaces`

14 package(s) are going to be relocated:

Id	Target folder
`@kbn/crypto`	`src/platform/packages/shared/kbn-crypto`
`@kbn/handlebars`	`src/platform/packages/private/kbn-handlebars`
`@kbn/safer-lodash-set`	`src/platform/packages/shared/kbn-safer-lodash-set`
`@kbn/security-api-key-management`	`x-pack/platform/packages/shared/security/api_key_management`
`@kbn/security-authorization-core`	`x-pack/platform/packages/private/security/authorization_core`
`@kbn/security-authorization-core-common`	`x-pack/platform/packages/private/security/authorization_core_common`
`@kbn/security-form-components`	`x-pack/platform/packages/shared/security/form_components`
`@kbn/security-hardening`	`src/platform/packages/shared/kbn-security-hardening`
`@kbn/security-plugin-types-common`	`x-pack/platform/packages/shared/security/plugin_types_common`
`@kbn/security-plugin-types-public`	`x-pack/platform/packages/shared/security/plugin_types_public`
`@kbn/security-plugin-types-server`	`x-pack/platform/packages/shared/security/plugin_types_server`
`@kbn/security-role-management-model`	`x-pack/platform/packages/private/security/role_management_model`
`@kbn/security-ui-components`	`x-pack/platform/packages/private/security/ui_components`
`@kbn/user-profile-components`	`src/platform/packages/shared/kbn-user-profile-components`

Updated references

./.eslintrc.js
./.i18nrc.json
./docs/developer/advanced/sharing-saved-objects.asciidoc
./docs/developer/plugin-list.asciidoc
./legacy_rfcs/text/0007_lifecycle_unblocked.md
./legacy_rfcs/text/0016_ols_phase_1.md
./package.json
./packages/core/saved-objects/core-saved-objects-common/src/types.ts
./packages/core/security/core-security-server/src/audit_logging/audit_logger.ts
./packages/core/user-profile/core-user-profile-common/src/user_profile.ts
./packages/kbn-dependency-usage/src/dependency_graph/providers/cruiser.test.ts
./packages/kbn-repo-packages/package-map.json
./packages/kbn-synthetic-package-map/synthetic-packages.json
./packages/kbn-ts-projects/config-paths.json
./packages/kbn-ui-shared-deps-src/BUILD.bazel
./packages/kbn-user-profile-components/src/user_profile.ts
./src/dev/precommit_hook/casing_check_config.js
./src/platform/packages/private/kbn-handlebars/README.md
./src/platform/packages/private/kbn-handlebars/index.test.ts
./src/platform/packages/private/kbn-handlebars/index.ts
./src/platform/packages/private/kbn-handlebars/jest.config.js
./src/platform/packages/private/kbn-handlebars/scripts/print_ast.js
./src/platform/packages/private/kbn-handlebars/src/__jest__/test_bench.ts
./src/platform/packages/private/kbn-handlebars/src/handlebars.ts
./src/platform/packages/private/kbn-handlebars/src/spec/index.basic.test.ts
./src/platform/packages/private/kbn-handlebars/src/spec/index.blocks.test.ts
./src/platform/packages/private/kbn-handlebars/src/spec/index.builtins.test.ts
./src/platform/packages/private/kbn-handlebars/src/spec/index.compiler.test.ts
./src/platform/packages/private/kbn-handlebars/src/spec/index.data.test.ts
./src/platform/packages/private/kbn-handlebars/src/spec/index.helpers.test.ts
./src/platform/packages/private/kbn-handlebars/src/spec/index.partials.test.ts
./src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts
./src/platform/packages/private/kbn-handlebars/src/spec/index.security.test.ts
./src/platform/packages/private/kbn-handlebars/src/spec/index.strict.test.ts
./src/platform/packages/private/kbn-handlebars/src/spec/index.subexpressions.test.ts
./src/platform/packages/private/kbn-handlebars/src/spec/index.utils.test.ts
./src/platform/packages/private/kbn-handlebars/src/spec/index.whitespace_control.test.ts
./src/platform/packages/private/kbn-handlebars/src/symbols.ts
./src/platform/packages/private/kbn-handlebars/src/types.ts
./src/platform/packages/private/kbn-handlebars/src/utils.ts
./src/platform/packages/private/kbn-handlebars/src/visitor.ts
./src/platform/packages/shared/kbn-crypto/jest.config.js
./src/platform/packages/shared/kbn-safer-lodash-set/fp/assoc.d.ts
./src/platform/packages/shared/kbn-safer-lodash-set/fp/assoc.js
./src/platform/packages/shared/kbn-safer-lodash-set/fp/assocPath.d.ts
./src/platform/packages/shared/kbn-safer-lodash-set/fp/assocPath.js
./src/platform/packages/shared/kbn-safer-lodash-set/fp/index.d.ts
./src/platform/packages/shared/kbn-safer-lodash-set/fp/index.js
./src/platform/packages/shared/kbn-safer-lodash-set/fp/set.d.ts
./src/platform/packages/shared/kbn-safer-lodash-set/fp/set.js
./src/platform/packages/shared/kbn-safer-lodash-set/fp/setWith.d.ts
./src/platform/packages/shared/kbn-safer-lodash-set/fp/setWith.js
./src/platform/packages/shared/kbn-safer-lodash-set/index.d.ts
./src/platform/packages/shared/kbn-safer-lodash-set/index.js
./src/platform/packages/shared/kbn-safer-lodash-set/lodash/_baseSet.js
./src/platform/packages/shared/kbn-safer-lodash-set/lodash/set.js
./src/platform/packages/shared/kbn-safer-lodash-set/lodash/setWith.js
./src/platform/packages/shared/kbn-safer-lodash-set/package.json
./src/platform/packages/shared/kbn-safer-lodash-set/scripts/license-header.txt
./src/platform/packages/shared/kbn-safer-lodash-set/set.d.ts
./src/platform/packages/shared/kbn-safer-lodash-set/set.js
./src/platform/packages/shared/kbn-safer-lodash-set/setWith.d.ts
./src/platform/packages/shared/kbn-safer-lodash-set/setWith.js
./src/platform/packages/shared/kbn-safer-lodash-set/test/fp.ts
./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_assoc.ts
./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_assocPath.ts
./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_patch_test.js
./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_set.ts
./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_setWith.ts
./src/platform/packages/shared/kbn-safer-lodash-set/test/index.ts
./src/platform/packages/shared/kbn-safer-lodash-set/test/patch_test.js
./src/platform/packages/shared/kbn-safer-lodash-set/test/set.ts
./src/platform/packages/shared/kbn-safer-lodash-set/test/setWith.ts
./src/platform/packages/shared/kbn-user-profile-components/jest.config.js
./src/platform/plugins/private/interactive_setup/jest.config.js
./tsconfig.base.json
./tsconfig.refs.json
./x-pack/.i18nrc.json
./x-pack/platform/packages/private/security/authorization_core/jest.config.js
./x-pack/platform/packages/private/security/authorization_core_common/jest.config.js
./x-pack/platform/packages/private/security/role_management_model/jest.config.js
./x-pack/platform/packages/private/security/ui_components/jest.config.js
./x-pack/platform/packages/shared/security/api_key_management/jest.config.js
./x-pack/platform/packages/shared/security/form_components/jest.config.js
./x-pack/platform/plugins/shared/encrypted_saved_objects/README.md
./x-pack/platform/plugins/shared/encrypted_saved_objects/jest.config.js
./x-pack/platform/plugins/shared/security/jest.config.js
./x-pack/platform/plugins/shared/spaces/jest.config.js
./x-pack/plugins/cases/server/authorization/index.ts
./x-pack/plugins/cases/server/authorization/types.ts
./x-pack/plugins/cases/server/connectors/cases/utils.ts
./x-pack/plugins/cases/server/routes/api/utils.ts
./x-pack/plugins/fleet/common/http_authorization_header.ts
./x-pack/plugins/rule_registry/server/lib/get_is_kibana_request.ts
./x-pack/plugins/security_solution/server/lib/timeline/routes/notes/get_notes.ts
./yarn.lock

Updated relative paths

src/platform/packages/private/kbn-handlebars/jest.config.js:8
src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts:276
src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts:277
src/platform/packages/private/kbn-handlebars/tsconfig.json:2
src/platform/packages/shared/kbn-crypto/jest.config.js:12
src/platform/packages/shared/kbn-crypto/tsconfig.json:2
src/platform/packages/shared/kbn-safer-lodash-set/package.json:6
src/platform/packages/shared/kbn-safer-lodash-set/package.json:7
src/platform/packages/shared/kbn-safer-lodash-set/package.json:8
src/platform/packages/shared/kbn-safer-lodash-set/tsconfig.json:2
src/platform/packages/shared/kbn-security-hardening/tsconfig.json:2
src/platform/packages/shared/kbn-user-profile-components/jest.config.js:12
src/platform/packages/shared/kbn-user-profile-components/tsconfig.json:2
src/platform/plugins/private/interactive_setup/jest.config.js:12
src/platform/plugins/private/interactive_setup/tsconfig.json:2
x-pack/platform/packages/private/security/authorization_core/jest.config.js:13
x-pack/platform/packages/private/security/authorization_core/tsconfig.json:2
x-pack/platform/packages/private/security/authorization_core_common/jest.config.js:15
x-pack/platform/packages/private/security/authorization_core_common/tsconfig.json:2
x-pack/platform/packages/private/security/role_management_model/jest.config.js:14
x-pack/platform/packages/private/security/role_management_model/tsconfig.json:2
x-pack/platform/packages/private/security/ui_components/jest.config.js:13
x-pack/platform/packages/private/security/ui_components/tsconfig.json:2
x-pack/platform/packages/shared/security/api_key_management/jest.config.js:14
x-pack/platform/packages/shared/security/api_key_management/tsconfig.json:2
x-pack/platform/packages/shared/security/form_components/jest.config.js:14
x-pack/platform/packages/shared/security/form_components/tsconfig.json:2
x-pack/platform/packages/shared/security/plugin_types_common/tsconfig.json:2
x-pack/platform/packages/shared/security/plugin_types_public/tsconfig.json:2
x-pack/platform/packages/shared/security/plugin_types_server/tsconfig.json:2
x-pack/platform/plugins/shared/encrypted_saved_objects/README.md:8
x-pack/platform/plugins/shared/encrypted_saved_objects/jest.config.js:10
x-pack/platform/plugins/shared/encrypted_saved_objects/tsconfig.json:2
x-pack/platform/plugins/shared/security/jest.config.js:10
x-pack/platform/plugins/shared/security/tsconfig.json:2
x-pack/platform/plugins/shared/spaces/jest.config.js:10
x-pack/platform/plugins/shared/spaces/tsconfig.json:2

Script errors

Cannot replace multiple occurrences of "../.." in the same line, please fix manually:	/Users/gsoldevila/Work/kibana-quaternary/src/platform/packages/shared/kbn-safer-lodash-set/package.json:6

github-actions · 2024-12-03T14:46:02Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

elasticmachine · 2024-12-03T14:56:00Z

Pinging @elastic/kibana-core (Team:Core)

elasticmachine · 2024-12-03T14:56:03Z

Pinging @elastic/kibana-security (Team:Security)

ryankeairns

SCSS files only

pmuellr

ResponseOps changes LGTM. Was just 5 files, and the only changes were in comments. Which looked ok to me.

I'm slightly awed we were able to move a bunch of these plugins we use within ResponseOps without any other changes! That change to reference other plugins via @kbn/XXX-plugin was a huge win, for changes like this!

…-fix'

TinaHeiligers

Core code changes LGTM.

FYI the failed jest test is a known issue, skipped in main, then re-enabled again (#202289), only to be flaky once more.

PhilippeOberti

code LGTM for the Threat Hunting Investigations!

jeramysoucy

@gsoldevila I noticed some links to specific commits that shouldn't be changed. I will push a commit to revert those.

The only other thing I noticed were discrepancies with some of the jest.config.js files. It looks like git may have gotten confused about which of these files were moved and where. However, the end result appears to be accurate, and I don't necessarily think it is an issue to have a strange file history on these particular files, but I wanted to bring it up.

jeramysoucy · 2024-12-09T20:48:56Z

legacy_rfcs/text/0016_ols_phase_1.md

@@ -103,7 +103,7 @@ export interface SavedObject<T = unknown> {

 ### 3.1.3 Saved Objects Client: Security wrapper

-The [security wrapper](https://github.com/elastic/kibana/blob/701697cc4a34d07c0508c3bdf01dca6f9d40a636/x-pack/plugins/security/server/saved_objects/secure_saved_objects_client_wrapper.ts) authorizes and audits operations against saved objects.
+The [security wrapper](https://github.com/elastic/kibana/blob/701697cc4a34d07c0508c3bdf01dca6f9d40a636/x-pack/platform/plugins/shared/security/server/saved_objects/secure_saved_objects_client_wrapper.ts) authorizes and audits operations against saved objects.


The SO wrapper no longer exists (was replaced with the extension a long while back), and IMO we don't need to update any of these legacy RFC docs.

jeramysoucy · 2024-12-09T21:31:58Z

packages/core/saved-objects/core-saved-objects-common/src/types.ts

@@ -19,7 +19,7 @@ export interface SavedObjectTypeIdTuple {
  type: string;
 }

-// NOTE: moved from x-pack/plugins/spaces/common/types.ts for use by SO security ext
+// NOTE: moved from x-pack/platform/plugins/shared/spaces/common/types.ts for use by SO security ext


I think we can just delete this comment now. It was useful 2 years ago, but is no longer relevant.

Suggested change

// NOTE: moved from x-pack/platform/plugins/shared/spaces/common/types.ts for use by SO security ext

jeramysoucy · 2024-12-13T18:55:38Z

x-pack/platform/plugins/shared/security/jest.config.js

Something is off here - the source and destination do not match. There is a jest.config.js file in the new x-pack/platform/packages/private/security/role_management_model folder, which looks like a new added file. It should have been moved and adjusted from the old location.

jeramysoucy · 2024-12-13T19:00:19Z

x-pack/plugins/security/jest.config.js

For some reason this file got mixed up with role_management_model/jest.config.js. They both should have been moved accordingly, but instead this one was deleted, the origin of role_management_model/jest.config.js was moved erroneously, and x-pack/platform/packages/private/security/role_management_model/jest.config.js was created new.

jeramysoucy · 2024-12-13T19:04:58Z

legacy_rfcs/text/0007_lifecycle_unblocked.md

@@ -345,7 +345,7 @@ functions and will be impacted:
 6. [code](https://github.com/elastic/kibana/blob/5049b460b47d4ae3432e1d9219263bb4be441392/x-pack/legacy/plugins/code/server/plugin.ts#L129-L149)
 7. [spaces](https://github.com/elastic/kibana/blob/096c7ee51136327f778845c636d7c4f1188e5db2/x-pack/legacy/plugins/spaces/server/new_platform/plugin.ts#L95)
 8. [licensing](https://github.com/elastic/kibana/blob/4667c46caef26f8f47714504879197708debae32/x-pack/plugins/licensing/server/plugin.ts)
-9. [security](https://github.com/elastic/kibana/blob/0f2324e44566ce2cf083d89082841e57d2db6ef6/x-pack/plugins/security/server/plugin.ts#L96)


I don't think we need to update these old legacy RFCs

jeramysoucy · 2024-12-16T14:26:07Z

legacy_rfcs/text/0007_lifecycle_unblocked.md

@@ -343,7 +343,7 @@ functions and will be impacted:
 3. [vis_type_table](https://github.com/elastic/kibana/blob/6039709929caf0090a4130b8235f3a53bd04ed84/src/legacy/core_plugins/vis_type_table/public/plugin.ts#L61)
 4. [vis_type_vega](https://github.com/elastic/kibana/blob/6039709929caf0090a4130b8235f3a53bd04ed84/src/legacy/core_plugins/vis_type_vega/public/plugin.ts#L59)
 6. [code](https://github.com/elastic/kibana/blob/5049b460b47d4ae3432e1d9219263bb4be441392/x-pack/legacy/plugins/code/server/plugin.ts#L129-L149)
-7. [spaces](https://github.com/elastic/kibana/blob/096c7ee51136327f778845c636d7c4f1188e5db2/x-pack/legacy/plugins/spaces/server/new_platform/plugin.ts#L95)
+7. [spaces](https://github.com/elastic/kibana/blob/096c7ee51136327f778845c636d7c4f1188e5db2/x-pack/legacy/platform/plugins/shared/spaces/server/new_platform/plugin.ts#L95)


Nit: No need to update the legacy RFCs

jeramysoucy · 2024-12-16T16:27:32Z

x-pack/platform/plugins/shared/spaces/jest.config.js

A few of the jest.config.js files are in this state, where they show up as having been moved from one domain to another (security/ui_components to spaces), and corrected. I don't think this is really consequential if the end result is correct.

jeramysoucy · 2024-12-16T16:46:49Z

x-pack/plugins/cases/server/routes/api/utils.ts

@@ -51,7 +51,7 @@ export const getWarningHeader = (

 /**
 * Taken from
- * https://github.com/elastic/kibana/blob/ec30f2aeeb10fb64b507935e558832d3ef5abfaa/x-pack/plugins/spaces/server/usage_stats/usage_stats_client.ts#L113-L118
+ * https://github.com/elastic/kibana/blob/ec30f2aeeb10fb64b507935e558832d3ef5abfaa/x-pack/platform/plugins/shared/spaces/server/usage_stats/usage_stats_client.ts#L113-L118


This link should remain as it was, since it points to a specific commit.

Suggested change

* https://github.com/elastic/kibana/blob/ec30f2aeeb10fb64b507935e558832d3ef5abfaa/x-pack/platform/plugins/shared/spaces/server/usage_stats/usage_stats_client.ts#L113-L118

* https://github.com/elastic/kibana/blob/ec30f2aeeb10fb64b507935e558832d3ef5abfaa/x-pack/plugins/spaces/server/usage_stats/usage_stats_client.ts#L113-L118

jeramysoucy · 2024-12-16T18:05:02Z

x-pack/plugins/rule_registry/server/lib/get_is_kibana_request.ts

@@ -8,7 +8,7 @@ import type { Headers } from '@kbn/core/server';

 /**
 * Taken from
- * https://github.com/elastic/kibana/blob/ec30f2aeeb10fb64b507935e558832d3ef5abfaa/x-pack/plugins/spaces/server/usage_stats/usage_stats_client.ts#L113-L118
+ * https://github.com/elastic/kibana/blob/ec30f2aeeb10fb64b507935e558832d3ef5abfaa/x-pack/platform/plugins/shared/spaces/server/usage_stats/usage_stats_client.ts#L113-L118


Original link should remain, as it references a specific commit.

Suggested change

* https://github.com/elastic/kibana/blob/ec30f2aeeb10fb64b507935e558832d3ef5abfaa/x-pack/platform/plugins/shared/spaces/server/usage_stats/usage_stats_client.ts#L113-L118

* https://github.com/elastic/kibana/blob/ec30f2aeeb10fb64b507935e558832d3ef5abfaa/x-pack/plugins/spaces/server/usage_stats/usage_stats_client.ts#L113-L118

elasticmachine · 2024-12-16T19:26:29Z

⏳ Build in-progress, with failures

Buildkite Build
Commit: ffccb7f

Failed CI Steps

Test Failures

[job] [logs] Serverless AI Assistant - Security Solution Cypress Tests / AI Assistant Conversations Changing conversations Correctly creates and titles new conversations, and allows title updates Correctly creates and titles new conversations, and allows title updates
[job] [logs] AI Assistant - Security Solution Cypress Tests / AI Assistant Conversations Changing conversations Correctly creates and titles new conversations, and allows title updates Correctly creates and titles new conversations, and allows title updates
[job] [logs] FTR Configs #60 / serverless search UI Serverless Inference Management UI endpoint tabular view is loaded successfully
[job] [logs] FTR Configs #60 / serverless search UI Serverless Inference Management UI endpoint tabular view is loaded successfully
[job] [logs] FTR Configs #78 / Upgrade Assistant Elasticsearch deprecation logs GET /api/upgrade_assistant/deprecation_logging /count should filter out the deprecation from Elastic products
[job] [logs] FTR Configs #78 / Upgrade Assistant Elasticsearch deprecation logs GET /api/upgrade_assistant/deprecation_logging /count should filter out the deprecation from Elastic products

History

jasonrhodes

@gsoldevila I'm not exactly sure why @elastic/obs-ux-management-team is being requested on this review as I don't see it touching any files that belong to us, but because we're listed here, I'll add a cursory approval (I've not looked at this PR at all beyond checking the "File filter" in the files tab to see if any files belong to our team, and none do)

gsoldevila · 2024-12-17T15:53:01Z

@jeramysoucy I'm re-running the relocation logic against this PR, it'll pick up manual changes.

gsoldevila marked this pull request as ready for review December 3, 2024 14:55

gsoldevila requested review from a team as code owners December 3, 2024 14:55

ryankeairns approved these changes Dec 3, 2024

View reviewed changes

Ikuni17 approved these changes Dec 3, 2024

View reviewed changes

gsoldevila added backport:skip This commit does not require backporting and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 4, 2024

pmuellr approved these changes Dec 4, 2024

View reviewed changes

gsoldevila added 7 commits December 5, 2024 20:20

Relocating module @kbn/crypto

7e1e0a6

Relocating module @kbn/encrypted-saved-objects-plugin

dd21e05

Relocating module @kbn/handlebars

1eb9428

Relocating module @kbn/interactive-setup-plugin

20c392d

Relocating module @kbn/safer-lodash-set

683f04c

Relocating module @kbn/security-api-key-management

16a7d6b

Relocating module @kbn/security-authorization-core

9aba395

gsoldevila added 11 commits December 5, 2024 20:28

Relocating module @kbn/security-authorization-core-common

1a8b483

Relocating module @kbn/security-form-components

fc69a22

Relocating module @kbn/security-hardening

5e84f7a

Relocating module @kbn/security-plugin

39c2a72

Relocating module @kbn/security-plugin-types-common

068f2e1

Relocating module @kbn/security-plugin-types-public

51333f9

Relocating module @kbn/security-plugin-types-server

b397ad2

Relocating module @kbn/security-role-management-model

01c62b0

Relocating module @kbn/security-ui-components

49d9bb8

Relocating module @kbn/spaces-plugin

f1c2a73

Relocating module @kbn/user-profile-components

33582ae

gsoldevila force-pushed the kbn-team-1309-move-kibana-security branch from 1eb4b47 to 33582ae Compare December 5, 2024 19:41

kibanamachine and others added 4 commits December 5, 2024 19:57

[CI] Auto-commit changed files from 'node scripts/telemetry_check'

9312f57

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

7d6fd74

…-fix'

Fixes i18n paths

e0fa7e9

Fixes path in kbn safer lodash set package file

db38b3d

TinaHeiligers approved these changes Dec 6, 2024

View reviewed changes

TinaHeiligers mentioned this pull request Dec 6, 2024

fix flaky tests #202289

Merged

gsoldevila added 2 commits December 7, 2024 09:32

Fix references to kbn-handlebars

d66abdc

Merge branch 'main' into kbn-team-1309-move-kibana-security

98bb09a

jeramysoucy self-requested a review December 9, 2024 13:15

PhilippeOberti approved these changes Dec 13, 2024

View reviewed changes

jeramysoucy requested changes Dec 16, 2024

View reviewed changes

Fixes commit-specific links, removes old comment

ffccb7f

jasonrhodes approved these changes Dec 16, 2024

View reviewed changes

rudolf added the plugin groups Relocate all plugins and packages under their respective platform/solution groups label Dec 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-security` #202748

Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-security` #202748

gsoldevila commented Dec 3, 2024 •

edited

Loading

github-actions bot commented Dec 3, 2024

elasticmachine commented Dec 3, 2024

elasticmachine commented Dec 3, 2024

ryankeairns left a comment

pmuellr left a comment

TinaHeiligers left a comment •

edited

Loading

PhilippeOberti left a comment

jeramysoucy left a comment

jeramysoucy Dec 9, 2024

jeramysoucy Dec 9, 2024

jeramysoucy Dec 13, 2024

jeramysoucy Dec 13, 2024

jeramysoucy Dec 13, 2024

jeramysoucy Dec 16, 2024

jeramysoucy Dec 16, 2024

jeramysoucy Dec 16, 2024

jeramysoucy Dec 16, 2024

elasticmachine commented Dec 16, 2024 •

edited

Loading

jasonrhodes left a comment

gsoldevila commented Dec 17, 2024

	* https://github.com/elastic/kibana/blob/ec30f2aeeb10fb64b507935e558832d3ef5abfaa/x-pack/platform/plugins/shared/spaces/server/usage_stats/usage_stats_client.ts#L113-L118
	* https://github.com/elastic/kibana/blob/ec30f2aeeb10fb64b507935e558832d3ef5abfaa/x-pack/plugins/spaces/server/usage_stats/usage_stats_client.ts#L113-L118

Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-security #202748

Are you sure you want to change the base?

Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-security #202748

Conversation

gsoldevila commented Dec 3, 2024 • edited Loading

Summary

4 plugin(s) are going to be relocated:

14 package(s) are going to be relocated:

github-actions bot commented Dec 3, 2024

elasticmachine commented Dec 3, 2024

elasticmachine commented Dec 3, 2024

ryankeairns left a comment

Choose a reason for hiding this comment

pmuellr left a comment

Choose a reason for hiding this comment

TinaHeiligers left a comment • edited Loading

Choose a reason for hiding this comment

PhilippeOberti left a comment

Choose a reason for hiding this comment

jeramysoucy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Dec 16, 2024 • edited Loading

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

History

jasonrhodes left a comment

Choose a reason for hiding this comment

gsoldevila commented Dec 17, 2024

Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-security` #202748

Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-security` #202748

gsoldevila commented Dec 3, 2024 •

edited

Loading

TinaHeiligers left a comment •

edited

Loading

elasticmachine commented Dec 16, 2024 •

edited

Loading