Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-security

.eslintrc.js

@@ -1841,7 +1841,7 @@ module.exports = {
         'x-pack/test/security_api_integration/**/*.{js,mjs,ts,tsx}',
         'x-pack/test/security_functional/**/*.{js,mjs,ts,tsx}',
 
-        'x-pack/plugins/spaces/**/*.{js,mjs,ts,tsx}',
+        'x-pack/platform/plugins/shared/spaces/**/*.{js,mjs,ts,tsx}',
         'x-pack/test/spaces_api_integration/**/*.{js,mjs,ts,tsx}',
       ],
       rules: {

.github/CODEOWNERS

@@ -866,6 +866,7 @@ x-pack/platform/packages/shared/security/plugin_types_public @elastic/kibana-sec
 x-pack/platform/packages/shared/security/plugin_types_server @elastic/kibana-security
 x-pack/platform/plugins/shared/encrypted_saved_objects @elastic/kibana-security
 x-pack/platform/plugins/shared/security @elastic/kibana-security
+x-pack/platform/plugins/shared/spaces @elastic/kibana-security
 x-pack/plugins/actions @elastic/response-ops
 x-pack/plugins/ai_infra/llm_tasks @elastic/appex-ai-infra
 x-pack/plugins/ai_infra/product_doc_base @elastic/appex-ai-infra
@@ -980,7 +981,6 @@ x-pack/plugins/serverless_observability @elastic/obs-ux-management-team
 x-pack/plugins/serverless_search @elastic/search-kibana
 x-pack/plugins/session_view @elastic/kibana-cloud-security-posture
 x-pack/plugins/snapshot_restore @elastic/kibana-management
-x-pack/plugins/spaces @elastic/kibana-security
 x-pack/plugins/stack_alerts @elastic/response-ops
 x-pack/plugins/stack_connectors @elastic/response-ops
 x-pack/plugins/streams @elastic/streams-program-team

docs/developer/advanced/sharing-saved-objects.asciidoc

@@ -407,7 +407,7 @@ this in two ways, and many consumers will want to implement both:
    the spaces plugin, and you can use them in your own application.
 +
 First, make sure your page contents are wrapped in a
-https://github.com/elastic/kibana/blob/{branch}/x-pack/plugins/spaces/public/spaces_context/types.ts[spaces context provider]:
+https://github.com/elastic/kibana/blob/{branch}/x-pack/platform/plugins/shared/spaces/public/spaces_context/types.ts[spaces context provider]:
 +
 ```tsx
 const ContextWrapper = useMemo(
@@ -425,9 +425,9 @@ return (
 );
 ```
 +
-Second, display a https://github.com/elastic/kibana/blob/{branch}/x-pack/plugins/spaces/public/space_list/types.ts[list of spaces] for an
+Second, display a https://github.com/elastic/kibana/blob/{branch}/x-pack/platform/plugins/shared/spaces/public/space_list/types.ts[list of spaces] for an
 object, and third, show a
-https://github.com/elastic/kibana/blob/{branch}/x-pack/plugins/spaces/public/share_saved_objects_to_space/types.ts[flyout] for the user to
+https://github.com/elastic/kibana/blob/{branch}/x-pack/platform/plugins/shared/spaces/public/share_saved_objects_to_space/types.ts[flyout] for the user to
 edit the object's assigned spaces. You may want to follow the example of the <<data-views,Data Views page>> and
 https://github.com/elastic/kibana/blob/{branch}/src/plugins/data_view_management/public/components/index_pattern_table/spaces_list.tsx[combine
 these into a single component] so that the space list can be clicked to show the flyout:

docs/developer/plugin-list.asciidoc

@@ -902,7 +902,7 @@ This plugin is only enabled when the application is built for serverless project
 |or
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/spaces/README.md[spaces]
+|{kib-repo}blob/{branch}/x-pack/platform/plugins/shared/spaces/README.md[spaces]
 |See Configuring Kibana Spaces.
 
 

legacy_rfcs/text/0007_lifecycle_unblocked.md

@@ -343,7 +343,7 @@ functions and will be impacted:
 3. [vis_type_table](https://github.com/elastic/kibana/blob/6039709929caf0090a4130b8235f3a53bd04ed84/src/legacy/core_plugins/vis_type_table/public/plugin.ts#L61)
 4. [vis_type_vega](https://github.com/elastic/kibana/blob/6039709929caf0090a4130b8235f3a53bd04ed84/src/legacy/core_plugins/vis_type_vega/public/plugin.ts#L59)
 6. [code](https://github.com/elastic/kibana/blob/5049b460b47d4ae3432e1d9219263bb4be441392/x-pack/legacy/plugins/code/server/plugin.ts#L129-L149)
-7. [spaces](https://github.com/elastic/kibana/blob/096c7ee51136327f778845c636d7c4f1188e5db2/x-pack/legacy/plugins/spaces/server/new_platform/plugin.ts#L95)
+7. [spaces](https://github.com/elastic/kibana/blob/096c7ee51136327f778845c636d7c4f1188e5db2/x-pack/legacy/platform/plugins/shared/spaces/server/new_platform/plugin.ts#L95)
 8. [licensing](https://github.com/elastic/kibana/blob/4667c46caef26f8f47714504879197708debae32/x-pack/plugins/licensing/server/plugin.ts)
 9. [security](https://github.com/elastic/kibana/blob/0f2324e44566ce2cf083d89082841e57d2db6ef6/x-pack/platform/plugins/shared/security/server/plugin.ts#L96)
 

package.json

@@ -928,7 +928,7 @@
     "@kbn/slo-schema": "link:x-pack/packages/kbn-slo-schema",
     "@kbn/snapshot-restore-plugin": "link:x-pack/plugins/snapshot_restore",
     "@kbn/sort-predicates": "link:packages/kbn-sort-predicates",
-    "@kbn/spaces-plugin": "link:x-pack/plugins/spaces",
+    "@kbn/spaces-plugin": "link:x-pack/platform/plugins/shared/spaces",
     "@kbn/spaces-test-plugin": "link:x-pack/test/spaces_api_integration/common/plugins/spaces_test_plugin",
     "@kbn/sse-utils": "link:packages/kbn-sse-utils",
     "@kbn/sse-utils-client": "link:packages/kbn-sse-utils-client",

packages/core/saved-objects/core-saved-objects-common/src/types.ts

@@ -19,7 +19,7 @@ export interface SavedObjectTypeIdTuple {
   type: string;
 }
 
-// NOTE: moved from x-pack/plugins/spaces/common/types.ts for use by SO security ext
+// NOTE: moved from x-pack/platform/plugins/shared/spaces/common/types.ts for use by SO security ext
 /**
  * Client interface for interacting with legacy URL aliases.
  */

tsconfig.base.json

@@ -1832,8 +1832,8 @@
       "@kbn/sort-package-json/*": ["packages/kbn-sort-package-json/*"],
       "@kbn/sort-predicates": ["packages/kbn-sort-predicates"],
       "@kbn/sort-predicates/*": ["packages/kbn-sort-predicates/*"],
-      "@kbn/spaces-plugin": ["x-pack/plugins/spaces"],
-      "@kbn/spaces-plugin/*": ["x-pack/plugins/spaces/*"],
+      "@kbn/spaces-plugin": ["x-pack/platform/plugins/shared/spaces"],
+      "@kbn/spaces-plugin/*": ["x-pack/platform/plugins/shared/spaces/*"],
       "@kbn/spaces-test-plugin": ["x-pack/test/spaces_api_integration/common/plugins/spaces_test_plugin"],
       "@kbn/spaces-test-plugin/*": ["x-pack/test/spaces_api_integration/common/plugins/spaces_test_plugin/*"],
       "@kbn/sse-utils": ["packages/kbn-sse-utils"],

x-pack/.i18nrc.json

@@ -155,7 +155,7 @@
     ],
     "xpack.slo": "plugins/observability_solution/slo",
     "xpack.snapshotRestore": "plugins/snapshot_restore",
-    "xpack.spaces": "plugins/spaces",
+    "xpack.spaces": "platform/plugins/shared/spaces",
     "xpack.savedObjectsTagging": [
       "plugins/saved_objects_tagging"
     ],

x-pack/plugins/spaces/jest.config.js → x-pack/platform/plugins/shared/spaces/jest.config.js

@@ -7,9 +7,9 @@
 
 module.exports = {
   preset: '@kbn/test',
-  rootDir: '../../..',
-  roots: ['<rootDir>/x-pack/plugins/spaces'],
-  coverageDirectory: '<rootDir>/target/kibana-coverage/jest/x-pack/plugins/spaces',
+  rootDir: '../../../../..',
+  roots: ['<rootDir>/x-pack/platform/plugins/shared/spaces'],
+  coverageDirectory: '<rootDir>/target/kibana-coverage/jest/x-pack/platform/plugins/shared/spaces',
   coverageReporters: ['text', 'html'],
-  collectCoverageFrom: ['<rootDir>/x-pack/plugins/spaces/{common,public,server}/**/*.{ts,tsx}'],
+  collectCoverageFrom: ['<rootDir>/x-pack/platform/plugins/shared/spaces/{common,public,server}/**/*.{ts,tsx}'],
 };