Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] revert Select line chart by default if the x-axis contains a timestamp #198555

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Oct 31, 2024

@mbondyra mbondyra added release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:version Backport to applied version labels labels Oct 31, 2024
@mbondyra mbondyra requested a review from a team as a code owner October 31, 2024 15:03
@markov00
Copy link
Member

markov00 commented Nov 4, 2024

updating the branch because we encountered an error in the CI fixed 4 minutes ago #198759

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #26 / serverless search UI Search index detail page index management index details manage index action "before each" hook for "navigates to overview tab"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB -101.0B

History

@mbondyra mbondyra merged commit d117141 into elastic:main Nov 4, 2024
22 checks passed
@mbondyra mbondyra deleted the lens/revert_line branch November 4, 2024 14:25
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11666191032

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 4, 2024
…ns a timestamp (#198555) (#198798)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Lens] revert Select line chart by default if the x-axis contains a
timestamp (#198555)](#198555)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T14:25:07Z","message":"[Lens]
revert Select line chart by default if the x-axis contains a timestamp
(#198555)\n\nReverts
https://github.com/elastic/kibana/pull/190786/files\r\n\r\n---------\r\n\r\nCo-authored-by:
Marco Vettorello
<[email protected]>","sha":"d1171418dd7d8c7252ad34b6bb2e4ff505fb684d","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Lens","v9.0.0","backport:version","v8.17.0"],"title":"[Lens]
revert Select line chart by default if the x-axis contains a
timestamp","number":198555,"url":"https://github.com/elastic/kibana/pull/198555","mergeCommit":{"message":"[Lens]
revert Select line chart by default if the x-axis contains a timestamp
(#198555)\n\nReverts
https://github.com/elastic/kibana/pull/190786/files\r\n\r\n---------\r\n\r\nCo-authored-by:
Marco Vettorello
<[email protected]>","sha":"d1171418dd7d8c7252ad34b6bb2e4ff505fb684d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198555","number":198555,"mergeCommit":{"message":"[Lens]
revert Select line chart by default if the x-axis contains a timestamp
(#198555)\n\nReverts
https://github.com/elastic/kibana/pull/190786/files\r\n\r\n---------\r\n\r\nCo-authored-by:
Marco Vettorello
<[email protected]>","sha":"d1171418dd7d8c7252ad34b6bb2e4ff505fb684d"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:Lens release_note:skip Skip the PR/issue when compiling release notes v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants