[Lens] revert Select line chart by default if the x-axis contains a t…

…imestamp (#198555) Reverts https://github.com/elastic/kibana/pull/190786/files --------- Co-authored-by: Marco Vettorello <[email protected]>
elastic · Nov 4, 2024 · d117141 · d117141
1 parent 5721de7
commit d117141
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/x-pack/plugins/lens/public/visualizations/xy/xy_suggestions.test.ts b/x-pack/plugins/lens/public/visualizations/xy/xy_suggestions.test.ts
@@ -854,7 +854,7 @@ describe('xy_suggestions', () => {
     expect((suggestions[0].state.layers[0] as XYDataLayerConfig).seriesType).toEqual('line');
   });
 
-  test('suggests line if changeType is initial and date column is involved', () => {
+  test('suggests bar if changeType is initial and date column is involved', () => {
     const currentState: XYState = {
       legend: { isVisible: true, position: 'bottom' },
       valueLabels: 'hide',
@@ -885,8 +885,8 @@ describe('xy_suggestions', () => {
     expect(suggestions).toHaveLength(1);
 
     expect(suggestions[0].hide).toEqual(false);
-    expect(suggestions[0].state.preferredSeriesType).toEqual('line');
-    expect((suggestions[0].state.layers[0] as XYDataLayerConfig).seriesType).toEqual('line');
+    expect(suggestions[0].state.preferredSeriesType).toEqual('bar_stacked');
+    expect((suggestions[0].state.layers[0] as XYDataLayerConfig).seriesType).toEqual('bar_stacked');
   });
 
   test('makes a visible seriesType suggestion for unchanged table without split', () => {

diff --git a/x-pack/plugins/lens/public/visualizations/xy/xy_suggestions.ts b/x-pack/plugins/lens/public/visualizations/xy/xy_suggestions.ts
@@ -233,9 +233,6 @@ function getSuggestionsForLayer({
     allowMixed,
   };
 
-  if (changeType === 'initial' && xValue?.operation.dataType === 'date') {
-    return buildSuggestion({ ...options, seriesType: 'line' });
-  }
   // handles the simplest cases, acting as a chart switcher
   if (!currentState && changeType === 'unchanged') {
     // Chart switcher needs to include every chart type

diff --git a/x-pack/test/functional/apps/lens/group1/multiple_data_views.ts b/x-pack/test/functional/apps/lens/group1/multiple_data_views.ts
@@ -103,13 +103,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await testSubjects.click('fieldToggle-DistanceKilometers');
 
       const data = await lens.getCurrentChartDebugState('xyVisChart');
-      assertMatchesExpectedData(data, [expectedLogstashData, expectedFlightsData], 'lines');
+      assertMatchesExpectedData(data, [expectedLogstashData, expectedFlightsData]);
     });
 
     it('ignores global filters on layers using a data view without the filter field', async () => {
       await filterBar.addFilter({ field: 'Carrier', operation: 'exists' });
       const data = await lens.getCurrentChartDebugState('xyVisChart');
-      assertMatchesExpectedData(data, [expectedLogstashData, expectedFlightsData], 'lines');
+      assertMatchesExpectedData(data, [expectedLogstashData, expectedFlightsData]);
       await lens.save(visTitle);
     });
 
@@ -120,7 +120,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
 
       await visualize.openSavedVisualization(visTitle);
       const data = await lens.getCurrentChartDebugState('xyVisChart');
-      assertMatchesExpectedData(data, [expectedFlightsData], 'lines');
+      assertMatchesExpectedData(data, [expectedFlightsData]);
     });
   });
 }