[Security Solution] Revert security_solution_common package which is unnecessary
#198294
+143
−545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logeekal
added
backport
v8.17.0
release_note:skip
|
/ci |
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
|
/ci |
tomsonpl
approved these changes
Oct 30, 2024
x-pack/plugins/security_solution/public/flyout/document_details/left/components/tour.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/flyout/document_details/right/components/tour.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/flyout/shared/components/expandable_panel.test.tsx
Outdated
Show resolved
Hide resolved
JordanSh
approved these changes
Oct 30, 2024
PhilippeOberti
approved these changes
Oct 30, 2024
davismcphee
approved these changes
Oct 30, 2024
Thanks @davismcphee . To answer your question, Yes, exactly. In current state |
machadoum
approved these changes
Nov 4, 2024
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
History
|
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 task
PhilippeOberti
pushed a commit
to PhilippeOberti/kibana
that referenced
this pull request
Nov 4, 2024
…s unnecessary (elastic#198294) ## Summary This PR reverts elastic#189633. ### Background PR : elastic#189633 had created a package `security_solution_common` so that security components can be easily used in Discover plugins. But because of recent direction change, I have decided to revert that change which mainly moved `flyout` code to the `security_solution_common` package. Most of the changes that you will see will be path changes replacing `security_solution_common`. ## TL;DR `security_solution_common` is being removed as the reason it was created does not exists any more. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 641d0e2) # Conflicts: # .github/CODEOWNERS
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
PhilippeOberti
pushed a commit
to PhilippeOberti/kibana
that referenced
this pull request
Nov 4, 2024
…s unnecessary (elastic#198294) ## Summary This PR reverts elastic#189633. ### Background PR : elastic#189633 had created a package `security_solution_common` so that security components can be easily used in Discover plugins. But because of recent direction change, I have decided to revert that change which mainly moved `flyout` code to the `security_solution_common` package. Most of the changes that you will see will be path changes replacing `security_solution_common`. ## TL;DR `security_solution_common` is being removed as the reason it was created does not exists any more. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 641d0e2) # Conflicts: # .github/CODEOWNERS
PhilippeOberti
added a commit
that referenced
this pull request
Nov 5, 2024
…hich is unnecessary (#198294) (#198877) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Revert `security_solution_common` package which is unnecessary (#198294)](#198294) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T14:39:32Z","message":"[Security Solution] Revert `security_solution_common` package which is unnecessary (#198294)\n\n## Summary\r\n\r\nThis PR reverts https://github.com/elastic/kibana/pull/189633.\r\n\r\n### Background\r\n\r\nPR : #189633 had created a package\r\n`security_solution_common` so that security components can be easily\r\nused in Discover plugins.\r\n\r\nBut because of recent direction change, I have decided to revert that\r\nchange which mainly moved `flyout` code to the\r\n`security_solution_common` package.\r\n\r\nMost of the changes that you will see will be path changes replacing\r\n`security_solution_common`.\r\n\r\n\r\n## TL;DR\r\n\r\n`security_solution_common` is being removed as the reason it was created\r\ndoes not exists any more.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"641d0e2d477955c60ccfa290ba5c10601c7f453a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","v8.17.0"],"number":198294,"url":"https://github.com/elastic/kibana/pull/198294","mergeCommit":{"message":"[Security Solution] Revert `security_solution_common` package which is unnecessary (#198294)\n\n## Summary\r\n\r\nThis PR reverts https://github.com/elastic/kibana/pull/189633.\r\n\r\n### Background\r\n\r\nPR : #189633 had created a package\r\n`security_solution_common` so that security components can be easily\r\nused in Discover plugins.\r\n\r\nBut because of recent direction change, I have decided to revert that\r\nchange which mainly moved `flyout` code to the\r\n`security_solution_common` package.\r\n\r\nMost of the changes that you will see will be path changes replacing\r\n`security_solution_common`.\r\n\r\n\r\n## TL;DR\r\n\r\n`security_solution_common` is being removed as the reason it was created\r\ndoes not exists any more.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"641d0e2d477955c60ccfa290ba5c10601c7f453a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198294","number":198294,"mergeCommit":{"message":"[Security Solution] Revert `security_solution_common` package which is unnecessary (#198294)\n\n## Summary\r\n\r\nThis PR reverts https://github.com/elastic/kibana/pull/189633.\r\n\r\n### Background\r\n\r\nPR : #189633 had created a package\r\n`security_solution_common` so that security components can be easily\r\nused in Discover plugins.\r\n\r\nBut because of recent direction change, I have decided to revert that\r\nchange which mainly moved `flyout` code to the\r\n`security_solution_common` package.\r\n\r\nMost of the changes that you will see will be path changes replacing\r\n`security_solution_common`.\r\n\r\n\r\n## TL;DR\r\n\r\n`security_solution_common` is being removed as the reason it was created\r\ndoes not exists any more.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"641d0e2d477955c60ccfa290ba5c10601c7f453a"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <[email protected]>
1 task
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 27, 2024
…201477) ## Summary Some code was added in [this PR](elastic#189633) to allow the expandable flyout to be used in the OneDiscover context. Later on, [this PR](elastic#198294) reverted most of the changes, but some files remained. This PR cleans up all the files (that I could find) that are now unnecessary and unused (cherry picked from commit 7ebd150)
kibanamachine
added a commit
that referenced
this pull request
Nov 27, 2024
…201477) (#202047) # Backport This will backport the following commits from `main` to `8.17`: - [[Security Solution][Expandable flyout] - remove unused code (#201477)](#201477) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-27T17:59:01Z","message":"[Security Solution][Expandable flyout] - remove unused code (#201477)\n\n## Summary\r\n\r\nSome code was added in [this\r\nPR](#189633) to allow the\r\nexpandable flyout to be used in the OneDiscover context. Later on, [this\r\nPR](#198294) reverted most of the\r\nchanges, but some files remained.\r\n\r\nThis PR cleans up all the files (that I could find) that are now\r\nunnecessary and unused","sha":"7ebd1506ff23828095f6bd3b131a22577ad960fe","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.17.0"],"title":"[Security Solution][Expandable flyout] - remove unused code","number":201477,"url":"https://github.com/elastic/kibana/pull/201477","mergeCommit":{"message":"[Security Solution][Expandable flyout] - remove unused code (#201477)\n\n## Summary\r\n\r\nSome code was added in [this\r\nPR](#189633) to allow the\r\nexpandable flyout to be used in the OneDiscover context. Later on, [this\r\nPR](#198294) reverted most of the\r\nchanges, but some files remained.\r\n\r\nThis PR cleans up all the files (that I could find) that are now\r\nunnecessary and unused","sha":"7ebd1506ff23828095f6bd3b131a22577ad960fe"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201477","number":201477,"mergeCommit":{"message":"[Security Solution][Expandable flyout] - remove unused code (#201477)\n\n## Summary\r\n\r\nSome code was added in [this\r\nPR](#189633) to allow the\r\nexpandable flyout to be used in the OneDiscover context. Later on, [this\r\nPR](#198294) reverted most of the\r\nchanges, but some files remained.\r\n\r\nThis PR cleans up all the files (that I could find) that are now\r\nunnecessary and unused","sha":"7ebd1506ff23828095f6bd3b131a22577ad960fe"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…201477) ## Summary Some code was added in [this PR](elastic#189633) to allow the expandable flyout to be used in the OneDiscover context. Later on, [this PR](elastic#198294) reverted most of the changes, but some files remained. This PR cleans up all the files (that I could find) that are now unnecessary and unused
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
Dec 13, 2024
…201477) ## Summary Some code was added in [this PR](elastic#189633) to allow the expandable flyout to be used in the OneDiscover context. Later on, [this PR](elastic#198294) reverted most of the changes, but some files remained. This PR cleans up all the files (that I could find) that are now unnecessary and unused (cherry picked from commit 7ebd150)
PhilippeOberti
added a commit
that referenced
this pull request
Dec 13, 2024
…01477) (#204153) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Expandable flyout] - remove unused code (#201477)](#201477) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-27T17:59:01Z","message":"[Security Solution][Expandable flyout] - remove unused code (#201477)\n\n## Summary\r\n\r\nSome code was added in [this\r\nPR](#189633) to allow the\r\nexpandable flyout to be used in the OneDiscover context. Later on, [this\r\nPR](#198294) reverted most of the\r\nchanges, but some files remained.\r\n\r\nThis PR cleans up all the files (that I could find) that are now\r\nunnecessary and unused","sha":"7ebd1506ff23828095f6bd3b131a22577ad960fe","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.17.0"],"number":201477,"url":"https://github.com/elastic/kibana/pull/201477","mergeCommit":{"message":"[Security Solution][Expandable flyout] - remove unused code (#201477)\n\n## Summary\r\n\r\nSome code was added in [this\r\nPR](#189633) to allow the\r\nexpandable flyout to be used in the OneDiscover context. Later on, [this\r\nPR](#198294) reverted most of the\r\nchanges, but some files remained.\r\n\r\nThis PR cleans up all the files (that I could find) that are now\r\nunnecessary and unused","sha":"7ebd1506ff23828095f6bd3b131a22577ad960fe"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201477","number":201477,"mergeCommit":{"message":"[Security Solution][Expandable flyout] - remove unused code (#201477)\n\n## Summary\r\n\r\nSome code was added in [this\r\nPR](#189633) to allow the\r\nexpandable flyout to be used in the OneDiscover context. Later on, [this\r\nPR](#198294) reverted most of the\r\nchanges, but some files remained.\r\n\r\nThis PR cleans up all the files (that I could find) that are now\r\nunnecessary and unused","sha":"7ebd1506ff23828095f6bd3b131a22577ad960fe"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/202047","number":202047,"state":"MERGED","mergeCommit":{"sha":"a4b919479a733a6a97b2b35b49f99bed5589f3fa","message":"[8.17] [Security Solution][Expandable flyout] - remove unused code (#201477) (#202047)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.17`:\n- [[Security Solution][Expandable flyout] - remove unused code\n(#201477)](https://github.com/elastic/kibana/pull/201477)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Philippe\nOberti\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-11-27T17:59:01Z\",\"message\":\"[Security\nSolution][Expandable flyout] - remove unused code (#201477)\\n\\n##\nSummary\\r\\n\\r\\nSome code was added in\n[this\\r\\nPR](#189633) to allow\nthe\\r\\nexpandable flyout to be used in the OneDiscover context. Later\non, [this\\r\\nPR](#198294) reverted\nmost of the\\r\\nchanges, but some files remained.\\r\\n\\r\\nThis PR cleans\nup all the files (that I could find) that are now\\r\\nunnecessary and\nunused\",\"sha\":\"7ebd1506ff23828095f6bd3b131a22577ad960fe\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"Team:Threat\nHunting:Investigations\",\"backport:version\",\"v8.17.0\"],\"title\":\"[Security\nSolution][Expandable flyout] - remove unused\ncode\",\"number\":201477,\"url\":\"https://github.com/elastic/kibana/pull/201477\",\"mergeCommit\":{\"message\":\"[Security\nSolution][Expandable flyout] - remove unused code (#201477)\\n\\n##\nSummary\\r\\n\\r\\nSome code was added in\n[this\\r\\nPR](#189633) to allow\nthe\\r\\nexpandable flyout to be used in the OneDiscover context. Later\non, [this\\r\\nPR](#198294) reverted\nmost of the\\r\\nchanges, but some files remained.\\r\\n\\r\\nThis PR cleans\nup all the files (that I could find) that are now\\r\\nunnecessary and\nunused\",\"sha\":\"7ebd1506ff23828095f6bd3b131a22577ad960fe\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.17\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/201477\",\"number\":201477,\"mergeCommit\":{\"message\":\"[Security\nSolution][Expandable flyout] - remove unused code (#201477)\\n\\n##\nSummary\\r\\n\\r\\nSome code was added in\n[this\\r\\nPR](#189633) to allow\nthe\\r\\nexpandable flyout to be used in the OneDiscover context. Later\non, [this\\r\\nPR](#198294) reverted\nmost of the\\r\\nchanges, but some files remained.\\r\\n\\r\\nThis PR cleans\nup all the files (that I could find) that are now\\r\\nunnecessary and\nunused\",\"sha\":\"7ebd1506ff23828095f6bd3b131a22577ad960fe\"}},{\"branch\":\"8.17\",\"label\":\"v8.17.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Philippe Oberti <[email protected]>"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR reverts #189633.
Background
PR : #189633 had created a package
security_solution_commonso that security components can be easily used in Discover plugins.But because of recent direction change, I have decided to revert that change which mainly moved
flyoutcode to thesecurity_solution_commonpackage.Most of the changes that you will see will be path changes replacing
security_solution_common.TL;DR
security_solution_commonis being removed as the reason it was created does not exists any more.