Skip to content

Commit

Permalink
[Security Solution] Revert security_solution_common package which i…
Browse files Browse the repository at this point in the history
…s unnecessary (elastic#198294)

## Summary

This PR reverts elastic#189633.

### Background

PR : elastic#189633 had created a package
`security_solution_common` so that security components can be easily
used in Discover plugins.

But because of recent direction change, I have decided to revert that
change which mainly moved `flyout` code to the
`security_solution_common` package.

Most of the changes that you will see will be path changes replacing
`security_solution_common`.

## TL;DR

`security_solution_common` is being removed as the reason it was created
does not exists any more.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 641d0e2)

# Conflicts:
#	.github/CODEOWNERS
  • Loading branch information
logeekal committed Nov 4, 2024
1 parent a669b6c commit 4628a4b
Show file tree
Hide file tree
Showing 121 changed files with 2,209 additions and 544 deletions.
2,066 changes: 2,066 additions & 0 deletions .github/CODEOWNERS

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,6 @@
"@kbn/security-plugin-types-public": "link:x-pack/packages/security/plugin_types_public",
"@kbn/security-plugin-types-server": "link:x-pack/packages/security/plugin_types_server",
"@kbn/security-role-management-model": "link:x-pack/packages/security/role_management_model",
"@kbn/security-solution-common": "link:x-pack/packages/security-solution/common",
"@kbn/security-solution-distribution-bar": "link:x-pack/packages/security-solution/distribution_bar",
"@kbn/security-solution-ess": "link:x-pack/plugins/security_solution_ess",
"@kbn/security-solution-features": "link:x-pack/packages/security-solution/features",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
* License v3.0 only", or the "Server Side Public License, v 1".
*/

import React from 'react';
import { getDiscoverCellRenderer } from '@kbn/security-solution-common';
import { RootProfileProvider, SolutionType } from '../../../profiles';
import { ProfileProviderServices } from '../../profile_provider_services';
import { SecurityProfileProviderFactory } from '../types';
Expand All @@ -21,12 +19,6 @@ export const createSecurityRootProfileProvider: SecurityProfileProviderFactory<
profile: {
getCellRenderers: (prev) => (params) => ({
...prev(params),
'host.name': (props) => {
const CellRenderer = getDiscoverCellRenderer({
fieldName: 'host.name',
});
return <CellRenderer {...props} />;
},
}),
},
resolve: (params) => {
Expand Down
1 change: 0 additions & 1 deletion src/plugins/discover/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@
"@kbn/presentation-containers",
"@kbn/observability-ai-assistant-plugin",
"@kbn/fields-metadata-plugin",
"@kbn/security-solution-common",
"@kbn/logs-data-access-plugin",
"@kbn/core-lifecycle-browser",
"@kbn/discover-contextual-components",
Expand Down
2 changes: 0 additions & 2 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -1576,8 +1576,6 @@
"@kbn/security-plugin-types-server/*": ["x-pack/packages/security/plugin_types_server/*"],
"@kbn/security-role-management-model": ["x-pack/packages/security/role_management_model"],
"@kbn/security-role-management-model/*": ["x-pack/packages/security/role_management_model/*"],
"@kbn/security-solution-common": ["x-pack/packages/security-solution/common"],
"@kbn/security-solution-common/*": ["x-pack/packages/security-solution/common/*"],
"@kbn/security-solution-distribution-bar": ["x-pack/packages/security-solution/distribution_bar"],
"@kbn/security-solution-distribution-bar/*": ["x-pack/packages/security-solution/distribution_bar/*"],
"@kbn/security-solution-ess": ["x-pack/plugins/security_solution_ess"],
Expand Down
11 changes: 0 additions & 11 deletions x-pack/packages/security-solution/common/index.ts

This file was deleted.

12 changes: 0 additions & 12 deletions x-pack/packages/security-solution/common/jest.config.js

This file was deleted.

5 changes: 0 additions & 5 deletions x-pack/packages/security-solution/common/kibana.jsonc

This file was deleted.

8 changes: 0 additions & 8 deletions x-pack/packages/security-solution/common/package.json

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

10 changes: 0 additions & 10 deletions x-pack/packages/security-solution/common/src/flyout/index.tsx

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 4628a4b

Please sign in to comment.