Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Security Solution] Revert security_solution_common package which is unnecessary (#198294) #198877

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

PhilippeOberti
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…s unnecessary (elastic#198294)

## Summary

This PR reverts elastic#189633.

### Background

PR : elastic#189633 had created a package
`security_solution_common` so that security components can be easily
used in Discover plugins.

But because of recent direction change, I have decided to revert that
change which mainly moved `flyout` code to the
`security_solution_common` package.

Most of the changes that you will see will be path changes replacing
`security_solution_common`.

## TL;DR

`security_solution_common` is being removed as the reason it was created
does not exists any more.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 641d0e2)

# Conflicts:
#	.github/CODEOWNERS
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 1015 969 -46
securitySolution 6139 6127 -12
total -58

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/security-solution-common 38 - -38

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 828.6KB 807.7KB -20.9KB
securitySolution 21.0MB 21.0MB +4.1KB
total -16.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/security-solution-common 5 - -5

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 50.7KB 50.5KB -165.0B
Unknown metric groups

API count

id before after diff
@kbn/security-solution-common 59 - -59

@PhilippeOberti PhilippeOberti merged commit 97f60e3 into elastic:8.x Nov 5, 2024
36 checks passed
@PhilippeOberti PhilippeOberti deleted the backport/8.x/pr-198294 branch November 5, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants