-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stricter byte size validation #193529
Merged
Merged
Stricter byte size validation #193529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudolf
added
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
backport:skip
This commit does not require backporting
v9.0.0
labels
Sep 20, 2024
Pinging @elastic/kibana-core (Team:Core) |
rudolf
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Sep 20, 2024
afharo
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
9 tasks
rudolf
added a commit
that referenced
this pull request
Nov 20, 2024
## Summary Inspired by #193529 but does not change the regular expression, it only limits the string length which is anyway the biggest performance improvement. This makes it a lot safer to backport since it's less likely that we could break existing kibana configurations that had typos. ### Checklist ### Identify risks - [ ] Could cause a Kibana to refuse to start up after an upgrade if it had a byte size configuration value that was excessively long.
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Nov 20, 2024
## Summary Inspired by elastic#193529 but does not change the regular expression, it only limits the string length which is anyway the biggest performance improvement. This makes it a lot safer to backport since it's less likely that we could break existing kibana configurations that had typos. ### Checklist ### Identify risks - [ ] Could cause a Kibana to refuse to start up after an upgrade if it had a byte size configuration value that was excessively long. (cherry picked from commit b476f7f) # Conflicts: # packages/kbn-config-schema/src/byte_size_value/index.test.ts # packages/kbn-config-schema/src/byte_size_value/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This makes byte size validation stricter by ensuring that the string starts and ends with valid values so it won't match on e.g.
a1234b
or1234ba
.This has a slight chance to fail validation on an existing kibana.yml if users had a typo that we previously ignored. As such it would be safer to not backport to 8.x
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers