Limit bytesizevalue length for 8.x/7.x #200733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudolf
added
the
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
rudolf
added
release_note:skip
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Nov 20, 2024
## Summary Inspired by elastic#193529 but does not change the regular expression, it only limits the string length which is anyway the biggest performance improvement. This makes it a lot safer to backport since it's less likely that we could break existing kibana configurations that had typos. ### Checklist ### Identify risks - [ ] Could cause a Kibana to refuse to start up after an upgrade if it had a byte size configuration value that was excessively long. (cherry picked from commit b476f7f) # Conflicts: # packages/kbn-config-schema/src/byte_size_value/index.test.ts # packages/kbn-config-schema/src/byte_size_value/index.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Inspired by #193529 but does not change the regular expression, it only limits the string length which is anyway the biggest performance improvement. This makes it a lot safer to backport since it's less likely that we could break existing kibana configurations that had typos.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_node:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.