[Fleet][Cloud] Enrollment token table may show an empty last page #167663 #188049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Fleet
|
💚 CLA has been signed |
|
Pinging @elastic/fleet (Team:Fleet) |
|
@pra2107tham could you please sgn the contributor agreement as stated in this comment? |
I signed the contributer agreement, whats next? |
|
@pra2107tham next step would be to have someone reviewing your work. |
juliaElastic
approved these changes
Jul 11, 2024
|
/ci |
|
@elasticmachine run elasticsearch-ci/docs |
How? |
|
buildkite test this |
do I have to do this? |
|
@elasticmachine run buildkite/docs-build-pr |
|
I'm trying to trigger the docs build step which is not started yet. Something changed since the last time I've used these commands. |
Ohh okay, so I am done with my task ig |
|
@elasticmachine run kibana-ci |
|
@juliaElastic can you complete all the remaining checks? |
|
The kibana-ci is still running, when completed, we will be ready to merge the pr. |
kibanamachine
added
v8.16.0
backport:skip
💚 Build Succeeded
Metrics [docs]Async chunks
|
jen-huang
added
v8.15.0
backport:prev-minor
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 11, 2024
…stic#167663 (elastic#188049) Fixes elastic#167663 ## Summary Fixes the creation of extra empty page at pagination of 5 rows ### Video https://github.com/elastic/kibana/assets/140709379/cdac6a22-f239-4b70-b40c-93fc727418a6 Co-authored-by: Julien Lind <[email protected]> (cherry picked from commit 1f7fdfd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 11, 2024
…age #167663 (#188049) (#188127) # Backport This will backport the following commits from `main` to `8.15`: - [[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)](#188049) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Pratham Shirbhate","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-11T09:15:54Z","message":"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\n\nFixes #167663 \r\n\r\n## Summary\r\n\r\nFixes the creation of extra empty page at pagination of 5 rows\r\n\r\n\r\n### Video \r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/140709379/cdac6a22-f239-4b70-b40c-93fc727418a6\r\n\r\nCo-authored-by: Julien Lind <[email protected]>","sha":"1f7fdfdfe428525b08bf14321463d091bdad4c79","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","💝community","Team:Fleet","backport:prev-minor","v8.15.0","v8.16.0"],"title":"[Fleet][Cloud] Enrollment token table may show an empty last page #167663","number":188049,"url":"https://github.com/elastic/kibana/pull/188049","mergeCommit":{"message":"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\n\nFixes #167663 \r\n\r\n## Summary\r\n\r\nFixes the creation of extra empty page at pagination of 5 rows\r\n\r\n\r\n### Video \r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/140709379/cdac6a22-f239-4b70-b40c-93fc727418a6\r\n\r\nCo-authored-by: Julien Lind <[email protected]>","sha":"1f7fdfdfe428525b08bf14321463d091bdad4c79"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188049","number":188049,"mergeCommit":{"message":"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\n\nFixes #167663 \r\n\r\n## Summary\r\n\r\nFixes the creation of extra empty page at pagination of 5 rows\r\n\r\n\r\n### Video \r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/140709379/cdac6a22-f239-4b70-b40c-93fc727418a6\r\n\r\nCo-authored-by: Julien Lind <[email protected]>","sha":"1f7fdfdfe428525b08bf14321463d091bdad4c79"}}]}] BACKPORT--> Co-authored-by: Pratham Shirbhate <[email protected]>
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Sep 27, 2024
…page elastic#167663 (elastic#188049)" This reverts commit 1f7fdfd.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 30, 2024
…page elastic#167663 (elastic#188049)" (elastic#194343) ## Summary Resolves elastic#194339. This PR reverts elastic#188049 as it inadvertently broke pagination of the enrollment tokens page. This means that elastic#167663 will need to be re-opened and fixed in a different way. (cherry picked from commit 283f6e6)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 30, 2024
…page elastic#167663 (elastic#188049)" (elastic#194343) ## Summary Resolves elastic#194339. This PR reverts elastic#188049 as it inadvertently broke pagination of the enrollment tokens page. This means that elastic#167663 will need to be re-opened and fixed in a different way. (cherry picked from commit 283f6e6)
kibanamachine
added a commit
that referenced
this pull request
Sep 30, 2024
…empty last page #167663 (#188049)" (#194343) (#194480) # Backport This will backport the following commits from `main` to `8.x`: - [Revert "[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)" (#194343)](#194343) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jen Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-30T19:35:13Z","message":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\" (#194343)\n\n## Summary\r\n\r\nResolves #194339.\r\n\r\nThis PR reverts #188049 as it inadvertently broke pagination of the\r\nenrollment tokens page. This means that #167663 will need to be\r\nre-opened and fixed in a different way.","sha":"283f6e64c9656c97fa37be34f3e6fab2e8ad459f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-major"],"title":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\"","number":194343,"url":"https://github.com/elastic/kibana/pull/194343","mergeCommit":{"message":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\" (#194343)\n\n## Summary\r\n\r\nResolves #194339.\r\n\r\nThis PR reverts #188049 as it inadvertently broke pagination of the\r\nenrollment tokens page. This means that #167663 will need to be\r\nre-opened and fixed in a different way.","sha":"283f6e64c9656c97fa37be34f3e6fab2e8ad459f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194343","number":194343,"mergeCommit":{"message":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\" (#194343)\n\n## Summary\r\n\r\nResolves #194339.\r\n\r\nThis PR reverts #188049 as it inadvertently broke pagination of the\r\nenrollment tokens page. This means that #167663 will need to be\r\nre-opened and fixed in a different way.","sha":"283f6e64c9656c97fa37be34f3e6fab2e8ad459f"}}]}] BACKPORT--> Co-authored-by: Jen Huang <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Sep 30, 2024
… empty last page #167663 (#188049)" (#194343) (#194479) # Backport This will backport the following commits from `main` to `8.15`: - [Revert "[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)" (#194343)](#194343) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jen Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-30T19:35:13Z","message":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\" (#194343)\n\n## Summary\r\n\r\nResolves #194339.\r\n\r\nThis PR reverts #188049 as it inadvertently broke pagination of the\r\nenrollment tokens page. This means that #167663 will need to be\r\nre-opened and fixed in a different way.","sha":"283f6e64c9656c97fa37be34f3e6fab2e8ad459f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-major"],"title":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\"","number":194343,"url":"https://github.com/elastic/kibana/pull/194343","mergeCommit":{"message":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\" (#194343)\n\n## Summary\r\n\r\nResolves #194339.\r\n\r\nThis PR reverts #188049 as it inadvertently broke pagination of the\r\nenrollment tokens page. This means that #167663 will need to be\r\nre-opened and fixed in a different way.","sha":"283f6e64c9656c97fa37be34f3e6fab2e8ad459f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194343","number":194343,"mergeCommit":{"message":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\" (#194343)\n\n## Summary\r\n\r\nResolves #194339.\r\n\r\nThis PR reverts #188049 as it inadvertently broke pagination of the\r\nenrollment tokens page. This means that #167663 will need to be\r\nre-opened and fixed in a different way.","sha":"283f6e64c9656c97fa37be34f3e6fab2e8ad459f"}}]}] BACKPORT--> Co-authored-by: Jen Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167663
Summary
Fixes the creation of extra empty page at pagination of 5 rows
Video
Recording.2024-07-11.120546.mp4