-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Unable to paginate Enrollment Tokens page #194339
Labels
bug
Fixes for quality problems that affect the customer experience
Team:Fleet
Team label for Observability Data Collection Fleet team
Comments
jen-huang
added
bug
Fixes for quality problems that affect the customer experience
Team:Fleet
Team label for Observability Data Collection Fleet team
labels
Sep 27, 2024
Pinging @elastic/fleet (Team:Fleet) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Sep 30, 2024
…page elastic#167663 (elastic#188049)" (elastic#194343) ## Summary Resolves elastic#194339. This PR reverts elastic#188049 as it inadvertently broke pagination of the enrollment tokens page. This means that elastic#167663 will need to be re-opened and fixed in a different way. (cherry picked from commit 283f6e6)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Sep 30, 2024
…page elastic#167663 (elastic#188049)" (elastic#194343) ## Summary Resolves elastic#194339. This PR reverts elastic#188049 as it inadvertently broke pagination of the enrollment tokens page. This means that elastic#167663 will need to be re-opened and fixed in a different way. (cherry picked from commit 283f6e6)
kibanamachine
added a commit
that referenced
this issue
Sep 30, 2024
…empty last page #167663 (#188049)" (#194343) (#194480) # Backport This will backport the following commits from `main` to `8.x`: - [Revert "[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)" (#194343)](#194343) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jen Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-30T19:35:13Z","message":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\" (#194343)\n\n## Summary\r\n\r\nResolves #194339.\r\n\r\nThis PR reverts #188049 as it inadvertently broke pagination of the\r\nenrollment tokens page. This means that #167663 will need to be\r\nre-opened and fixed in a different way.","sha":"283f6e64c9656c97fa37be34f3e6fab2e8ad459f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-major"],"title":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\"","number":194343,"url":"https://github.com/elastic/kibana/pull/194343","mergeCommit":{"message":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\" (#194343)\n\n## Summary\r\n\r\nResolves #194339.\r\n\r\nThis PR reverts #188049 as it inadvertently broke pagination of the\r\nenrollment tokens page. This means that #167663 will need to be\r\nre-opened and fixed in a different way.","sha":"283f6e64c9656c97fa37be34f3e6fab2e8ad459f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194343","number":194343,"mergeCommit":{"message":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\" (#194343)\n\n## Summary\r\n\r\nResolves #194339.\r\n\r\nThis PR reverts #188049 as it inadvertently broke pagination of the\r\nenrollment tokens page. This means that #167663 will need to be\r\nre-opened and fixed in a different way.","sha":"283f6e64c9656c97fa37be34f3e6fab2e8ad459f"}}]}] BACKPORT--> Co-authored-by: Jen Huang <[email protected]>
kibanamachine
added a commit
that referenced
this issue
Sep 30, 2024
… empty last page #167663 (#188049)" (#194343) (#194479) # Backport This will backport the following commits from `main` to `8.15`: - [Revert "[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)" (#194343)](#194343) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jen Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-30T19:35:13Z","message":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\" (#194343)\n\n## Summary\r\n\r\nResolves #194339.\r\n\r\nThis PR reverts #188049 as it inadvertently broke pagination of the\r\nenrollment tokens page. This means that #167663 will need to be\r\nre-opened and fixed in a different way.","sha":"283f6e64c9656c97fa37be34f3e6fab2e8ad459f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-major"],"title":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\"","number":194343,"url":"https://github.com/elastic/kibana/pull/194343","mergeCommit":{"message":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\" (#194343)\n\n## Summary\r\n\r\nResolves #194339.\r\n\r\nThis PR reverts #188049 as it inadvertently broke pagination of the\r\nenrollment tokens page. This means that #167663 will need to be\r\nre-opened and fixed in a different way.","sha":"283f6e64c9656c97fa37be34f3e6fab2e8ad459f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194343","number":194343,"mergeCommit":{"message":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\" (#194343)\n\n## Summary\r\n\r\nResolves #194339.\r\n\r\nThis PR reverts #188049 as it inadvertently broke pagination of the\r\nenrollment tokens page. This means that #167663 will need to be\r\nre-opened and fixed in a different way.","sha":"283f6e64c9656c97fa37be34f3e6fab2e8ad459f"}}]}] BACKPORT--> Co-authored-by: Jen Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Team:Fleet
Team label for Observability Data Collection Fleet team
When number of enrollment tokens exceed rows per page, the UI does not show the proper amount of available pages.
This regression was possibly introduced by #188049.
The text was updated successfully, but these errors were encountered: