Revert "[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)" #194343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…page elastic#167663 (elastic#188049)" This reverts commit 1f7fdfd.
jen-huang
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @jen-huang |
|
Starting backport for target branches: 8.15, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 30, 2024
…page elastic#167663 (elastic#188049)" (elastic#194343) ## Summary Resolves elastic#194339. This PR reverts elastic#188049 as it inadvertently broke pagination of the enrollment tokens page. This means that elastic#167663 will need to be re-opened and fixed in a different way. (cherry picked from commit 283f6e6)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 30, 2024
…page elastic#167663 (elastic#188049)" (elastic#194343) ## Summary Resolves elastic#194339. This PR reverts elastic#188049 as it inadvertently broke pagination of the enrollment tokens page. This means that elastic#167663 will need to be re-opened and fixed in a different way. (cherry picked from commit 283f6e6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 30, 2024
…empty last page #167663 (#188049)" (#194343) (#194480) # Backport This will backport the following commits from `main` to `8.x`: - [Revert "[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)" (#194343)](#194343) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jen Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-30T19:35:13Z","message":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\" (#194343)\n\n## Summary\r\n\r\nResolves #194339.\r\n\r\nThis PR reverts #188049 as it inadvertently broke pagination of the\r\nenrollment tokens page. This means that #167663 will need to be\r\nre-opened and fixed in a different way.","sha":"283f6e64c9656c97fa37be34f3e6fab2e8ad459f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-major"],"title":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\"","number":194343,"url":"https://github.com/elastic/kibana/pull/194343","mergeCommit":{"message":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\" (#194343)\n\n## Summary\r\n\r\nResolves #194339.\r\n\r\nThis PR reverts #188049 as it inadvertently broke pagination of the\r\nenrollment tokens page. This means that #167663 will need to be\r\nre-opened and fixed in a different way.","sha":"283f6e64c9656c97fa37be34f3e6fab2e8ad459f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194343","number":194343,"mergeCommit":{"message":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\" (#194343)\n\n## Summary\r\n\r\nResolves #194339.\r\n\r\nThis PR reverts #188049 as it inadvertently broke pagination of the\r\nenrollment tokens page. This means that #167663 will need to be\r\nre-opened and fixed in a different way.","sha":"283f6e64c9656c97fa37be34f3e6fab2e8ad459f"}}]}] BACKPORT--> Co-authored-by: Jen Huang <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Sep 30, 2024
… empty last page #167663 (#188049)" (#194343) (#194479) # Backport This will backport the following commits from `main` to `8.15`: - [Revert "[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)" (#194343)](#194343) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jen Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-30T19:35:13Z","message":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\" (#194343)\n\n## Summary\r\n\r\nResolves #194339.\r\n\r\nThis PR reverts #188049 as it inadvertently broke pagination of the\r\nenrollment tokens page. This means that #167663 will need to be\r\nre-opened and fixed in a different way.","sha":"283f6e64c9656c97fa37be34f3e6fab2e8ad459f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-major"],"title":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\"","number":194343,"url":"https://github.com/elastic/kibana/pull/194343","mergeCommit":{"message":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\" (#194343)\n\n## Summary\r\n\r\nResolves #194339.\r\n\r\nThis PR reverts #188049 as it inadvertently broke pagination of the\r\nenrollment tokens page. This means that #167663 will need to be\r\nre-opened and fixed in a different way.","sha":"283f6e64c9656c97fa37be34f3e6fab2e8ad459f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194343","number":194343,"mergeCommit":{"message":"Revert \"[Fleet][Cloud] Enrollment token table may show an empty last page #167663 (#188049)\" (#194343)\n\n## Summary\r\n\r\nResolves #194339.\r\n\r\nThis PR reverts #188049 as it inadvertently broke pagination of the\r\nenrollment tokens page. This means that #167663 will need to be\r\nre-opened and fixed in a different way.","sha":"283f6e64c9656c97fa37be34f3e6fab2e8ad459f"}}]}] BACKPORT--> Co-authored-by: Jen Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #194339.
This PR reverts #188049 as it inadvertently broke pagination of the enrollment tokens page. This means that #167663 will need to be re-opened and fixed in a different way.