[Index lifecycle management] Add deprecated policy warnings

[sabarasaba]

Partially addresses #170805

Summary

With elastic/elasticsearch#101148 we now can alert the users when an ILM policy will soon be deprecated and shouldnt be relied upon. This PR adds a badge and a callout to the ILM UI to alert the users about this.

How to test

• Start up kibana and es
• Create a deprecated policy using devtools
• Navigate to Stack management -> ILM
• Verify that:
  • Deprecated policies are hidden by default
  • Upon enabling filtering to see them they should pop up on the table with a badge
  • Verify that deprecated policies are highlighted and when editing, we also show a warning callout.

Create deprecated policy

PUT _ilm/policy/my_policy
{
  "policy": {
      "deprecated": true,
    "_meta": {
      "description": "used for nginx log",
      "project": {
        "name": "myProject",
        "department": "myDepartment"
      }
    },
    "phases": {
      "warm": {
        "min_age": "10d",
        "actions": {
          "forcemerge": {
            "max_num_segments": 1
          }
        }
      },
      "delete": {
        "min_age": "30d",
        "actions": {
          "delete": {}
        }
      }
    }
  }
}

Screenshots

[sabarasaba]

/ci

[sabarasaba]

@elasticmachine merge upstream

[sabarasaba]

/ci

[florent-leborgne]

Suggesting to tweak a little the message description to:

• not repeat the title
• be slightly more explicit about what this deprecation means (the policy might/will be removed eventually, which is different than just stay without being maintained)
• say what should a user using it do?

[elasticmachine]

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

[alisonelizabeth]

Thanks for working on this @sabarasaba! I just took a look at your screenshots and read some more of the background. I noticed this comment in this ES issue:

We could hide deprecated component templates by default and issue a deprecation warning when using a deprecated component template.

What do you think about doing something like this (ie, hide the deprecated policies by default behind a toggle or something)? While I think the "Deprecated" badge is helpful, it does still seem potentially confusing to see both 30-days-default and 30-days@lifecycle show up in the list by default.

---

On another note, I'm wondering if we should reconsider showing the error banner "Editing a managed policy can break Kibana", especially with the comments on #172683. This is outside the scope of your PR, just something I noticed while reviewing the screenshots 😄

[ElenaStoeva]

Thanks for working on this @sabarasaba! Tested locally and code changes LGTM 👍

I only have a question on the index template changes as I was wondering why they are needed.

Edit: Sorry, I just noticed that @alisonelizabeth added some good suggestions. I will review again if further changes are made.

[sabarasaba]

@elasticmachine merge upstream

[sabarasaba]

@elasticmachine merge upstream

[sabarasaba]

Thanks for the review @ElenaStoeva and @alisonelizabeth! I've updated the PR to have the deprecated polcies hidden by default and with a table filter we can toggle them on/off, so things seem a little bit tidier now.

On another note, I'm wondering if we should reconsider showing the error banner "Editing a managed policy can break Kibana", especially with the comments on #172683. This is outside the scope of your PR, just something I noticed while reviewing the screenshots 😄

Yeah I think we should think about that a bit more, I've created a separate issue for dealing with that #174579

[sabarasaba]

@elasticmachine merge upstream

[ElenaStoeva]

nit: I'm wondering if it would be a good idea to expect the length to be greater than 0 rather than exactly 10 (so that we future proof the test in case some managed policies are added/removed in the test environment)?

Also nit, could we test that actually clicking the "Deprecated" button shows the deprecated policies?

[sabarasaba]

The table filters dont have a property for adding a data-test-subj, so the only way I could find how to test it was by inputting a filter in the search bar!

[ElenaStoeva]

Thanks for updating the PR @sabarasaba. I tested locally again and verified that the deprecated policies are hidden by default and that the "Deprecated" button works correctly. New code changes also LGTM (with a minor comment on the tests). 👍

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: a8e92b6

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
indexLifecycleManagement	144.8KB	146.6KB	+1.7KB

History

• 💚 Build #186785 succeeded a6e61f5
• 💔 Build #186765 failed 213a8c8
• 💔 Build #186628 failed 0f78d63
• 💔 Build #186613 failed 174f4b8
• 💔 Build #186564 failed e9f14bc
• 💚 Build #186325 succeeded 203e9af

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba