Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the 'deprecated' flag to ILM policies, component templates, index templates, and pipelines #170805

Closed
dakrone opened this issue Nov 7, 2023 · 3 comments
Assignees
Labels
enhancement New value added to drive a business result Feature:ILM Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@dakrone
Copy link
Member

dakrone commented Nov 7, 2023

Describe the feature:
In elastic/elasticsearch#101148 support was added to ILM policies, component templates, index templates, and pipelines for the deprecated flag. This flag signifies that the item should not be relied upon or used if possible. We should expose this feature in the UI when visualizing these items, as well as optionally add a warning if a user creates a new index template that uses a deprecated pipeline or component template (Elasticsearch itself will already do this through deprecation logging.)

Describe a specific use case for the feature:
We needed a way for ES to signal that some items that are installed may not be installed in the future, starting the deprecation clock so they can be eventually removed.

@dakrone dakrone added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Nov 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@felixbarny
Copy link
Member

I think we should also discourage users from editing deprecated assets, for example by requiring an additional confirmation step. Once we have that, we should also do the same with assets that have a managed: true flag as these may be overridden by another component such as Fleet or Elasticsearch at any time.

@sabarasaba sabarasaba self-assigned this Dec 20, 2023
yuliacech added a commit that referenced this issue Feb 5, 2024
Partially addresses #170805

## Summary

With elastic/elasticsearch#101148 we now can
alert the users when an ingest pipeline will soon be deprecated and
shouldnt be relied upon. This PR adds a badge and a callout to the
ingest pipelines UI to alert the users about this.

##### How to test

* Start up kibana and es
* Navigate to Stack management -> Ingest pipelines
* Verify that:
  * Deprecated pipelines are hidden by default
* Upon enabling filtering to see them they should pop up on the table
with a badge
* Verify that deprecated policies are highlighted and when editing, we
also show a warning callout.

### Screenshot 
<img width="1386" alt="Screenshot 2024-02-05 at 16 02 18"
src="https://github.com/elastic/kibana/assets/6585477/739d6fea-5f15-4da4-aee8-cae8f412a040">

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Yulia Čech <[email protected]>
Co-authored-by: Yulia Cech <[email protected]>
yuliacech added a commit that referenced this issue Feb 5, 2024
…onent template UIs (#174450)

Partially addresses #170805

## Summary

With elastic/elasticsearch#101148 we now can
alert the users when a component template or index template will soon be
deprecated and shouldnt be relied upon. This PR adds a badge and a
callout to the component template and index template UIs to alert the
users about this.

##### How to test

* Start up kibana and es
* Navigate to Stack management -> index management
(component_templates|index_templates)
* Verify that:
  * Deprecated resources are hidden by default
* Upon enabling filtering to see them they should pop up on the table
with a badge
* Verify that deprecated resources are highlighted and when editing, we
also show a warning callout.


<details>
<summary>Create deprecated component template</summary>

```
PUT _component_template/template_1
{
  "template": {
    "settings" : {
        "number_of_shards" : 1
    }    
  },
  "deprecated": true
}
```
</details>

<details>
<summary>Screenshots</summary>

// index templates

![Screenshot 2024-01-10 at 15 25
26](https://github.com/elastic/kibana/assets/1191206/ff632464-c4ac-43a2-b89d-be423489a82a)
![Screenshot 2024-01-10 at 15 25
31](https://github.com/elastic/kibana/assets/1191206/bb231c7c-5ae3-466d-9411-3cca842124dc)

![Screenshot 2024-01-08 at 13 52
35](https://github.com/elastic/kibana/assets/1191206/c6724867-3a0e-4998-871b-35fd577689bc)
![Screenshot 2024-01-08 at 14 00
46](https://github.com/elastic/kibana/assets/1191206/0b1001d4-c0bb-49a8-862a-746754e34fe0)

// component templates


![Screenshot 2024-01-10 at 14 45
10](https://github.com/elastic/kibana/assets/1191206/675519b8-80d7-466a-a4ad-185bb7f52651)
![Screenshot 2024-01-10 at 14 45
15](https://github.com/elastic/kibana/assets/1191206/0cbe5704-8549-4812-9202-e44b8f02ac95)
![Screenshot 2024-01-08 at 14 51
03](https://github.com/elastic/kibana/assets/1191206/0288ca12-c8f5-4ed5-ba4c-f77834702e68)
![Screenshot 2024-01-08 at 15 07
17](https://github.com/elastic/kibana/assets/1191206/97f72f52-6816-4bc9-910c-fbe88df50ad2)



</details>

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Yulia Čech <[email protected]>
Co-authored-by: Yulia Cech <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this issue Feb 7, 2024
Partially addresses elastic#170805

## Summary

With elastic/elasticsearch#101148 we now can
alert the users when an ingest pipeline will soon be deprecated and
shouldnt be relied upon. This PR adds a badge and a callout to the
ingest pipelines UI to alert the users about this.

##### How to test

* Start up kibana and es
* Navigate to Stack management -> Ingest pipelines
* Verify that:
  * Deprecated pipelines are hidden by default
* Upon enabling filtering to see them they should pop up on the table
with a badge
* Verify that deprecated policies are highlighted and when editing, we
also show a warning callout.

### Screenshot 
<img width="1386" alt="Screenshot 2024-02-05 at 16 02 18"
src="https://github.com/elastic/kibana/assets/6585477/739d6fea-5f15-4da4-aee8-cae8f412a040">

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Yulia Čech <[email protected]>
Co-authored-by: Yulia Cech <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this issue Feb 7, 2024
…onent template UIs (elastic#174450)

Partially addresses elastic#170805

## Summary

With elastic/elasticsearch#101148 we now can
alert the users when a component template or index template will soon be
deprecated and shouldnt be relied upon. This PR adds a badge and a
callout to the component template and index template UIs to alert the
users about this.

##### How to test

* Start up kibana and es
* Navigate to Stack management -> index management
(component_templates|index_templates)
* Verify that:
  * Deprecated resources are hidden by default
* Upon enabling filtering to see them they should pop up on the table
with a badge
* Verify that deprecated resources are highlighted and when editing, we
also show a warning callout.


<details>
<summary>Create deprecated component template</summary>

```
PUT _component_template/template_1
{
  "template": {
    "settings" : {
        "number_of_shards" : 1
    }    
  },
  "deprecated": true
}
```
</details>

<details>
<summary>Screenshots</summary>

// index templates

![Screenshot 2024-01-10 at 15 25
26](https://github.com/elastic/kibana/assets/1191206/ff632464-c4ac-43a2-b89d-be423489a82a)
![Screenshot 2024-01-10 at 15 25
31](https://github.com/elastic/kibana/assets/1191206/bb231c7c-5ae3-466d-9411-3cca842124dc)

![Screenshot 2024-01-08 at 13 52
35](https://github.com/elastic/kibana/assets/1191206/c6724867-3a0e-4998-871b-35fd577689bc)
![Screenshot 2024-01-08 at 14 00
46](https://github.com/elastic/kibana/assets/1191206/0b1001d4-c0bb-49a8-862a-746754e34fe0)

// component templates


![Screenshot 2024-01-10 at 14 45
10](https://github.com/elastic/kibana/assets/1191206/675519b8-80d7-466a-a4ad-185bb7f52651)
![Screenshot 2024-01-10 at 14 45
15](https://github.com/elastic/kibana/assets/1191206/0cbe5704-8549-4812-9202-e44b8f02ac95)
![Screenshot 2024-01-08 at 14 51
03](https://github.com/elastic/kibana/assets/1191206/0288ca12-c8f5-4ed5-ba4c-f77834702e68)
![Screenshot 2024-01-08 at 15 07
17](https://github.com/elastic/kibana/assets/1191206/97f72f52-6816-4bc9-910c-fbe88df50ad2)



</details>

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Yulia Čech <[email protected]>
Co-authored-by: Yulia Cech <[email protected]>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
Partially addresses elastic#170805

## Summary

With elastic/elasticsearch#101148 we now can
alert the users when an ingest pipeline will soon be deprecated and
shouldnt be relied upon. This PR adds a badge and a callout to the
ingest pipelines UI to alert the users about this.

##### How to test

* Start up kibana and es
* Navigate to Stack management -> Ingest pipelines
* Verify that:
  * Deprecated pipelines are hidden by default
* Upon enabling filtering to see them they should pop up on the table
with a badge
* Verify that deprecated policies are highlighted and when editing, we
also show a warning callout.

### Screenshot 
<img width="1386" alt="Screenshot 2024-02-05 at 16 02 18"
src="https://github.com/elastic/kibana/assets/6585477/739d6fea-5f15-4da4-aee8-cae8f412a040">

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Yulia Čech <[email protected]>
Co-authored-by: Yulia Cech <[email protected]>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
…onent template UIs (elastic#174450)

Partially addresses elastic#170805

## Summary

With elastic/elasticsearch#101148 we now can
alert the users when a component template or index template will soon be
deprecated and shouldnt be relied upon. This PR adds a badge and a
callout to the component template and index template UIs to alert the
users about this.

##### How to test

* Start up kibana and es
* Navigate to Stack management -> index management
(component_templates|index_templates)
* Verify that:
  * Deprecated resources are hidden by default
* Upon enabling filtering to see them they should pop up on the table
with a badge
* Verify that deprecated resources are highlighted and when editing, we
also show a warning callout.


<details>
<summary>Create deprecated component template</summary>

```
PUT _component_template/template_1
{
  "template": {
    "settings" : {
        "number_of_shards" : 1
    }    
  },
  "deprecated": true
}
```
</details>

<details>
<summary>Screenshots</summary>

// index templates

![Screenshot 2024-01-10 at 15 25
26](https://github.com/elastic/kibana/assets/1191206/ff632464-c4ac-43a2-b89d-be423489a82a)
![Screenshot 2024-01-10 at 15 25
31](https://github.com/elastic/kibana/assets/1191206/bb231c7c-5ae3-466d-9411-3cca842124dc)

![Screenshot 2024-01-08 at 13 52
35](https://github.com/elastic/kibana/assets/1191206/c6724867-3a0e-4998-871b-35fd577689bc)
![Screenshot 2024-01-08 at 14 00
46](https://github.com/elastic/kibana/assets/1191206/0b1001d4-c0bb-49a8-862a-746754e34fe0)

// component templates


![Screenshot 2024-01-10 at 14 45
10](https://github.com/elastic/kibana/assets/1191206/675519b8-80d7-466a-a4ad-185bb7f52651)
![Screenshot 2024-01-10 at 14 45
15](https://github.com/elastic/kibana/assets/1191206/0cbe5704-8549-4812-9202-e44b8f02ac95)
![Screenshot 2024-01-08 at 14 51
03](https://github.com/elastic/kibana/assets/1191206/0288ca12-c8f5-4ed5-ba4c-f77834702e68)
![Screenshot 2024-01-08 at 15 07
17](https://github.com/elastic/kibana/assets/1191206/97f72f52-6816-4bc9-910c-fbe88df50ad2)



</details>

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Yulia Čech <[email protected]>
Co-authored-by: Yulia Cech <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
Partially addresses elastic#170805

## Summary

With elastic/elasticsearch#101148 we now can
alert the users when an ingest pipeline will soon be deprecated and
shouldnt be relied upon. This PR adds a badge and a callout to the
ingest pipelines UI to alert the users about this.

##### How to test

* Start up kibana and es
* Navigate to Stack management -> Ingest pipelines
* Verify that:
  * Deprecated pipelines are hidden by default
* Upon enabling filtering to see them they should pop up on the table
with a badge
* Verify that deprecated policies are highlighted and when editing, we
also show a warning callout.

### Screenshot 
<img width="1386" alt="Screenshot 2024-02-05 at 16 02 18"
src="https://github.com/elastic/kibana/assets/6585477/739d6fea-5f15-4da4-aee8-cae8f412a040">

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Yulia Čech <[email protected]>
Co-authored-by: Yulia Cech <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
…onent template UIs (elastic#174450)

Partially addresses elastic#170805

## Summary

With elastic/elasticsearch#101148 we now can
alert the users when a component template or index template will soon be
deprecated and shouldnt be relied upon. This PR adds a badge and a
callout to the component template and index template UIs to alert the
users about this.

##### How to test

* Start up kibana and es
* Navigate to Stack management -> index management
(component_templates|index_templates)
* Verify that:
  * Deprecated resources are hidden by default
* Upon enabling filtering to see them they should pop up on the table
with a badge
* Verify that deprecated resources are highlighted and when editing, we
also show a warning callout.


<details>
<summary>Create deprecated component template</summary>

```
PUT _component_template/template_1
{
  "template": {
    "settings" : {
        "number_of_shards" : 1
    }    
  },
  "deprecated": true
}
```
</details>

<details>
<summary>Screenshots</summary>

// index templates

![Screenshot 2024-01-10 at 15 25
26](https://github.com/elastic/kibana/assets/1191206/ff632464-c4ac-43a2-b89d-be423489a82a)
![Screenshot 2024-01-10 at 15 25
31](https://github.com/elastic/kibana/assets/1191206/bb231c7c-5ae3-466d-9411-3cca842124dc)

![Screenshot 2024-01-08 at 13 52
35](https://github.com/elastic/kibana/assets/1191206/c6724867-3a0e-4998-871b-35fd577689bc)
![Screenshot 2024-01-08 at 14 00
46](https://github.com/elastic/kibana/assets/1191206/0b1001d4-c0bb-49a8-862a-746754e34fe0)

// component templates


![Screenshot 2024-01-10 at 14 45
10](https://github.com/elastic/kibana/assets/1191206/675519b8-80d7-466a-a4ad-185bb7f52651)
![Screenshot 2024-01-10 at 14 45
15](https://github.com/elastic/kibana/assets/1191206/0cbe5704-8549-4812-9202-e44b8f02ac95)
![Screenshot 2024-01-08 at 14 51
03](https://github.com/elastic/kibana/assets/1191206/0288ca12-c8f5-4ed5-ba4c-f77834702e68)
![Screenshot 2024-01-08 at 15 07
17](https://github.com/elastic/kibana/assets/1191206/97f72f52-6816-4bc9-910c-fbe88df50ad2)



</details>

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Yulia Čech <[email protected]>
Co-authored-by: Yulia Cech <[email protected]>
@yuliacech
Copy link
Contributor

Closing as completed via #174150, #174450, #174814

@sophiec20 sophiec20 added enhancement New value added to drive a business result and removed >enhancement labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:ILM Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

7 participants