[Index lifecycle management] Add deprecated policy warnings

x-pack/plugins/index_lifecycle_management/__jest__/policy_table.test.tsx

@@ -43,6 +43,7 @@ const testPolicy = {
 
 const isUsedByAnIndex = (i: number) => i % 2 === 0;
 const isDesignatedManagedPolicy = (i: number) => i > 0 && i % 3 === 0;
+const isDeprecatedPolicy = (i: number) => i > 0 && i % 2 === 0;
 
 const policies: PolicyFromES[] = [testPolicy];
 for (let i = 1; i < 105; i++) {
@@ -54,6 +55,7 @@ for (let i = 1; i < 105; i++) {
     name: `testy${i}`,
     policy: {
       name: `testy${i}`,
+      deprecated: i % 2 === 0,
       phases: {},
       ...(isDesignatedManagedPolicy(i)
         ? {
@@ -96,6 +98,7 @@ const getPolicies = (rendered: ReactWrapper) => {
       version,
       name,
       isManagedPolicy: isDesignatedManagedPolicy(version),
+      isDeprecatedPolicy: isDeprecatedPolicy(version),
       isUsedByAnIndex: isUsedByAnIndex(version),
     };
   });
@@ -198,6 +201,22 @@ describe('policy table', () => {
     });
   });
 
+  test('shows deprecated policies with Deprecated badges', () => {
+    const rendered = mountWithIntl(component);
+    const visiblePolicies = getPolicies(rendered);
+
+    visiblePolicies.forEach((p) => {
+      const policyRow = findTestSubject(rendered, `policyTableRow-${p.name}`);
+      const deprecatedBadge = findTestSubject(policyRow, 'deprecatedPolicyBadge');
+
+      if (p.isDeprecatedPolicy) {
+        expect(deprecatedBadge.exists()).toBeTruthy();
+      } else {
+        expect(deprecatedBadge.exists()).toBeFalsy();
+      }
+    });
+  });
+
   test('filters based on content of search input', () => {
     const rendered = mountWithIntl(component);
     const searchInput = rendered.find('.euiFieldSearch').first();

x-pack/plugins/index_lifecycle_management/common/types/policies.ts

@@ -18,6 +18,7 @@ export type PhaseWithDownsample = 'hot' | 'warm' | 'cold';
 export interface SerializedPolicy {
   name: string;
   phases: Phases;
+  deprecated?: boolean;
   _meta?: Record<string, any>;
 }
 

x-pack/plugins/index_lifecycle_management/integration_tests/edit_policy/constants.ts

@@ -226,6 +226,7 @@ export const POLICY_MANAGED_BY_ES: PolicyFromES = {
   modifiedDate: Date.now().toString(),
   policy: {
     name: POLICY_NAME,
+    deprecated: true,
     phases: {
       hot: {
         min_age: '0ms',

x-pack/plugins/index_lifecycle_management/integration_tests/edit_policy/features/edit_warning.test.ts

@@ -67,6 +67,19 @@ describe('<EditPolicy /> edit warning', () => {
     expect(exists('editManagedPolicyCallOut')).toBe(true);
   });
 
+  test('an edit warning callout is shown for a deprecated policy', async () => {
+    httpRequestsMockHelpers.setLoadPolicies([POLICY_MANAGED_BY_ES]);
+
+    await act(async () => {
+      testBed = await initTestBed(httpSetup);
+    });
+    const { exists, component } = testBed;
+    component.update();
+
+    expect(exists('editWarning')).toBe(true);
+    expect(exists('editPolicyWithDeprecation')).toBe(true);
+  });
+
   test('no indices link if no indices', async () => {
     httpRequestsMockHelpers.setLoadPolicies([
       { ...getDefaultHotPhasePolicy(POLICY_NAME), indices: [] },

x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/edit_warning.tsx

@@ -68,6 +68,7 @@ export const EditWarning: FunctionComponent = () => {
     indexTemplatesLink
   );
   const isManagedPolicy = policy?._meta?.managed;
+  const isDeprecatedPolicy = policy?.deprecated;
 
   return (
     <>
@@ -102,6 +103,30 @@ export const EditWarning: FunctionComponent = () => {
             <EuiSpacer />
           </>
         )}
+        {isDeprecatedPolicy && (
+          <>
+            <EuiCallOut
+              title={
+                <FormattedMessage
+                  id="xpack.indexLifecycleMgmt.editPolicyModal.deprecatedPolicyTitle"
+                  defaultMessage="This policy is deprecated"
+                />
+              }
+              color="warning"
+              iconType="warning"
+              data-test-subj="editPolicyWithDeprecation"
+            >
+              <p>
+                <FormattedMessage
+                  id="xpack.indexLifecycleMgmt.editPolicyModal.deprecatedPolicyDescription"
+                  defaultMessage="This policy is deprecated and should not be relied on."
+                />
+              </p>
+            </EuiCallOut>
+            <EuiSpacer />
+          </>
+        )}
+
         <p>
           <strong>
             <FormattedMessage

x-pack/plugins/index_lifecycle_management/public/application/sections/policy_list/components/policy_table.tsx

@@ -69,6 +69,18 @@ const managedPolicyTooltips = {
   ),
 };
 
+const deprecatedPolicyTooltips = {
+  badge: i18n.translate('xpack.indexLifecycleMgmt.policyTable.templateBadgeType.deprecatedLabel', {
+    defaultMessage: 'Deprecated',
+  }),
+  badgeTooltip: i18n.translate(
+    'xpack.indexLifecycleMgmt.policyTable.templateBadgeType.deprecatedDescription',
+    {
+      defaultMessage: 'This policy is deprecated and should not be relied on.',
+    }
+  ),
+};
+
 interface Props {
   policies: PolicyFromES[];
 }
@@ -124,6 +136,8 @@ export const PolicyTable: React.FunctionComponent<Props> = ({ policies }) => {
       sortable: true,
       render: (value: string, item) => {
         const isManaged = item.policy?._meta?.managed;
+        const isDeprecated = item.policy?.deprecated;
+
         return (
           <>
             <EuiLink
@@ -136,6 +150,17 @@ export const PolicyTable: React.FunctionComponent<Props> = ({ policies }) => {
               {value}
             </EuiLink>
 
+            {isDeprecated && (
+              <>
+                &nbsp;
+                <EuiToolTip content={deprecatedPolicyTooltips.badgeTooltip}>
+                  <EuiBadge color="warning" data-test-subj="deprecatedPolicyBadge">
+                    {deprecatedPolicyTooltips.badge}
+                  </EuiBadge>
+                </EuiToolTip>
+              </>
+            )}
+
             {isManaged && (
               <>
                 &nbsp;

x-pack/plugins/index_management/common/lib/template_serialization.ts

@@ -54,6 +54,7 @@ export function deserializeTemplate(
     composed_of: composedOf,
     data_stream: dataStream,
     allow_auto_create: allowAutoCreate,
+    deprecated,
   } = templateEs;
   const { settings } = template;
 
@@ -77,6 +78,7 @@ export function deserializeTemplate(
     composedOf: composedOf ?? [],
     dataStream,
     allowAutoCreate,
+    deprecated,
     _meta,
     _kbnMeta: {
       type,

x-pack/plugins/index_management/common/types/templates.ts

@@ -27,6 +27,7 @@ export interface TemplateSerialized {
   _meta?: { [key: string]: any };
   data_stream?: {};
   allow_auto_create?: boolean;
+  deprecated?: boolean;
 }
 
 /**
@@ -42,6 +43,7 @@ export interface TemplateDeserialized {
     aliases?: Aliases;
     mappings?: Mappings;
   };
+  deprecated?: boolean;
   lifecycle?: DataRetention;
   composedOf?: string[]; // Composable template only
   version?: number;