[Fleet] Fix secrets with dot.separated variable names #173115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kpollich
added
release_note:fix
Team:Fleet
|
@elasticmachine merge upstream |
|
Pinging @elastic/fleet (Team:Fleet) |
|
/ci |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
Log explorer changes seem totally unrelated, but odd that they failed twice so far. |
1 task
nchaulet
reviewed
Dec 12, 2023
nchaulet
reviewed
Dec 12, 2023
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @kpollich |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 12, 2023
## Summary Closes elastic#173048 Move away from dot-separated secret paths in favor of array-based paths to fix the above bug around dot-separated variable names. ## To test Create an integration policy for the Universal Profiling Agent on v8.12.0 and observe that no errors occur during policy creation. --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit f861857)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 12, 2023
#173234) # Backport This will backport the following commits from `main` to `8.12`: - [[Fleet] Fix secrets with dot.separated variable names (#173115)](#173115) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kyle Pollich","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-12T22:23:59Z","message":"[Fleet] Fix secrets with dot.separated variable names (#173115)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/173048\r\n\r\nMove away from dot-separated secret paths in favor of array-based paths\r\nto fix the above bug around dot-separated variable names.\r\n\r\n## To test\r\n\r\nCreate an integration policy for the Universal Profiling Agent on\r\nv8.12.0 and observe that no errors occur during policy creation.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"f861857672c2611a0702e659815af03816e9638d","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","backport:prev-minor","v8.13.0"],"number":173115,"url":"https://github.com/elastic/kibana/pull/173115","mergeCommit":{"message":"[Fleet] Fix secrets with dot.separated variable names (#173115)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/173048\r\n\r\nMove away from dot-separated secret paths in favor of array-based paths\r\nto fix the above bug around dot-separated variable names.\r\n\r\n## To test\r\n\r\nCreate an integration policy for the Universal Profiling Agent on\r\nv8.12.0 and observe that no errors occur during policy creation.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"f861857672c2611a0702e659815af03816e9638d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173115","number":173115,"mergeCommit":{"message":"[Fleet] Fix secrets with dot.separated variable names (#173115)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/173048\r\n\r\nMove away from dot-separated secret paths in favor of array-based paths\r\nto fix the above bug around dot-separated variable names.\r\n\r\n## To test\r\n\r\nCreate an integration policy for the Universal Profiling Agent on\r\nv8.12.0 and observe that no errors occur during policy creation.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"f861857672c2611a0702e659815af03816e9638d"}}]}] BACKPORT--> Co-authored-by: Kyle Pollich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #173048
Move away from dot-separated secret paths in favor of array-based paths to fix the above bug around dot-separated variable names.
To test
Create an integration policy for the Universal Profiling Agent on v8.12.0 and observe that no errors occur during policy creation.