Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.12] [Fleet] Fix secrets with dot.separated variable names (#173115) #173234

Merged
merged 1 commit into from
Dec 12, 2023
Merged

[8.12] [Fleet] Fix secrets with dot.separated variable names (#173115) #173234

merged 1 commit into from
Dec 12, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.12:

Questions ?

Please refer to the Backport tool documentation

@kpollich
[Fleet] Fix secrets with dot.separated variable names (elastic#173115)
c265f0b 
## Summary

Closes elastic#173048

Move away from dot-separated secret paths in favor of array-based paths
to fix the above bug around dot-separated variable names.

## To test

Create an integration policy for the Universal Profiling Agent on
v8.12.0 and observe that no errors occur during policy creation.

---------

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit f861857)
@kibanamachine kibanamachine enabled auto-merge (squash) December 12, 2023 22:29
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 12, 2023
@kibanamachine kibanamachine mentioned this pull request Dec 12, 2023
Merged
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Detection Engine - Security Solution Cypress Tests #6 / Detection ES|QL rules, creation ES|QL query validation shows error when non-aggregating ES|QL query does not return _id field shows error when non-aggregating ES|QL query does not return _id field

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kibanamachine kibanamachine merged commit 868bb2f into elastic:8.12 Dec 12, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@kpollich kpollich

Labels
backport Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kibanamachine @elasticmachine @kibana-ci @kpollich