Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix secrets with dot.separated variable names #173115

Merged
merged 9 commits into from
Dec 12, 2023
Merged

[Fleet] Fix secrets with dot.separated variable names #173115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
67ce141
Add tests around dot notated secrets variables
kpollich Dec 11, 2023
fcd19d8
Refactor to array-based paths
kpollich Dec 12, 2023
18c5c3b
Merge branch 'main' into fleet/173048-dot-notation-secret-var-names
kibanamachine Dec 12, 2023
9d7d066
Remove commented out code
kpollich Dec 12, 2023
5660b91
Merge branch 'main' into fleet/173048-dot-notation-secret-var-names
kibanamachine Dec 12, 2023
e7ccaf6
Merge branch 'main' into fleet/173048-dot-notation-secret-var-names
kibanamachine Dec 12, 2023
298b9bb
PR feedback
kpollich Dec 12, 2023
17b8173
Remove unneeded return
kpollich Dec 12, 2023
2ed16ac
Merge branch 'main' into fleet/173048-dot-notation-secret-var-names
kibanamachine Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/fleet/common/types/models/secret.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export interface VarSecretReference {
isSecretRef: true;
}
export interface SecretPath {
path: string;
path: string[];
value: PackagePolicyConfigRecordEntry;
}
export interface OutputSecretPath {
Expand Down
Loading
Loading