[Discover] Update filtering icons

[andreadelrio]

Summary

This PR updates the filter icons in Discover to use EUI's new FilterInclude and FilterExclude. Closes #146802

Changes include:

• Data grid

• Legacy document table

• Expanded document flyout

• Unified field list popover

• Field Stats

• I also updated one icon in the Unified field list popover from plusInCircle to plusInCircleFilled for consistency. "Add field as column" usually uses plusInCircleFilled.

Field list popover

Expanded document

Data grid

Field stats

Legacy table

Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials

• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
  - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[jughosta]

LGTM 👍
Thanks for updating it, @andreadelrio !

[peteharverson]

@andreadelrio in ML we use the plusInCircle and minusInCircle in few places in the Anomaly Explorer and Single Metric Viewer. Is it worth switching the icons in those views too?

The files that would need editing I think are:

ml/public/application/explorer/explorer_charts/components/explorer_chart_label/entity_filter/entity_filter.tsx
ml/public/application/components/entity_cell/entity_cell.tsx
ml/public/application/components/anomalies_table/influencers_cell.js

[andreadelrio]

@andreadelrio in ML we use the plusInCircle and minusInCircle in few places in the Anomaly Explorer and Single Metric Viewer. Is it worth switching the icons in those views too?

@peteharverson Great idea, I've updated those files.

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: f94a93c

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
dataVisualizer	533.3KB	533.3KB	+1.0B
discover	418.4KB	418.4KB	+4.0B
ml	3.4MB	3.4MB	+3.0B
unifiedFieldList	38.1KB	38.1KB	+2.0B
total			+10.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
unifiedFieldList	23.7KB	23.7KB	+6.0B

Unknown metric groups

ESLint disabled in files

id	before	after	diff
osquery	1	2	+1

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	19	21	+2
fleet	61	67	+6
osquery	109	115	+6
securitySolution	439	445	+6
total			+20

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	20	22	+2
fleet	70	76	+6
osquery	110	117	+7
securitySolution	516	522	+6
total			+21

History

• 💚 Build #95574 succeeded 53cb1ba
• 💚 Build #95512 succeeded c6b9945

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[peteharverson]

The code changes here for ML look good, but I wonder if the icons are ok from an accessibility viewpoint? The plus / minus in the new designs are very small.

Previous design:

And inside the field popover in Discover for example we don't have a tooltip on the icons which would help clarify the actions.

[ninoslavmiskovic]

@peteharverson We have checked them towards accessibility. Maybe @MichaelMarcialis and @andreadelrio can add a comment on how we did it. 👍

[peteharverson]

Thanks for the confirmation on accessibility @ninoslavmiskovic . Would be interested to know how the checks were done @MichaelMarcialis @andreadelrio, but don't want to hold this up so LGTM for ML.

[sophiec20]

When analysing large datasets, it's common to view at higher data density, such as using chrome magnification at 80%. These icons feel too small and not an improvement.

[andreadelrio]

@peteharverson We have checked them towards accessibility. Maybe @MichaelMarcialis and @andreadelrio can add a comment on how we did it. 👍

@MichaelMarcialis would have more context as to accessibility. I seem to remember we discussed making the icons bigger. Let's wait til he's back from PTO to continue this conversation.

[mark39107pro]

can i fix the issue in discover grid

[mark39107pro]

can i fix the issue

[MichaelMarcialis]

@MichaelMarcialis would have more context as to accessibility. I seem to remember we discussed making the icons bigger. Let's wait til he's back from PTO to continue this conversation.

Hey, gang! For some quick history, the issue that @ninoslavmiskovic, @andreadelrio, and myself tried to address here was our current over-use of the plus icons in our interfaces. As you can even see in the previous design screenshot shown above, the plus icon is used in the Discover field popover for two very different actions. Similar plus icon overuse exists in other areas of Kibana as well. To address that, we ultimately decided that making the include/exclude filter icons more obviously related to filtering would be the best way forward. After testing a number of icon variations and seeing how identifiable they were when scaled down, we selected the ones you see here (which were subsequently added to EUI).

All that said, if there are concerns about the icons we landed on here, I'd be happy to chat about it further or make adjustments as needed. Just let us know!