Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Update filtering icons #147724

Closed
wants to merge 7 commits into from
Closed

[Discover] Update filtering icons #147724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0c9988c
updating filters in Discover
andreadelrio Dec 16, 2022
26f2890
Merge remote-tracking branch 'upstream/main' into dsc-filterIcons
andreadelrio Dec 16, 2022
647d36f
update dv filter icons
andreadelrio Dec 16, 2022
c6b9945
update tests
andreadelrio Dec 16, 2022
53cb1ba
Merge branch 'main' into dsc-filterIcons
jughosta Dec 19, 2022
9eda6f5
Merge branch 'main' into dsc-filterIcons
andreadelrio Dec 19, 2022
f94a93c
more ML updates
andreadelrio Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/plugins/discover/public/components/discover_grid/discover_grid_cell_actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const FilterInBtn = ({
onClick={() => {
onFilterCell(context, rowIndex, columnId, '+');
}}
iconType="plusInCircle"
iconType="filterInclude"
aria-label={buttonTitle}
title={buttonTitle}
data-test-subj="filterForButton"
Expand Down Expand Up @@ -74,7 +74,7 @@ export const FilterOutBtn = ({
onClick={() => {
onFilterCell(context, rowIndex, columnId, '-');
}}
iconType="minusInCircle"
iconType="filterExclude"
aria-label={buttonTitle}
title={buttonTitle}
data-test-subj="filterOutButton"
Expand Down
8 changes: 4 additions & 4 deletions ...r/public/components/doc_table/components/table_row/__snapshots__/table_cell.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/plugins/discover/public/components/doc_table/components/table_row/table_cell_actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const TableCellActions = ({ handleFilterFor, handleFilterOut }: TableCell
})}
onClick={handleFilterFor}
>
<EuiIcon type="plusInCircle" size="s" color="primary" />
<EuiIcon type="filterInclude" size="s" color="primary" />
</button>
</EuiToolTip>

Expand All @@ -52,7 +52,7 @@ export const TableCellActions = ({ handleFilterFor, handleFilterOut }: TableCell
})}
onClick={handleFilterOut}
>
<EuiIcon type="minusInCircle" size="s" color="primary" />
<EuiIcon type="filterExclude" size="s" color="primary" />
</button>
</EuiToolTip>
</span>
Expand Down
2 changes: 1 addition & 1 deletion ...public/services/doc_views/components/doc_viewer_table/legacy/table_row_btn_filter_add.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export function DocViewTableRowBtnFilterAdd({ onClick, disabled = false }: Props
data-test-subj="addInclusiveFilterButton"
disabled={disabled}
onClick={onClick}
iconType={'plusInCircle'}
iconType={'filterInclude'}
iconSize={'s'}
/>
</EuiToolTip>
Expand Down
2 changes: 1 addition & 1 deletion ...lic/services/doc_views/components/doc_viewer_table/legacy/table_row_btn_filter_remove.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export function DocViewTableRowBtnFilterRemove({ onClick, disabled = false }: Pr
data-test-subj="removeInclusiveFilterButton"
disabled={disabled}
onClick={onClick}
iconType={'minusInCircle'}
iconType={'filterExclude'}
iconSize={'s'}
/>
</EuiToolTip>
Expand Down
4 changes: 2 additions & 2 deletions ...ins/discover/public/services/doc_views/components/doc_viewer_table/table_cell_actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export const TableActions = ({
name: filterAddLabel,
'aria-label': filterAddAriaLabel,
toolTipContent: filtersPairToolTip,
icon: 'plusInCircle',
icon: 'filterInclude',
disabled: filtersPairDisabled,
'data-test-subj': `addFilterForValueButton-${field}`,
onClick: onClickAction(onFilter.bind({}, fieldMapping, flattenedField, '+')),
Expand All @@ -147,7 +147,7 @@ export const TableActions = ({
name: filterOutLabel,
'aria-label': filterOutAriaLabel,
toolTipContent: filtersPairToolTip,
icon: 'minusInCircle',
icon: 'filterExclude',
disabled: filtersPairDisabled,
onClick: onClickAction(onFilter.bind({}, fieldMapping, flattenedField, '-')),
},
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/unified_field_list/public/components/field_popover/field_popover_header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export const FieldPopoverHeader: React.FC<FieldPopoverHeaderProps> = ({
data-test-subj={`fieldPopoverHeader_addField-${field.name}`}
aria-label={addFieldToWorkspaceTooltip}
{...(buttonAddFieldToWorkspaceProps || {})}
iconType="plusInCircle"
iconType="plusInCircleFilled"
onClick={() => {
closePopover();
onAddFieldToWorkspace(field);
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/unified_field_list/public/components/field_stats/field_top_values_bucket.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ const FieldTopValuesBucket: React.FC<FieldTopValuesBucketProps> = ({
<div>
<EuiButtonIcon
iconSize="s"
iconType="plusInCircle"
iconType="filterInclude"
onClick={() => onAddFilter(field, fieldValue, '+')}
aria-label={i18n.translate(
'unifiedFieldList.fieldStats.filterValueButtonAriaLabel',
Expand All @@ -169,7 +169,7 @@ const FieldTopValuesBucket: React.FC<FieldTopValuesBucketProps> = ({
/>
<EuiButtonIcon
iconSize="s"
iconType="minusInCircle"
iconType="filterExclude"
onClick={() => onAddFilter(field, fieldValue, '-')}
aria-label={i18n.translate(
'unifiedFieldList.fieldStats.filterOutValueButtonAriaLabel',
Expand Down
4 changes: 2 additions & 2 deletions ...ck/plugins/data_visualizer/public/application/common/components/top_values/top_values.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export const TopValues: FC<Props> = ({ stats, fieldFormat, barColor, compressed,
>
<EuiButtonIcon
iconSize="s"
iconType="plusInCircle"
iconType="filterInclude"
onClick={() =>
onAddFilter(
fieldName,
Expand All @@ -164,7 +164,7 @@ export const TopValues: FC<Props> = ({ stats, fieldFormat, barColor, compressed,
/>
<EuiButtonIcon
iconSize="s"
iconType="minusInCircle"
iconType="filterExclude"
onClick={() =>
onAddFilter(
fieldName,
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/ml/public/application/components/anomalies_table/influencers_cell.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export class InfluencersCell extends Component {
'+'
);
})}
iconType="plusInCircle"
iconType="filterInclude"
aria-label={i18n.translate(
'xpack.ml.anomaliesTable.influencersCell.addFilterAriaLabel',
{
Expand All @@ -94,7 +94,7 @@ export class InfluencersCell extends Component {
'-'
);
})}
iconType="minusInCircle"
iconType="filterExclude"
aria-label={i18n.translate(
'xpack.ml.anomaliesTable.influencersCell.removeFilterAriaLabel',
{
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/ml/public/application/components/entity_cell/entity_cell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ function getAddFilter({ entityName, entityValue, filter }: EntityCellProps) {
onClick={blurButtonOnClick(() => {
filter(entityName, entityValue, ENTITY_FIELD_OPERATIONS.ADD);
})}
iconType="plusInCircle"
iconType="filterInclude"
aria-label={i18n.translate('xpack.ml.anomaliesTable.entityCell.addFilterAriaLabel', {
defaultMessage: 'Add filter',
})}
Expand Down Expand Up @@ -74,7 +74,7 @@ function getRemoveFilter({ entityName, entityValue, filter }: EntityCellProps) {
onClick={blurButtonOnClick(() => {
filter(entityName, entityValue, ENTITY_FIELD_OPERATIONS.REMOVE);
})}
iconType="minusInCircle"
iconType="filterExclude"
aria-label={i18n.translate('xpack.ml.anomaliesTable.entityCell.removeFilterAriaLabel', {
defaultMessage: 'Remove filter',
})}
Expand Down
4 changes: 2 additions & 2 deletions .../explorer/explorer_charts/components/explorer_chart_label/entity_filter/entity_filter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export const EntityFilter: FC<EntityFilterProps> = ({
action: ENTITY_FIELD_OPERATIONS.ADD,
});
})}
iconType="plusInCircle"
iconType="filterInclude"
aria-label={i18n.translate('xpack.ml.entityFilter.addFilterAriaLabel', {
defaultMessage: 'Add filter for {influencerFieldName} {influencerFieldValue}',
values: { influencerFieldName, influencerFieldValue },
Expand All @@ -74,7 +74,7 @@ export const EntityFilter: FC<EntityFilterProps> = ({
action: ENTITY_FIELD_OPERATIONS.REMOVE,
});
})}
iconType="minusInCircle"
iconType="filterExclude"
aria-label={i18n.translate('xpack.ml.entityFilter.removeFilterAriaLabel', {
defaultMessage: 'Remove filter for {influencerFieldName} {influencerFieldValue}',
values: { influencerFieldName, influencerFieldValue },
Expand Down