[Discover] Update Include/Exclude Filter Icons

[MichaelMarcialis]

New icons have recently been created for include/exclude filter actions (filterInclude, filterExclude). The purpose for their creation was to more clearly differentiate filter action icons and reduce our current overuse of the plusInCircle/minusInCircle icons throughout Kibana interfaces.

In this particular issue, we'd like to update the Discover apps use of the plus/minus icons for filtering and replace them with these new include/exclude filter icons in the following locations (and any other relevant areas in the app I may have missed here):

• Field popover filter actions
• Table cell filter actions

CCing @ninoslavmiskovic, @andreadelrio.

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[rdner]

Hey @MichaelMarcialis, is it still going to be addressed at some point? I see that the linked PR was closed, although new icons looked good to me.

I personally struggle with this problem every time I use Kibana Discover because the same "plus in the circle" icon is used for two unrelated actions:

My brain refuses to remember that the plus on the right picture is filtering, this is not obvious at all. I would expect any filter-related actions to have a common funnel-like icon like, not the same icon we use for adding a column to the table view.

At least on one occasion an accidental filter by value interfered with my investigation while looking at the logs and led to incorrect results.

[MichaelMarcialis]

Thanks for the feedback, @rdner. We temporarily paused implementation of the new add/remove filter icons in Discover due to some concern over their size. That said, I don't think we plan to abandon the change; just adjust the icons to see if we can account for the aforementioned size concerns.

CCing @ninoslavmiskovic, @kertal, @andreadelrio. Is this something we care to boost in priority? If so, I can take another crack at addressing those concerns. I snuck the updated icons as part of my One Discover context aware mockups to remind folks they exist ;)