-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting] Telemetry for calling legacy routes #111885
[Alerting] Telemetry for calling legacy routes #111885
Conversation
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some nits about the naming.
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
* Telemetry for calling legacy routes * Fix types * Use different counter type * PR feedback * Fix this test too # Conflicts: # x-pack/plugins/alerting/server/routes/legacy/create.ts
* [Alerting] Telemetry for calling legacy routes (#111885) * Telemetry for calling legacy routes * Fix types * Use different counter type * PR feedback * Fix this test too # Conflicts: # x-pack/plugins/alerting/server/routes/legacy/create.ts * Fix missing arg
Resolves #111894
This PR introduces usage counter telemetry for legacy alerting HTTP routes.
I synced with @Bamieh and he mentioned this is a good use for usage counters. I'd imagine we have some existing dashboards already charting these data points, but if not, easy to add.
@Bamieh also mentioned we should add a consistent
counter_type
to perform group aggregations across all data points, so I added it and it's set tolegacy_api_usage
for now. This isn't used anywhere else, but we could prefixalerting_
to ensure we don't conflict in the future if we want.To test, visit any legacy alerting HTTP url and then check telemetry stats (via https://localhost:5601/api/stats?extended):