Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Actions] Telemetry for calling legacy routes #111901

Merged
merged 3 commits into from
Sep 13, 2021
Merged

[Actions] Telemetry for calling legacy routes #111901

merged 3 commits into from
Sep 13, 2021

Conversation

chrisronline
Copy link
Contributor

Resolves #111896

See more details in #111885. This is the exact same implementation but for actions.

@chrisronline chrisronline added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.16.0 Feature:Actions/Framework Issues related to the Actions Framework labels Sep 10, 2021
@chrisronline chrisronline requested a review from a team as a code owner September 10, 2021 20:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

YulNaumenko
YulNaumenko reviewed Sep 10, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Is there any an example how to request the telemetry to get this legacy API info? Found it here #111885

ymao1
ymao1 approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one comment about naming

x-pack/plugins/actions/server/lib/track_legacy_route_usage.ts Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
actions 123 124 +1
Unknown metric groups

API count

id before after diff
actions 123 124 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit 74d87db into elastic:master Sep 13, 2021
@chrisronline chrisronline deleted the actions/legacy_telemetry branch September 13, 2021 16:56
@chrisronline chrisronline mentioned this pull request Sep 13, 2021
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request Sep 13, 2021
@chrisronline
[Actions] Telemetry for calling legacy routes (elastic#111901)
97c2a77 
* Telemetry for legacy http api routes

* PR feedback
chrisronline added a commit that referenced this pull request Sep 13, 2021
@chrisronline
[Actions] Telemetry for calling legacy routes (#111901) (#111992)
731e0c9 
* Telemetry for legacy http api routes

* PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@ymao1 ymao1 ymao1 approved these changes

Assignees
No one assigned
Labels
Feature:Actions/Framework Issues related to the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Actions] Add telemetry for legacy HTTP API usage
5 participants
@chrisronline @elasticmachine @kibanamachine @ymao1 @YulNaumenko