Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Response Ops] Add deprecated telemetry for _mute_all #130458

Merged
merged 1 commit into from
Apr 18, 2022
Merged

[Response Ops] Add deprecated telemetry for _mute_all #130458

merged 1 commit into from
Apr 18, 2022

Conversation

chrisronline
Copy link
Contributor

Resolves #126817

Similar to #111885, this PR introduces telemetry for deprecated endpoints, specifically rule/{id}/_mute_all

To test, visit the above url and then check telemetry stats (via https://localhost:5601/api/stats?extended):

"usage_counters": {
  "daily_events": [
    {
      "domain_id": "alerts",
      "counter_name": "deprecatedRoute_muteAll",
      "counter_type": "deprecatedApiUsage",
      "last_updated_at": "2022-04-18T14:30:20.278Z",
      "from_timestamp": "2022-04-18T00:00:00Z",
      "total": 1
    }
  ]

@chrisronline chrisronline added review release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.3.0 labels Apr 18, 2022
@chrisronline chrisronline self-assigned this Apr 18, 2022
@chrisronline chrisronline requested a review from a team as a code owner April 18, 2022 14:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @chrisronline

@XavierM XavierM requested a review from Zacqary April 18, 2022 16:08
Zacqary
Zacqary approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@Zacqary Zacqary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisronline chrisronline merged commit 21f8999 into elastic:main Apr 18, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 18, 2022
@chrisronline chrisronline deleted the rops/deprecated_telemetry branch April 18, 2022 19:04
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 19, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/soft-…
9a657f4 
…disable-server-side

* 'main' of github.com:elastic/kibana: (103 commits)
  [Osquery] Update eslint config (elastic#129637)
  [Uptime] Update monitor saved object mappings (elastic#130433)
  Add links to metricbeat module docs (elastic#130519)
  Add link to troubleshooting guide in confirm data copy (elastic#130420)
  [Step 3] Cleanup charts plugin (elastic#130132)
  [Visualize] Adds a deprecation warning to the pie app (elastic#130447)
  [Maps] fix vector tile load errors not displayed in legend (elastic#130395)
  [CI] Split alerting-api-integration tests into separate cigroups (elastic#130414)
  [CI] Use spot instances for default cigroups in PR CI (elastic#130476)
  [functional-tests] TimePicker optimizations (elastic#130200)
  [kbn/pm] use stable module ids in dist (elastic#130497)
  [8.2.1][Security Solution][Session view] fix full screen session view margin (elastic#130496)
  Fix wrong config in comments (elastic#130378)
  Add deprecated telemetry (elastic#130458)
  Add eslint rule to support breaking up packages (elastic#130483)
  [Security Solution][Endpoint] Fix test stability and un-skip flaky tests (elastic#130176)
  Update object types for SharePoint Online external connector (elastic#130478)
  [Workplace Search] Fix broken feedback link (elastic#130475)
  Rename the term "execution" in config to "run" (elastic#130172)
  [Cloud Posture] use index with keyword mapping (elastic#130456)
  ...

# Conflicts:
#	docs/user/reporting/index.asciidoc
#	x-pack/plugins/reporting/public/types.ts
#	x-pack/plugins/screenshotting/server/screenshots/index.test.ts
#	x-pack/plugins/screenshotting/server/screenshots/index.ts
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@kertal
Add deprecated telemetry (elastic#130458)
6361619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zacqary Zacqary Zacqary approved these changes

Assignees

@chrisronline chrisronline

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes review Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RAM] Add telemetry around the use of the _mute_all API
5 participants
@chrisronline @elasticmachine @kibana-ci @Zacqary @kibanamachine