[Reporting] Remove "download CSV" export type functionality #199033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
release_note:breaking
backport:skip
tsullivan
force-pushed
the
reporting/remove-csv-download
branch
from
fda0fdc to
2f2c345
Compare
tsullivan
force-pushed
the
reporting/remove-csv-download
branch
from
2f2c345 to
cc93355
Compare
💔 Build Failed
Failed CI StepsHistory
|
sebelga
approved these changes
Nov 6, 2024
mgadewoll
pushed a commit
to mgadewoll/kibana
that referenced
this pull request
Nov 7, 2024
…199033) ## Summary Closes elastic/kibana-team#1202 This PR removes the CSV Download feature, and API from Kibana. Any logic that is based on the `xpack.reporting.csv.enablePanelActionDownload` setting has been removed. ## Release Note The functionality that allowed users to download of a CSV export from a dashboard saved search panel without creating a report has been removed. To export CSV data from a dashboard panel, users may use the action menu of a saved search panel in a dashboard to generate a CSV report, and download the report from a toast popup when the report has finished generating. ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) - [x] This will appear in the **Release Notes** and follow the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Nov 20, 2024
2 tasks
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Nov 20, 2024
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Nov 20, 2024
tsullivan
added a commit
that referenced
this pull request
Nov 22, 2024
…201010) Follows #199033 ## Summary This PR further removes logic that uses `xpack.reporting.csv.enablePanelActionDownload`, and removes references of that setting from our documentation. See #199033 for the **release note**. ### Changes 1. `enablePanelActionDownload` exists as an **optional** setting in `packages/kbn-reporting/server/config_schema.ts` 2. The only reference to this setting marks it as unused in `x-pack/plugins/reporting/server/config/index.ts` 3. Removes the detection of the setting from the Upgrade Assistant integration ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…lastic#201010) Follows elastic#199033 ## Summary This PR further removes logic that uses `xpack.reporting.csv.enablePanelActionDownload`, and removes references of that setting from our documentation. See elastic#199033 for the **release note**. ### Changes 1. `enablePanelActionDownload` exists as an **optional** setting in `packages/kbn-reporting/server/config_schema.ts` 2. The only reference to this setting marks it as unused in `x-pack/plugins/reporting/server/config/index.ts` 3. Removes the detection of the setting from the Upgrade Assistant integration ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…lastic#201010) Follows elastic#199033 ## Summary This PR further removes logic that uses `xpack.reporting.csv.enablePanelActionDownload`, and removes references of that setting from our documentation. See elastic#199033 for the **release note**. ### Changes 1. `enablePanelActionDownload` exists as an **optional** setting in `packages/kbn-reporting/server/config_schema.ts` 2. The only reference to this setting marks it as unused in `x-pack/plugins/reporting/server/config/index.ts` 3. Removes the detection of the setting from the Upgrade Assistant integration ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://github.com/elastic/kibana-team/issues/1202
This PR removes the CSV Download feature, and API from Kibana. Any logic that is based on the
xpack.reporting.csv.enablePanelActionDownloadsetting has been removed.Release Note
The functionality that allowed users to download of a CSV export from a dashboard saved search panel without creating a report has been removed. To export CSV data from a dashboard panel, users may use the action menu of a saved search panel in a dashboard to generate a CSV report, and download the report from a toast popup when the report has finished generating.
For maintainers