Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Remove "download CSV" export type functionality #199033

Merged
merged 4 commits into from
Nov 6, 2024
Merged

[Reporting] Remove "download CSV" export type functionality #199033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15e84cf
[Reporting] Remove "download CSV" export type functionality
tsullivan Nov 5, 2024
1986cc9
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine Nov 5, 2024
cc93355
fix ts/lint
tsullivan Nov 5, 2024
15c65c1
fix i18n
tsullivan Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kbn-generate-csv/src/generate_csv.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const getMockConfig = (opts: Partial<CsvConfigType> = {}): CsvConfigType => ({
maxSizeBytes: 180000,
useByteOrderMarkEncoding: false,
scroll: { size: 500, duration: '30s', strategy: 'pit' },
enablePanelActionDownload: true,
enablePanelActionDownload: false,
maxConcurrentShardRequests: 5,
...opts,
});
Expand Down
4 changes: 2 additions & 2 deletions packages/kbn-generate-csv/src/generate_csv_esql.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ describe('CsvESQLGenerator', () => {
maxSizeBytes: 180000,
useByteOrderMarkEncoding: false,
scroll: { size: 500, duration: '30s', strategy: 'pit' },
enablePanelActionDownload: true,
enablePanelActionDownload: false,
maxConcurrentShardRequests: 5,
};

Expand Down Expand Up @@ -569,7 +569,7 @@ describe('CsvESQLGenerator', () => {
maxSizeBytes: 180000,
useByteOrderMarkEncoding: false,
scroll: { size: 500, duration: '30s', strategy: 'pit' },
enablePanelActionDownload: true,
enablePanelActionDownload: false,
maxConcurrentShardRequests: 5,
};
mockSearchResponse({
Expand Down
2 changes: 1 addition & 1 deletion packages/kbn-generate-csv/src/lib/get_export_settings.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ describe('getExportSettings', () => {
scroll: { size: 500, duration: '30s', strategy: 'pit' },
useByteOrderMarkEncoding: false,
maxConcurrentShardRequests: 5,
enablePanelActionDownload: true,
enablePanelActionDownload: false,
};

taskInstanceFields = { startedAt: null, retryAt: null };
Expand Down
1 change: 0 additions & 1 deletion packages/kbn-reporting/common/routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export const INTERNAL_ROUTES = {
DELETE_PREFIX: prefixInternalPath + '/jobs/delete', // docId is added to the final path
DOWNLOAD_PREFIX: prefixInternalPath + '/jobs/download', // docId is added to the final path
},
DOWNLOAD_CSV: prefixInternalPath + '/generate/immediate/csv_searchsource', // DEPRECATED
GENERATE_PREFIX: prefixInternalPath + '/generate', // exportTypeId is added to the final path
};

Expand Down
131 changes: 0 additions & 131 deletions packages/kbn-reporting/export_types/csv/csv_searchsource_immediate.test.ts
View file
Open in desktop

This file was deleted.

157 changes: 0 additions & 157 deletions packages/kbn-reporting/export_types/csv/csv_searchsource_immediate.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/kbn-reporting/export_types/csv/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,3 @@

export { CsvSearchSourceExportType } from './csv_searchsource';
export { CsvV2ExportType } from './csv_v2';
export { CsvSearchSourceImmediateExportType } from './csv_searchsource_immediate';
2 changes: 0 additions & 2 deletions packages/kbn-reporting/export_types/csv/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,10 @@
"@kbn/discover-plugin",
"@kbn/data-plugin",
"@kbn/generate-csv",
"@kbn/core-http-server",
"@kbn/reporting-server",
"@kbn/reporting-export-types-csv-common",
"@kbn/reporting-mocks-server",
"@kbn/core-http-request-handler-context-server",
"@kbn/field-formats-plugin",
"@kbn/core-http-server-mocks",
]
}
17 changes: 0 additions & 17 deletions packages/kbn-reporting/export_types/csv_common/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,6 @@ import type {

export * from './constants';

/**
* @deprecated
* Requires `xpack.reporting.csv.enablePanelActionDownload` set to `true` (default is false)
*/
export interface JobParamsDownloadCSV {
browserTimezone: string;
title: string;
searchSource: SerializedSearchSourceFields;
columns?: string[];
}

interface BaseParamsCSV {
searchSource: SerializedSearchSourceFields;
columns?: string[];
Expand Down Expand Up @@ -62,12 +51,6 @@ export interface TaskPayloadCsvFromSavedObject extends CsvFromSavedObjectBase, B

export const CSV_REPORTING_ACTION = 'generateCsvReport';

/**
* @deprecated
* Requires `xpack.reporting.csv.enablePanelActionDownload` set to `true` (default is false)
*/
export const CSV_SEARCHSOURCE_IMMEDIATE_TYPE = 'csv_searchsource_immediate';

/**
* @deprecated
* Supported in case older reports exist in storage
Expand Down
Loading