[Reporting] Remove "download CSV" export type functionality, Part 2 #201010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
release_note:breaking
backport:skip
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
tsullivan
force-pushed
the
reporting/remove-csv-download-upgrade-assistant
branch
from
b5ff439 to
60d1cf9
Compare
tsullivan
force-pushed
the
reporting/remove-csv-download-upgrade-assistant
branch
from
60d1cf9 to
392b936
Compare
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
|
sebelga
approved these changes
Nov 22, 2024
| @@ -60,7 +60,7 @@ const CaptureSchema = schema.object({ | |||
| const CsvSchema = schema.object({ | |||
| checkForFormulas: schema.boolean({ defaultValue: true }), | |||
| escapeFormulaValues: schema.boolean({ defaultValue: false }), | |||
| enablePanelActionDownload: schema.boolean({ defaultValue: false }), // unused as of 9.0 | |||
| enablePanelActionDownload: schema.maybe(schema.boolean({ defaultValue: false })), // unused as of 9.0 | |||
There was a problem hiding this comment.
So we still allow the enablePanelActionDownload setting to be in the yml file?
There was a problem hiding this comment.
Yes. We do not want to block instances from startup if this setting exists. The extent of the breaking change is just to ignore the setting.
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…lastic#201010) Follows elastic#199033 ## Summary This PR further removes logic that uses `xpack.reporting.csv.enablePanelActionDownload`, and removes references of that setting from our documentation. See elastic#199033 for the **release note**. ### Changes 1. `enablePanelActionDownload` exists as an **optional** setting in `packages/kbn-reporting/server/config_schema.ts` 2. The only reference to this setting marks it as unused in `x-pack/plugins/reporting/server/config/index.ts` 3. Removes the detection of the setting from the Upgrade Assistant integration ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…lastic#201010) Follows elastic#199033 ## Summary This PR further removes logic that uses `xpack.reporting.csv.enablePanelActionDownload`, and removes references of that setting from our documentation. See elastic#199033 for the **release note**. ### Changes 1. `enablePanelActionDownload` exists as an **optional** setting in `packages/kbn-reporting/server/config_schema.ts` 2. The only reference to this setting marks it as unused in `x-pack/plugins/reporting/server/config/index.ts` 3. Removes the detection of the setting from the Upgrade Assistant integration ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.
tsullivan
deleted the
reporting/remove-csv-download-upgrade-assistant
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #199033
Summary
This PR further removes logic that uses
xpack.reporting.csv.enablePanelActionDownload, and removes references of that setting from our documentation. See #199033 for the release note.Changes
enablePanelActionDownloadexists as an optional setting inpackages/kbn-reporting/server/config_schema.tsx-pack/plugins/reporting/server/config/index.tsChecklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.