[Reporting] Remove "download CSV" export type functionality (#199033)

## Summary Closes elastic/kibana-team#1202 This PR removes the CSV Download feature, and API from Kibana. Any logic that is based on the `xpack.reporting.csv.enablePanelActionDownload` setting has been removed. ## Release Note The functionality that allowed users to download of a CSV export from a dashboard saved search panel without creating a report has been removed. To export CSV data from a dashboard panel, users may use the action menu of a saved search panel in a dashboard to generate a CSV report, and download the report from a toast popup when the report has finished generating. ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) - [x] This will appear in the **Release Notes** and follow the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
elastic · Nov 6, 2024 · 1df9479 · 1df9479
1 parent 4f9ab47
commit 1df9479
Show file tree

Hide file tree

Showing 31 changed files with 10 additions and 940 deletions.
diff --git a/packages/kbn-generate-csv/src/generate_csv.test.ts b/packages/kbn-generate-csv/src/generate_csv.test.ts
@@ -47,7 +47,7 @@ const getMockConfig = (opts: Partial<CsvConfigType> = {}): CsvConfigType => ({
   maxSizeBytes: 180000,
   useByteOrderMarkEncoding: false,
   scroll: { size: 500, duration: '30s', strategy: 'pit' },
-  enablePanelActionDownload: true,
+  enablePanelActionDownload: false,
   maxConcurrentShardRequests: 5,
   ...opts,
 });

diff --git a/packages/kbn-generate-csv/src/generate_csv_esql.test.ts b/packages/kbn-generate-csv/src/generate_csv_esql.test.ts
@@ -98,7 +98,7 @@ describe('CsvESQLGenerator', () => {
       maxSizeBytes: 180000,
       useByteOrderMarkEncoding: false,
       scroll: { size: 500, duration: '30s', strategy: 'pit' },
-      enablePanelActionDownload: true,
+      enablePanelActionDownload: false,
       maxConcurrentShardRequests: 5,
     };
 
@@ -569,7 +569,7 @@ describe('CsvESQLGenerator', () => {
         maxSizeBytes: 180000,
         useByteOrderMarkEncoding: false,
         scroll: { size: 500, duration: '30s', strategy: 'pit' },
-        enablePanelActionDownload: true,
+        enablePanelActionDownload: false,
         maxConcurrentShardRequests: 5,
       };
       mockSearchResponse({

diff --git a/packages/kbn-generate-csv/src/lib/get_export_settings.test.ts b/packages/kbn-generate-csv/src/lib/get_export_settings.test.ts
@@ -39,7 +39,7 @@ describe('getExportSettings', () => {
       scroll: { size: 500, duration: '30s', strategy: 'pit' },
       useByteOrderMarkEncoding: false,
       maxConcurrentShardRequests: 5,
-      enablePanelActionDownload: true,
+      enablePanelActionDownload: false,
     };
 
     taskInstanceFields = { startedAt: null, retryAt: null };

diff --git a/packages/kbn-reporting/common/routes.ts b/packages/kbn-reporting/common/routes.ts
@@ -24,7 +24,6 @@ export const INTERNAL_ROUTES = {
     DELETE_PREFIX: prefixInternalPath + '/jobs/delete', // docId is added to the final path
     DOWNLOAD_PREFIX: prefixInternalPath + '/jobs/download', // docId is added to the final path
   },
-  DOWNLOAD_CSV: prefixInternalPath + '/generate/immediate/csv_searchsource', // DEPRECATED
   GENERATE_PREFIX: prefixInternalPath + '/generate', // exportTypeId is added to the final path
 };
 

diff --git a/packages/kbn-reporting/export_types/csv/csv_searchsource_immediate.test.ts b/packages/kbn-reporting/export_types/csv/csv_searchsource_immediate.test.ts
diff --git a/packages/kbn-reporting/export_types/csv/csv_searchsource_immediate.ts b/packages/kbn-reporting/export_types/csv/csv_searchsource_immediate.ts
diff --git a/packages/kbn-reporting/export_types/csv/index.ts b/packages/kbn-reporting/export_types/csv/index.ts
@@ -9,4 +9,3 @@
 
 export { CsvSearchSourceExportType } from './csv_searchsource';
 export { CsvV2ExportType } from './csv_v2';
-export { CsvSearchSourceImmediateExportType } from './csv_searchsource_immediate';
diff --git a/packages/kbn-reporting/export_types/csv/tsconfig.json b/packages/kbn-reporting/export_types/csv/tsconfig.json
@@ -21,12 +21,10 @@
     "@kbn/discover-plugin",
     "@kbn/data-plugin",
     "@kbn/generate-csv",
-    "@kbn/core-http-server",
     "@kbn/reporting-server",
     "@kbn/reporting-export-types-csv-common",
     "@kbn/reporting-mocks-server",
     "@kbn/core-http-request-handler-context-server",
     "@kbn/field-formats-plugin",
-    "@kbn/core-http-server-mocks",
   ]
 }
diff --git a/packages/kbn-reporting/export_types/csv_common/index.ts b/packages/kbn-reporting/export_types/csv_common/index.ts
@@ -18,17 +18,6 @@ import type {
 
 export * from './constants';
 
-/**
- * @deprecated
- * Requires `xpack.reporting.csv.enablePanelActionDownload` set to `true` (default is false)
- */
-export interface JobParamsDownloadCSV {
-  browserTimezone: string;
-  title: string;
-  searchSource: SerializedSearchSourceFields;
-  columns?: string[];
-}
-
 interface BaseParamsCSV {
   searchSource: SerializedSearchSourceFields;
   columns?: string[];
@@ -62,12 +51,6 @@ export interface TaskPayloadCsvFromSavedObject extends CsvFromSavedObjectBase, B
 
 export const CSV_REPORTING_ACTION = 'generateCsvReport';
 
-/**
- * @deprecated
- * Requires `xpack.reporting.csv.enablePanelActionDownload` set to `true` (default is false)
- */
-export const CSV_SEARCHSOURCE_IMMEDIATE_TYPE = 'csv_searchsource_immediate';
-
 /**
  * @deprecated
  * Supported in case older reports exist in storage
Original file line number	Diff line number	Diff line change
Expand Up		@@ -9,4 +9,3 @@

		export { CsvSearchSourceExportType } from './csv_searchsource';
		export { CsvV2ExportType } from './csv_v2';
		export { CsvSearchSourceImmediateExportType } from './csv_searchsource_immediate';