Add missing fields property on top_hits aggregation #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-trotta
reviewed
Apr 22, 2024
| * Array of wildcard (*) patterns. The request returns values for field names | ||
| * matching these patterns in the hits.fields property of the response. | ||
| */ | ||
| fields?: (FieldAndFormat | Field)[] |
There was a problem hiding this comment.
should it be FieldAndFormat[] | Field[]?
There was a problem hiding this comment.
That's a good question. My assumption was that fields could take an array that consisted of either, or a combination of the two (e.g. ['field_one', { field: 'field_two', format: 'xxx' }]). The docs suggest that's the case as well.
I was looking at the FieldFetcher subphase in the Elasticsearch repo to verify in the source, but my Java is pretty rusty so it's hard to tell. What does it seem like to you?
l-trotta
approved these changes
Apr 23, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
* Add missing fields property on top_hits aggregation * Use correct fields type * Update type for docvalue_fields too (cherry picked from commit 6b31d2b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See elastic/elasticsearch-js#2209.