Skip to content

Commit

Permalink
Add missing fields property on top_hits aggregation (#2522)
Browse files Browse the repository at this point in the history
* Add missing fields property on top_hits aggregation

* Use correct fields type

* Update type for docvalue_fields too
  • Loading branch information
JoshMock authored Apr 23, 2024
1 parent 0210914 commit 6b31d2b
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions specification/_types/aggregations/metric.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import { Dictionary } from '@spec_utils/Dictionary'
import { UserDefinedValue } from '@spec_utils/UserDefinedValue'
import { Field, Fields } from '@_types/common'
import { double, integer, long } from '@_types/Numeric'
import { QueryContainer } from '@_types/query_dsl/abstractions'
import { FieldAndFormat, QueryContainer } from '@_types/query_dsl/abstractions'
import { Script, ScriptField } from '@_types/Scripting'
import { Aggregation } from './Aggregation'
import { Missing } from './AggregationContainer'
Expand Down Expand Up @@ -338,12 +338,17 @@ export class TopHitsAggregation extends MetricAggregationBase {
/**
* Fields for which to return doc values.
*/
docvalue_fields?: Fields
docvalue_fields?: FieldAndFormat[]
/**
* If `true`, returns detailed information about score computation as part of a hit.
* @server_default false
*/
explain?: boolean
/**
* Array of wildcard (*) patterns. The request returns values for field names
* matching these patterns in the hits.fields property of the response.
*/
fields?: FieldAndFormat[]
/**
* Starting document offset.
* @server_default 0
Expand Down

0 comments on commit 6b31d2b

Please sign in to comment.