fields
added to top_hits
aggregation
#2209
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following query works and returns the
fields
information requested in thetop_hits
aggregation. However, the typescript definition for top hits aggregations (AggregationsTopHitsAggregation
) is missing thefields
entry.So typescript throws the following error:
Object literal may only specify known properties, but 'fields' does not exist in type 'AggregationsTopHitsAggregation'. Did you mean to write 'field'?
This PR adds the
fields
property to theAggregationsTopHitsAggregation
type with:fields?: (QueryDslFieldAndFormat | Field)[]
I've tested it works using the
QueryDslFieldAndFormat
andstring
types, and the array is required.