ToolItem with SWT.CHECK is not well displayed when checked and with background setted.

[RoiSoleil]

Describe the bug
ToolItem with SWT.CHECK is not well displayed when checked and with background setted.

With the fix :

To Reproduce

Snippet153

Environment:

1. Select the platform(s) on which the behavior is seen:

• • All OS
• • Windows
• • Linux
• • macOS

[Phillipus]

What problem is this trying to solve?

In your PR #542 you have removed this line on the Windows version of ToolBar:

result |= OS.TBCDRF_NOBACKGROUND;

As far as I can see, this affects the painting of all items, not just with SWT.CHECK, Also, the behaviour is different on Windows 11.

[RoiSoleil]

I'm trying to solve the problem that when a ToolItem with SWT.CHECK is selected and has a background, the fact that it's selected is not displayed (as you can see in the screenshot 2 / my fix is screenshot 3). I will try to see for Linux and MacOS tonight.

It's will solve these issues : eclipse-platform/eclipse.platform.ui#467
eclipse-platform/eclipse.platform.ui#340
eclipse-platform/eclipse.platform.ui#530

[Phillipus]

Sorry, but that's not clear to me when running your Snippet. On Windows 11 the Snippet behaves as expected.

[RoiSoleil]

I will try on Windows 11 too.

[jasonhy-wang]

Works as expected on Fedora 37

[lshanmug]

@deepika-u Can you please try this out? The snippet is in the PR.

[RoiSoleil]

In windows the bug is present when Eclipse is in darkmode. When in darkmode we dont we if a ToolItem is checked or not. This is really annoying. See an example without my fix :

And with my fix :

@Phillipus Are you sure that in Windows 11 it's ok ?

[Phillipus]

As I said, this change might affect all toolbar items not just checked ones. It also affects the colour when hovering over any tool item. Is that expected?

[RoiSoleil]

As I said, this change might affect all toolbar items not just checked ones. It also affects the colour when hovering over any tool item. Is that expected?

Yes this is expected. Custom background doesn't meen hiding hovering toolitem.

[RoiSoleil]

I tested on Windows 11 and i have the same problem in darkmode for ToomItem with check state.

Without my code :

With my code :

[Phillipus]

Isn't the underlying problem something to do with theme rendering? See eclipse-platform/eclipse.platform.ui#467

[RoiSoleil]

No for me it's the #26 that introduces a bug when dealing with custom background color on ToolItem. The checked state should not be hidden when a custom background is applied.
Please can someone deals with this bug because this is really annoying and there has been 4 releases with this bug.

@nnemkin
@vogella

[Phillipus]

@RoiSoleil But your solution is not the right way to fix this, I think. As I said, this affects the painting of all items, not just with SWT.CHECK. Even your screenshot in #541 (comment) shows in incorrect blue background color for dark theme. Have you considered how you change might have side effects for all users?

[RoiSoleil]

Please can you show me what's wrong in my screenshot ?
Also can you show me a correct way to show checked state for ToolItem using dark theme ?

[Phillipus]

@RoiSoleil OK, I've looked more into this now. What I mean is that in the dark theme I would have expected the enabled state on Windows to use dark grey colors and an outline as on Mac:

But I can also see that you have correctly identified #26 as the point where things regressed.

So, whereas your PR does put things back on Windows to how they were before that change, I wonder if the changes made to Toolbar in that commit need tweaking to arrive at a consistent solution on all platforms?

[RoiSoleil]

I'm OK with you, it should be consistent on all platforms. Unfortunately, i'm not skilled enough to do that on Mac and Linux ...
I thinks someone more skilled than me should deal with this bug. Maybe you can ?
I really think it should be fixed for the next release because as said before its really annoying ...

[RoiSoleil]

As i said the problem is not only with checked ToolItem, it's with every ToolItem with a background color. Here is an example of the Left Arrow under Windows, you can see how the hovering is not well painted :

With my code, you can see how the hovering is now well painted :

[RoiSoleil]

@Phillipus What do you think?

[Phillipus]

@RoiSoleil I can see how your PR ensures that the behaviour on Windows seems to be as it was before #26 but that commit also changed ToolBar on Mac and Linux. So maybe this needs some input from other SWT committers to see if there is a fix that might cover all platforms if required. Also, I think we may need to check if #26 has affected toolbar and tool tool items not just in dark theme.

[RoiSoleil]

@Phillipus May be we can fix Windows first and then the other platforms (MacOS seems to be ok with you previous screenshot). My commit is not specific for darktheme, it is for all themes setting a background to ToolItem.

@lshanmug
@deepika-u

What do you think ?

[niraj-modi]

@deepika-u Please verify the fix in next Eclipse I-Build. Thanks!

[deepika-u]

I have checked this in below build, it works fine. So it is verified.
Eclipse SDK
Version: 2023-06 (4.28)
Build id: I20230426-1800
OS: Windows 11, v.10.0, x86_64 / win32
Java vendor: Eclipse Adoptium
Java runtime version: 20+36
Java version: 20