ToolItem with SWT.CHECK is not well displayed when checked and with background setted.

[RoiSoleil]

ToolItem with SWT.CHECK is not well displayed when checked and with background setted.

Fix : #541

[github-actions]

Test Results

     303 files       303 suites   6m 18s ⏱️
  4 048 tests   4 034 ✔️   8 💤 5 ❌ 1 🔥
12 071 runs  11 994 ✔️ 70 💤 6 ❌ 1 🔥

For more details on these failures and errors, see this check.

Results for commit 148eac2.

♻️ This comment has been updated with latest results.

[RoiSoleil]

Failing tests doesn't seems to be related to my PR.

[vogella]

@SyntevoAlex could you review?

[mickaelistria]

@RoiSoleil in Eclipse project, we try to avoid merge commits. Please prefer rebasing as much as possible.

[RoiSoleil]

@RoiSoleil in Eclipse project, we try to avoid merge commits. Please prefer rebasing as much as possible.

@mickaelistria it should be ok now.

[RoiSoleil]

Can someone review this change for Windows ?

@HannesWell @iloveeclipse @niraj-modi

[deepika-u]

I am seeing 3 issues(when checked across multiple icons on the menu bar) as listed below :

Before the fix, i am seeing this way =>

After the fix, i am seeing this way =>

So the fix looks fine for me on dark theme on windows 11.

[RoiSoleil]

@deepika-u Thx for the test. This is exactly what i wanted to fix.

[vogella]

@deepika-u Thx for the test. This is exactly what i wanted to fix.

The white background of the sync icon in the package explorer looks bad. It this intended?

[RoiSoleil]

@vogella In Windows 10, i get this :

If in Windows 11, it's not good, i think it should be fixed in another specific issue ... (I'm not sure this is an actual issue)

[deepika-u]

@deepika-u Thx for the test. This is exactly what i wanted to fix.

The white background of the sync icon in the package explorer looks bad. It this intended?

@vogella
To be more specific on your query i see a consistency across this icon and other icons after the fix. This looks to be an obvious behavior for me.

The complete left set of icons are when hovered(abit whitish comparitively).
The complete right set of icons are when they are selected/enabled actually(abit bluish comparitively).
Again both look abit different and also wanted to point out that difference too(in the orange circle - you can make out that difference when same icon is selected.)

For your reference =>

Please let me know if that clarifies. Thanks.

[deepika-u]

@vogella In Windows 10, i get this :

If in Windows 11, it's not good, i think it should be fixed in another specific issue ... (I'm not sure this is an actual issue)

I have no clue on this issue.

[RoiSoleil]

@vogella In Windows 10, i get this :

If in Windows 11, it's not good, i think it should be fixed in another specific issue ... (I'm not sure this is an actual issue)

I have no clue on this issue.

It's Windows version specific (difference between Windows 10 and 11), It's another problem for me (I'm not sure this is an actual issue).

[RoiSoleil]

@vogella Any news ?

[deepika-u]

My vote goes to the fix.

[RoiSoleil]

@vogella @iloveeclipse @niraj-modi Tested on my personal Eclipse with the fix for 2 months and everything is good. Could you take à look ?

[vogella]

@SyntevoAlex could you test?

[RoiSoleil]

@SyntevoAlex could you test?

@SyntevoAlex @vogella any news ?

[merks]

Pulling this into my workspace leaves a sea of errors and I'm unable to launch. I think this needs to be squashed and rebased on master because for master the SWT version is 3.124.0 and this PR reduces that number.

Probably easiest if you switch to master, make sure it's pulled to the latest, apply these two changes, and force push your branch....

[merks]

Trying just the one SWT change locally, it does look better in dark theme with this change on Windows 10.

[lshanmug]

@niraj-modi Can you please take a look and merge this one?

[niraj-modi]

Code change LGTM.
Thanks @deepika-u @merks @RoiSoleil for verifying this PR.

[RoiSoleil]

Nice !

[deepika-u]

Verified this on below build and looks good to me.

Eclipse SDK
Version: 2023-06 (4.28)
Build id: I20230515-1800
OS: Windows 11, v.10.0, x86_64 / win32
Java vendor: Eclipse Adoptium
Java runtime version: 17.0.6+10
Java version: 17.0.6