[Eclipse 4.25 Dark Theme] View action buttons are not highlighted

[wolfgang-ch]

There are 2 dark theme issues in Eclipse 4.25

• A selected button is not highlighted (red box) in the view toolbar, 4.24 has a blue border around the action button. The green boxes are showing the correct button highlights
• The toolbar has a brighter grey background (pink boxes)

The same buttons in Eclipse 4.24

[RoiSoleil]

Any news about that ?

[akurtakov]

As it can be seen by lack of progress here - some help is needed for dark theme issues. Do you think you can try identifying the issue?

[wolfgang-ch]

The UI with this fix eclipse-platform/eclipse.platform.swt#541 (comment) is now better but still not very good visible

[trancexpress]

See also #467, #468, #648.

[pbodnar]

Great to see this annoying bug is finally fixed now in 4.28 (2023-06)! A bit surprised this didn't make it into the N&N, but whatever. ;)

Here are my 2 cents:

The UI with this fix eclipse-platform/eclipse.platform.swt#541 (comment) is now better but still not very good visible

@wolfgang-ch, I would say it depends... Anyway, I would suggest to close this issue as resolved and if desired, open a new one for improving the existing highlighting.

---

See also #467, #468, #648.

@trancexpress, yes, #467 and #648 seem like clear duplicates of this one. At least, I cannot see any difference. Anyone willing to close them? (maybe a typical "checklist" added to "new issue template" would help to avoid such duplicates?)

Regarding #468, it seems to be about something else (to quote from a comment there: "ignoring the push toggle buttons... a separate issue entirely").

Also there is this #306 created even before this one, but it is way too technical for me to be able to efficiently evaluate whether it is a duplicate as well...

[wolfgang-ch]

@wolfgang-ch, I would say it depends... Anyway, I would suggest to close this issue as resolved and if desired, open a new one for improving the existing highlighting.

The checked actions are now as before 😄 but I still see the second issue

The toolbar has a brighter grey background (pink boxes)

[pbodnar]

The checked actions are now as before 😄 but I still see the second issue

The toolbar has a brighter grey background (pink boxes)

Oh, I see. The "pink boxes" from the description screenshot. Maybe this is done on purpose? I have no idea. :) Anyway, the issue title says "View action buttons are not highlighted" and that got resolved, so better create a new issue? :)

[mrx23dot]

I've got another issue with dark theme, not sure if it needs new ticket:
whenever I select a menu it's unreadable

Version: 2023-06 (4.28.0)
Build id: 20230608-1333

[RoiSoleil]

This a completely different bug.

[vogella]

AFAICS this is solved in latest dark theme changes by @mvm-sap. Please test with latest I-Build from https://download.eclipse.org/eclipse/downloads/.