ToolItem with SWT.CHECK is not well displayed when checked and with

background setted. Fix : eclipse-platform#541
RoiSoleil · Feb 28, 2023 · 86aa7cf · 86aa7cf
1 parent 335d4fa
commit 86aa7cf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/ToolBar.java b/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/ToolBar.java
@@ -735,7 +735,7 @@ void layoutItems () {
 			}
 		}
 	}
-	
+
 	/*
 	 * Feature in Windows. When a tool bar is not flagged TBSTYLE_LIST already (SWT.RIGHT)
 	 * and contains both text and images, but not text + image in a single item,
@@ -1691,7 +1691,6 @@ LRESULT wmNotifyChild (NMHDR hdr, long wParam, long lParam) {
 						RECT rect = new RECT (nmcd.left, nmcd.top, nmcd.right, nmcd.bottom);
 						OS.SetDCBrushColor (nmcd.hdc, child.background);
 						OS.FillRect (nmcd.hdc, rect, OS.GetStockObject (OS.DC_BRUSH));
-						result |= OS.TBCDRF_NOBACKGROUND;
 					}
 					return new LRESULT (result);
 				}

diff --git a/examples/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet153.java b/examples/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet153.java
@@ -39,6 +39,7 @@ public static void main(String[] args) {
 	toggle.setText("Toggle Bar Colors");
 	new ToolItem(bar, SWT.SEPARATOR);
 	new ToolItem(bar, SWT.PUSH).setText("Push Button");
+	new ToolItem(bar, SWT.CHECK).setText("Check Button");
 	new ToolItem(bar, SWT.DROP_DOWN).setText("Drop Down");
 
 	toggle.addListener(SWT.Selection, event -> {