Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execution-core: Hide Payload and TxSkeleton structures from the public API #2069

Closed
moCello opened this issue Aug 2, 2024 · 0 comments · Fixed by #2078
Closed

execution-core: Hide Payload and TxSkeleton structures from the public API #2069

moCello opened this issue Aug 2, 2024 · 0 comments · Fixed by #2078
Assignees
Labels
module:execution-core Issues related to execution-core type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)

Comments

@moCello
Copy link
Member

moCello commented Aug 2, 2024

Summary

The internal Payload in both moonlight and phoenix transaction can be considered an implementation detail that doesn't need to leak to the user.

With this change execution-core needs to have a mechanism to turn the circuit-data to a proof.
This will be solved by introducing a Prover trait which can be used to implement different proof-creation mechanisms (like caching).

This will be partially fixed by #2078 which implements the changes and only stopping short of making the phoenix-payload private to not loose the previous mechanism of creating transactions.

@HDauven HDauven added type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc) module:execution-core Issues related to execution-core labels Aug 4, 2024
@HDauven HDauven changed the title execution-core: Hide Payload and TxSceleton structures from the public API execution-core: Hide Payload and TxSkeleton structures from the public API Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:execution-core Issues related to execution-core type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants