Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circuits: Add a way to construct a TxCircuit from bytes #232

Closed
moCello opened this issue Aug 8, 2024 · 0 comments · Fixed by #233 or #237
Closed

circuits: Add a way to construct a TxCircuit from bytes #232

moCello opened this issue Aug 8, 2024 · 0 comments · Fixed by #233 or #237

Comments

@moCello
Copy link
Member

moCello commented Aug 8, 2024

Summary

Since the TxCircuit will replace the UnprovenTransaction struct in the rusk-prover we need a way to create a TxCircuit from a blob of bytes.

We can achieve this in two ways:

  • Implement the Serializabla trait on TxCircuit to be able to create the struct from bytes.
  • Implement a from_slice constructor

The implementation of Serializable would be cleaner, but since it would also need to be generic over the height of the notes tree and the amount of input-notes it would probably require an implementation with a macro which seems overkill for this purpose.

Relevant Context

See rusk #2069 and #229

moCello added a commit that referenced this issue Aug 8, 2024
@moCello moCello changed the title circuits: Add TxCircuit::from_slice constructor to be able to create the struct from bytes circuits: Impl Serializable for TxCircuit Aug 8, 2024
@moCello moCello changed the title circuits: Impl Serializable for TxCircuit circuits: Add a way to construct a TxCircuit from bytes Aug 8, 2024
moCello added a commit that referenced this issue Aug 8, 2024
moCello added a commit that referenced this issue Aug 8, 2024
@moCello moCello closed this as completed in 8a5008b Aug 9, 2024
moCello added a commit that referenced this issue Aug 9, 2024
moCello added a commit that referenced this issue Aug 9, 2024
moCello added a commit that referenced this issue Aug 9, 2024
moCello added a commit that referenced this issue Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant