-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
circuits: Add a way to construct a TxCircuit
from bytes
#232
Comments
moCello
added a commit
that referenced
this issue
Aug 8, 2024
moCello
changed the title
circuits: Add
circuits: Impl Serializable for Aug 8, 2024
TxCircuit::from_slice
constructor to be able to create the struct from bytesTxCircuit
moCello
changed the title
circuits: Impl Serializable for
circuits: Add a way to construct a Aug 8, 2024
TxCircuit
TxCircuit
from bytes
moCello
added a commit
that referenced
this issue
Aug 8, 2024
Merged
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Since the
TxCircuit
will replace theUnprovenTransaction
struct in therusk-prover
we need a way to create aTxCircuit
from a blob of bytes.We can achieve this in two ways:
Serializabla
trait onTxCircuit
to be able to create the struct from bytes.from_slice
constructorThe implementation of
Serializable
would be cleaner, but since it would also need to be generic over the height of the notes tree and the amount of input-notes it would probably require an implementation with a macro which seems overkill for this purpose.Relevant Context
See rusk #2069 and #229
The text was updated successfully, but these errors were encountered: