Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

execution-core: Hide transaction payload structs from API #2078

Merged
merged 9 commits into from
Aug 12, 2024
Merged

execution-core: Hide transaction payload structs from API #2078

merged 9 commits into from
Aug 12, 2024

Conversation

moCello
Copy link
Member

@moCello moCello commented Aug 6, 2024

Resolves #2069

@moCello moCello force-pushed the mocello/2069_payload branch 4 times, most recently from f2ab923 to da6994a Compare August 9, 2024 15:58
@moCello moCello mentioned this pull request Aug 9, 2024
Closed
@moCello moCello marked this pull request as ready for review August 9, 2024 16:09
ZER0
ZER0 reviewed Aug 10, 2024
View reviewed changes
Copy link
Contributor

@ZER0 ZER0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have yet the insight on this to perform a proper review, so I will leave to the others that knows technically the execution-core better. Overall looks good to me, and I just left my two cents in a couple of generic coding aspect.

contracts/stake/tests/common/prove.rs Outdated Show resolved Hide resolved
contracts/transfer/tests/common/prove.rs Outdated Show resolved Hide resolved
ureeves
ureeves previously approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Small opinion, but non-blocking

execution-core/src/transfer.rs Outdated Show resolved Hide resolved
@moCello moCello force-pushed the mocello/2069_payload branch from 0e3ea90 to 38ebc0e Compare August 12, 2024 09:54
@moCello moCello requested a review from ureeves August 12, 2024 09:55
@moCello moCello merged commit 3b324db into master Aug 12, 2024
8 checks passed
@moCello moCello deleted the mocello/2069_payload branch August 12, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZER0 ZER0 ZER0 left review comments

@ureeves ureeves ureeves approved these changes

@HDauven HDauven Awaiting requested review from HDauven

@herr-seppia herr-seppia Awaiting requested review from herr-seppia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

execution-core: Hide Payload and TxSkeleton structures from the public API
3 participants
@moCello @ZER0 @ureeves