Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circuits: Restructure API for circuit creation #229

Closed
moCello opened this issue Aug 5, 2024 · 0 comments · Fixed by #230
Closed

circuits: Restructure API for circuit creation #229

moCello opened this issue Aug 5, 2024 · 0 comments · Fixed by #230

Comments

@moCello
Copy link
Member

moCello commented Aug 5, 2024 •
edited
Loading

Summary

Hide or even remove the TxInputNote and TxOutputNote structs to be able to create a circuit from only it's parameters. This is to improve the creation of a phoenix-transaction in execution-core without the need to depend on phoenix-circuits for it's types.

See rusk #2069
moCello added a commit that referenced this issue Aug 6, 2024
@moCello
circuits: Re-do TxCircuit construction
edd60b1 
Resolves #229
@moCello moCello mentioned this issue Aug 6, 2024
Merged
moCello added a commit that referenced this issue Aug 6, 2024
@moCello
circuits: Re-do TxCircuit construction
2d01728 
Resolves #229
moCello added a commit that referenced this issue Aug 6, 2024
@moCello
circuits: Re-do TxCircuit construction
dd7ba18 
Resolves #229
moCello added a commit that referenced this issue Aug 7, 2024
@moCello
circuits: Re-do TxCircuit construction
a950805 
Resolves #229
moCello added a commit that referenced this issue Aug 7, 2024
@moCello
circuits: Re-do TxCircuit construction
0509fbd 
Resolves #229
@moCello moCello mentioned this issue Aug 8, 2024
Closed
This was referenced Aug 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

circuits: Re-do TxCircuit construction dusk-network/phoenix
1 participant
@moCello