Code Coverage for Network Download REVIEW 1ST

[paul1956]

Adds VB Netword Download tests

Proposed changes

• Add 84 new Network Tests

Customer Impact

• Improve test coverage for VB Network Download

Regression?

• No

Risk

• Minimal only adds tests

Microsoft Reviewers: Open in CodeFlow

[codecov]

Codecov Report

Attention: Patch coverage is 99.66079% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.80466%. Comparing base (fae358b) to head (4361014).
Report is 5 commits behind head on main.

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main      #12221         +/-   ##
===================================================
+ Coverage   75.69021%   75.80466%   +0.11445%     
===================================================
  Files           3151        3154          +3     
  Lines         635600      637069       +1469     
  Branches       46951       46973         +22     
===================================================
+ Hits          481087      482928       +1841     
+ Misses        151076      150704        -372     
  Partials        3437        3437                 

Flag	Coverage Δ
Debug	75.80466% <99.66079%> (+0.11445%)	⬆️
integration	18.18012% <80.00000%> (-0.06746%)	⬇️
production	49.35676% <80.00000%> (+0.13210%)	⬆️
test	97.06195% <99.72771%> (+0.01142%)	⬆️
unit	46.43189% <80.00000%> (+0.23672%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[paul1956]

@Tanya-Solyanik @KlausLoeffelmann this just has network download tests. It's as simple as I can make it.

Please review first

I can then add the other cleanup with no code changes at a later time.

[paul1956]

@Tanya-Solyanik @KlausLoeffelmann this is ready for review once #12226 is merged. It should only consist of tests and a few corrections to comments where m_Name was left after variables were renamed to _name plus come cleanup to WebClientCopy in preparation of replacing it.

If you want, I could do a separate PR for WebClientCopy changes but most of it is being replaced and the changes avoid Merge issues, the changes should be 100% covered by the tests in this PR. The file has 50% coverage because I can't test the upload code (here) it has been tested against public FTP test servers, but I am also not changing UploadFile code except for variable naming issues.

Since this PR is mostly tests and the minor cleanup this might be something @Tanya-Solyanik or her team want to review and then @KlausLoeffelmann could do final signoff of the test server which is all new code. Sorry in advance, if I am misunderstanding signoff procedures or organizational hierarchies.