Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(tests): Remove -Pcoverage flag in test runs until we refactor coverage (#30917) #30918

Merged
merged 1 commit into from
Dec 12, 2024
Merged

test(tests): Remove -Pcoverage flag in test runs until we refactor coverage (#30917) #30918

merged 1 commit into from
Dec 12, 2024

Conversation

spbolton
Copy link
Contributor

@spbolton spbolton commented Dec 11, 2024 •
edited by github-actions bot
Loading

Proposed Changes

  • Removing the -Pcoverage flag that should remove errors in logs on jsps where it is being used. We are not collecting or using the data so it should have no other inpact on the scripts
  • flag was used in JVM Tests, IT Tests, Postman tests and E2E tests. These tests should pass as before and no exceptions logging a stack trace with org.jacoco.agent.rt or java.lang.instrument.IllegalClassFormatException should be seen in the logs

This PR fixes: #30917

@spbolton spbolton requested a review from a team as a code owner December 11, 2024 15:24
@spbolton spbolton linked an issue Dec 11, 2024 that may be closed by this pull request
Turn of maven coverage flag in ci build as it is causing exceptions and data is not used currently #30917
Closed
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Closed
@spbolton spbolton changed the title test(tests): Turn of maven coverage flag in ci build as it is c (#30917) test(tests): Remove -Pcoverage flag in test runs until we refactor coverage (#30917) Dec 11, 2024
dcolina
dcolina approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@dcolina dcolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@dcolina dcolina added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 13b4ae0 Dec 12, 2024
37 checks passed
@dcolina dcolina deleted the issue-30917-turn-of-maven-coverage-flag-in-ci-build-as-it-is branch December 12, 2024 11:26
@spbolton
Copy link
Contributor Author

spbolton commented Dec 17, 2024 •
edited
Loading

For an example of verification This example merge queue build does not have java.lang.instrument.IllegalClassFormatException and we do not seem to have any jobs blocking here or in trunk, https://github.com/dotCMS/core/actions/runs/12362113238/job/34501312823#step:3:828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcolina dcolina dcolina approved these changes

@jdotcms jdotcms jdotcms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn of maven coverage flag in ci build as it is causing exceptions and data is not used currently
3 participants
@spbolton @jdotcms @dcolina