Skip to content

Commit

Permalink
test(tests): Remove -Pcoverage flag in test runs until we refactor co…
Browse files Browse the repository at this point in the history
…verage (#30917) (#30918)

### Proposed Changes
* Removing the -Pcoverage flag that should remove errors in logs on jsps
where it is being used. We are not collecting or using the data so it
should have no other inpact on the scripts
* flag was used in JVM Tests, IT Tests, Postman tests and E2E tests.
These tests should pass as before and no exceptions logging a stack
trace with org.jacoco.agent.rt or
java.lang.instrument.IllegalClassFormatException should be seen in the
logs
  • Loading branch information
spbolton authored Dec 12, 2024
1 parent cadf653 commit 13b4ae0
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/cicd_comp_test-phase.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
- uses: ./.github/actions/core-cicd/maven-job
with:
stage-name: "JVM Tests"
maven-args: "-Pcoverage -Dprod test -pl :dotcms-core"
maven-args: " -Dprod test -pl :dotcms-core"
cleanup-runner: true
generates-test-results: true
github-token: ${{ secrets.GITHUB_TOKEN }}
Expand Down Expand Up @@ -151,7 +151,7 @@ jobs:
- uses: ./.github/actions/core-cicd/maven-job
with:
stage-name: "IT Tests ${{ matrix.suites.name }}"
maven-args: "-Dit.test.forkcount=1 -Pcoverage verify -pl :dotcms-integration -Dcoreit.test.skip=false ${{ matrix.suites.maven_args}}"
maven-args: "-Dit.test.forkcount=1 verify -pl :dotcms-integration -Dcoreit.test.skip=false ${{ matrix.suites.maven_args}}"
generates-test-results: true
cleanup-runner: true
dotcms-license: ${{ secrets.DOTCMS_LICENSE }}
Expand All @@ -176,7 +176,7 @@ jobs:
- uses: ./.github/actions/core-cicd/maven-job
with:
stage-name: "Postman ${{ matrix.collection_group }}"
maven-args: "-Pcoverage verify -pl :dotcms-postman -Dpostman.test.skip=false -Dpostman.collections=${{ matrix.collection_group }}"
maven-args: " verify -pl :dotcms-postman -Dpostman.test.skip=false -Dpostman.collections=${{ matrix.collection_group }}"
generates-test-results: true
dotcms-license: ${{ secrets.DOTCMS_LICENSE }}
requires-node: true
Expand Down Expand Up @@ -216,7 +216,7 @@ jobs:
with:
name: karate-reports
path: dotCMS/target/karate-reports
# E2E Tests
# E2E Testsgit
linux-e2e-tests:
name: E2E Tests ${{matrix.suites.name}}
runs-on: ubuntu-${{ vars.UBUNTU_RUNNER_VERSION || '24.04' }}
Expand All @@ -238,7 +238,7 @@ jobs:
- uses: ./.github/actions/core-cicd/maven-job
with:
stage-name: "E2E ${{ matrix.suites.name }}"
maven-args: "verify -Pcoverage -De2e.test.skip=false ${{ matrix.suites.maven_args}}"
maven-args: "verify -De2e.test.skip=false ${{ matrix.suites.maven_args}}"
generates-test-results: true
dotcms-license: ${{ secrets.DOTCMS_LICENSE }}
requires-node: true
Expand Down

0 comments on commit 13b4ae0

Please sign in to comment.