Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn of maven coverage flag in ci build as it is causing exceptions and data is not used currently #30917

Closed
spbolton opened this issue Dec 11, 2024 · 2 comments · Fixed by #30918
Closed

Turn of maven coverage flag in ci build as it is causing exceptions and data is not used currently #30917

spbolton opened this issue Dec 11, 2024 · 2 comments · Fixed by #30918
Assignees
@spbolton
Labels
Team : Platform Platform Team

Comments

@spbolton
Copy link
Contributor

spbolton commented Dec 11, 2024 •
edited
Loading

When we were trying to work with code coverage we added a maven profile to add the configuration to handle the bytecode manipulation required. The data returned does not work correctly due to our own bytecode manipulation with ByteBuddy and we need to do refactoring before we can properly handle code coverage. In the meantime we are getting errors in the logs due to this like the following. To cleanup the logs, prevent confusion when we are not using the coverage data we should remove the flag

The following can be seen in the e2e testing logs where -Pcoverage is being used.


DOTCMS]14:14:51.524  INFO  impl.DefaultConverterManager - Probably not an issue: com/dotcms/repackage/com.dotcms.repackage.jsx3.xml.CdfDocument is not available so the jsx3doc converter will not load. This is only an problem if you wanted to use it.
[DOTCMS]java.lang.instrument.IllegalClassFormatException: Error while instrumenting org/apache/jsp/html/portlet/ext/contentlet/edit_005fcontentlet_jsp with JaCoCo 0.8.11.202310140853/f33756c.
[DOTCMS]	at org.jacoco.agent.rt.internal_4742761.CoverageTransformer.transform(CoverageTransformer.java:94)
[DOTCMS]	at java.instrument/java.lang.instrument.ClassFileTransformer.transform(ClassFileTransformer.java:244)
[DOTCMS]	at java.instrument/sun.instrument.TransformerManager.transform(TransformerManager.java:188)
[DOTCMS]	at java.instrument/sun.instrument.InstrumentationImpl.transform(InstrumentationImpl.java:610)
[DOTCMS]	at java.base/java.lang.ClassLoader.defineClass1(Native Method)
[DOTCMS]	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027)
[DOTCMS]	at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
[DOTCMS]	at java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:524)
[DOTCMS]	at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:427)
[DOTCMS]	at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:421)
[DOTCMS]	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
[DOTCMS]	at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:420)
[DOTCMS]	at org.apache.jasper.servlet.JasperLoader.loadClass(JasperLoader.java:129)
[DOTCMS]	at org.apache.jasper.servlet.JasperLoader.loadClass(JasperLoader.java:58)
@spbolton spbolton added the Team : Platform Platform Team label Dec 11, 2024
@spbolton spbolton moved this to Next 1-3 Sprints in dotCMS - Product Planning Dec 11, 2024
@spbolton spbolton self-assigned this Dec 11, 2024
@spbolton spbolton linked a pull request Dec 11, 2024 that will close this issue
test(tests): Remove -Pcoverage flag in test runs until we refactor coverage (#30917) #30918
Merged
@github-actions GitHub Actions
Copy link

PRs:

@spbolton spbolton moved this from Next 1-3 Sprints to In Progress in dotCMS - Product Planning Dec 11, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 12, 2024
@spbolton
test(tests): Remove -Pcoverage flag in test runs until we refactor co…
13b4ae0 
…verage (#30917) (#30918)

### Proposed Changes
* Removing the -Pcoverage flag that should remove errors in logs on jsps
where it is being used. We are not collecting or using the data so it
should have no other inpact on the scripts
* flag was used in JVM Tests, IT Tests, Postman tests and E2E tests.
These tests should pass as before and no exceptions logging a stack
trace with org.jacoco.agent.rt or
java.lang.instrument.IllegalClassFormatException should be seen in the
logs
@github-project-automation github-project-automation bot moved this from In Progress to Internal QA in dotCMS - Product Planning Dec 12, 2024
@github-actions github-actions bot mentioned this issue Dec 12, 2024
Merged
@sfreudenthaler
Copy link
Contributor

not sure what to qa on this beyond what's already been running? Maybe we can move to done?

@sfreudenthaler sfreudenthaler moved this from Internal QA to Done in dotCMS - Product Planning Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spbolton spbolton

Labels
Team : Platform Platform Team
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(tests): Remove -Pcoverage flag in test runs until we refactor coverage (#30917) dotCMS/core
2 participants
@spbolton @sfreudenthaler