Added visualize function without storage #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 87.51% 87.37% -0.15%
==========================================
Files 89 89
Lines 5086 5092 +6
==========================================
- Hits 4451 4449 -2
- Misses 635 643 +8
|
janbruedigam
requested changes
Jun 16, 2023
| @@ -242,7 +279,7 @@ function animate_node!(storage::Storage{T,N}, id, shape, animation, shapevisuali | |||
| x = storage.x[id][i] | |||
| q = storage.q[id][i] | |||
| atframe(animation, frame_id) do | |||
| set_node!(x, q, shape, shapevisualizer, showshape) | |||
| set_node!(x, q, shape, shapevisualizer, showshape) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge branch 'visualize-function'
Incorporate the addition to the
visualizefunction, eliminating the need for storage input.A bug fix has also been implemented to allow users to set the
joint_radiusparameter during visualization explicitly. This gives users more control over the visual aspect of the system.This merge integrates the changes from the
visualize-functionbranch, integrating these improvements into the main branch.Authors: Mitchell Fogelson [email protected]