-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize constraints function #88
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #88 +/- ##
==========================================
- Coverage 87.51% 86.10% -1.42%
==========================================
Files 89 90 +1
Lines 5086 5167 +81
==========================================
- Hits 4451 4449 -2
- Misses 635 718 +83
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a simple test for this function? Maybe with a double pendulum or fourbar
|
||
function constraintstep!(mechanism::Mechanism{T}, freebodies::Vector{Body{T}}; regularization=1e-6) where T | ||
# Fetching all the free bodies | ||
# freebodies = [get_body(mechanism, id) for id in freeids] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be a comment?
end | ||
end | ||
|
||
# println([con_jac; I(num_bodies)*regularization]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comment here
Merge branch 'initialize_constraints_clean'
Integrate the new
initialize_constraint!
function that allows mechanisms to find feasible initial joint conditions. This function enhances the system's overall capability by allowing users to find constraint-satisfying mechanism configurations.This merge combines the changes from the
initialize_constraints_clean
branch, bringing the new function into the main branch.Authors: Mitchell Fogelson [email protected]