Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add event_time page #6383

Merged
merged 71 commits into from
Nov 19, 2024
Merged

add event_time page #6383

merged 71 commits into from
Nov 19, 2024

Conversation

@mirnawong1 mirnawong1 requested a review from a team as a code owner October 30, 2024 11:45
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 19, 2024 5:10pm

@github-actions github-actions bot added content Improvements or additions to content size: large This change will more than a week to address and might require more than one person Docs team Authored by the Docs team @dbt Labs labels Oct 30, 2024
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! A few suggested tweaks and clarifications but overall :chef_kiss:

website/docs/reference/resource-configs/event-time.md Outdated Show resolved Hide resolved
website/docs/reference/resource-configs/event-time.md Outdated Show resolved Hide resolved
website/static/img/docs/deploy/apples_to_apples.png Outdated Show resolved Hide resolved
website/docs/docs/dbt-versions/release-notes.md Outdated Show resolved Hide resolved
website/docs/reference/resource-configs/event-time.md Outdated Show resolved Hide resolved
website/docs/docs/deploy/advanced-ci.md Outdated Show resolved Hide resolved
website/docs/docs/deploy/advanced-ci.md Outdated Show resolved Hide resolved

When configured, `event_time` enables compare changes to:

- Compare data in CI versus production for overlapping times only, reducing false discrepancies.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Compare data in CI versus production for overlapping times only, reducing false discrepancies.
- Compare data in CI against production for only the overlapping times, avoiding false positives and returning results faster.

website/docs/docs/deploy/advanced-ci.md Outdated Show resolved Hide resolved
website/docs/docs/deploy/advanced-ci.md Show resolved Hide resolved
mirnawong1 and others added 6 commits October 30, 2024 17:32
Co-authored-by: Joel Labes <[email protected]>
Co-authored-by: Joel Labes <[email protected]>
Co-authored-by: Joel Labes <[email protected]>
Co-authored-by: Joel Labes <[email protected]>
Co-authored-by: Joel Labes <[email protected]>
Co-authored-by: Joel Labes <[email protected]>
```
</File>

This setup sets `record_timestamp` as the `event_time` for `my_seed`. It ensures that the `record_timestamp` is used consistently in [Advanced CI's compare changes](/docs/deploy/advanced-ci#speeding-up-comparisons) or [incremental microbatching](/docs/build/incremental-microbatch).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it was midway through, i was just trying to add a reminder of the effect it has on advanced ci or microbatch. but is overkill so removing

Copy link
Collaborator

@graciegoheen graciegoheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few final nits otherwise ready to go! thank you!

website/docs/docs/deploy/advanced-ci.md Outdated Show resolved Hide resolved
website/docs/docs/deploy/advanced-ci.md Outdated Show resolved Hide resolved
website/docs/docs/deploy/advanced-ci.md Outdated Show resolved Hide resolved
@mirnawong1 mirnawong1 enabled auto-merge November 19, 2024 17:07
@mirnawong1 mirnawong1 merged commit f420e6c into current Nov 19, 2024
9 checks passed
@mirnawong1 mirnawong1 deleted the add-event-time branch November 19, 2024 17:10
Copy link
Contributor

Check your created Crawler

Check your created index on your Algolia Application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person trigger-crawl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants